From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Foss Subject: Re: [PATCH hwc 3/4] drm_hwcomposer: Cleanup gl precompositor init and provide uses_GL flag Date: Thu, 26 Apr 2018 21:43:55 +0200 Message-ID: References: <1524769557-6108-1-git-send-email-john.stultz@linaro.org> <1524769557-6108-3-git-send-email-john.stultz@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by gabe.freedesktop.org (Postfix) with ESMTPS id C1D536E2A7 for ; Thu, 26 Apr 2018 19:43:59 +0000 (UTC) In-Reply-To: <1524769557-6108-3-git-send-email-john.stultz@linaro.org> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: John Stultz , dri-devel Cc: Rob Herring , Matt Szczesiak , Dmitry Shmidt , Sean Paul , Alexandru-Cosmin Gheorghe , Liviu Dudau , Alistair Strachan , Marissa Wall , David Hanna List-Id: dri-devel@lists.freedesktop.org VGhpcyBwYXRjaCBpczoKQWNrZWQtYnk6IFJvYmVydCBGb3NzIDxyb2JlcnQuZm9zc0Bjb2xsYWJv cmEuY29tPgoKCk9uIDA0LzI2LzIwMTggMDk6MDUgUE0sIEpvaG4gU3R1bHR6IHdyb3RlOgo+IFRo ZSBkcm1faHdjb21wb3NlciBoYXMgaXRzIG93biBHTCBwcmUtY29tcG9zaXRvciB3aGljaCBpcyB1 c2VkCj4gdG8gc3F1aXNoIGxheWVycyB3aGVuIHRoZXJlIGFyZSBtb3JlIGxheWVycyB0aGVuIHBs YW5lcyBvbiB0aGUKPiBkaXNwbGF5IGhhcmR3YXJlLiBJbiBtYW55IHdheXMgdGhpcyBkdXBsaWNh dGVzIHRoZSBjbGllbnQtc2lkZQo+IEdMIGNvbXBvc2l0aW5nIHRoYXQgaXMgZG9uZSBpbiBTdXJm YWNlRmxpbmdlciwgYnV0IGluIHRoZW9yeSBjYW4KPiBiZSBtb3JlIGhpZ2hseSBvcHRpbWl6ZWQg Zm9yIHRoZSBoYXJkd2FyZS4KPiAKPiBVbmZvcnR1bmF0ZWx5LCBkdWUgdG8gdGhlc2Ugb3B0aW1p emF0aW9ucywgdGhlIGRybV9od2NvbXBvc2VyJ3MKPiBwcmUtY29tcG9zaXRvciBiZWNvbWVzIHNv bWV3aGF0IGhhcmR3YXJlIHNwZWNpZmljIChvcmlnaW5hbGx5Cj4gdGFyZ2V0aW5nIG52aWRpYSBo YXJkd2FyZSwgSSBiZWxpZXZlKS4KPiAKPiBTbyBvbiBzb21lIGhhcmR3YXJlLCB0aGUgZ2wgcHJl Y29tcG9zaXRvciBtYXkgbm90IGFjdHVhbGx5Cj4gaW5pdGlhbGl6ZSBkdWUgdG8gaGFyZHdhcmUg bWlzc2luZyBmZWF0dXJlcywgb3IgdGhlIGhhcmR3YXJlCj4gc3VwcG9ydGluZyBkaWZmZXJlbnQg c2hhZGVyIEFQSXMuCj4gCj4gUmF0aGVyIHRoZW4gdHJ5IHRvIHJld29yayB0aGUgZHJtX2h3Y29t cG9zZXJzIHByZWNvbXBvc2l0b3IKPiB0byBiZSBtb3JlIGdlbmVyaWMsIEkgaW5zdGVhZCBzdWdn ZXN0IHRoYXQgd2hlbiB0aGUKPiBwcmVjb21wb3NpdG9yIGZhaWxzIHRvIGluaXRpYWxpemUsIHdl IHNpbXBseSBmYWxsIGJhY2sgdG8gdGhlCj4gYWxyZWFkeSBtb3JlIHdpZGVseSBjb21wYXRpYmxl IGNsaWVudCBjb21wb3NpdG9yIGluCj4gU3VyZmFjZUZsaW5nZXIuCj4gCj4gVGh1cywgdGhpcyBw YXRjaCBjbGVhbnMgdXAgc29tZSBvZiB0aGUgcHJlY29tcG9zaXRvcgo+IGluaXRpYWxpemF0aW9u LCB3aGljaCBkaWRuJ3QgaGFuZGxlIGZhaWx1cmVzIHdlbGwuCj4gCj4gQ2M6IE1hcmlzc2EgV2Fs bCA8bWFyaXNzYXdAZ29vZ2xlLmNvbT4KPiBDYzogU2VhbiBQYXVsIDxzZWFucGF1bEBnb29nbGUu Y29tPgo+IENjOiBEbWl0cnkgU2htaWR0IDxkaW1pdHJ5c2hAZ29vZ2xlLmNvbT4KPiBDYzogUm9i ZXJ0IEZvc3MgPHJvYmVydC5mb3NzQGNvbGxhYm9yYS5jb20+Cj4gQ2M6IE1hdHQgU3pjemVzaWFr IDxtYXR0LnN6Y3plc2lha0Bhcm0uY29tPgo+IENjOiBMaXZpdSBEdWRhdSA8TGl2aXUuRHVkYXVA YXJtLmNvbT4KPiBDYzogRGF2aWQgSGFubmEgPGRhdmlkLmhhbm5hMTFAZ21haWwuY29tPgo+IENj OiBSb2IgSGVycmluZyA8cm9iLmhlcnJpbmdAbGluYXJvLm9yZz4KPiBDYzogQWxleGFuZHJ1LUNv c21pbiBHaGVvcmdoZSA8QWxleGFuZHJ1LUNvc21pbi5HaGVvcmdoZUBhcm0uY29tPgo+IENjOiBB bGlzdGFpciBTdHJhY2hhbiA8YXN0cmFjaGFuQGdvb2dsZS5jb20+Cj4gUmV2aWV3ZWQtYnk6IFJv YiBIZXJyaW5nIDxyb2JoQGtlcm5lbC5vcmc+Cj4gU2lnbmVkLW9mZi1ieTogSm9obiBTdHVsdHog PGpvaG4uc3R1bHR6QGxpbmFyby5vcmc+Cj4gLS0tCj4gICBkcm1kaXNwbGF5Y29tcG9zaXRvci5j cHAgfCA0MCArKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tCj4gICBkcm1k aXNwbGF5Y29tcG9zaXRvci5oICAgfCAgMyArKysKPiAgIDIgZmlsZXMgY2hhbmdlZCwgMjQgaW5z ZXJ0aW9ucygrKSwgMTkgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RybWRpc3BsYXlj b21wb3NpdG9yLmNwcCBiL2RybWRpc3BsYXljb21wb3NpdG9yLmNwcAo+IGluZGV4IGU1NzA5MjMu LjQwYWYzYmUgMTAwNjQ0Cj4gLS0tIGEvZHJtZGlzcGxheWNvbXBvc2l0b3IuY3BwCj4gKysrIGIv ZHJtZGlzcGxheWNvbXBvc2l0b3IuY3BwCj4gQEAgLTIyMiw2ICsyMjIsMTMgQEAgaW50IERybURp c3BsYXlDb21wb3NpdG9yOjpJbml0KERybVJlc291cmNlcyAqZHJtLCBpbnQgZGlzcGxheSkgewo+ ICAgICAgIHJldHVybiByZXQ7Cj4gICAgIH0KPiAgIAo+ICsgIHByZV9jb21wb3NpdG9yXy5yZXNl dChuZXcgR0xXb3JrZXJDb21wb3NpdG9yKCkpOwo+ICsgIHJldCA9IHByZV9jb21wb3NpdG9yXy0+ SW5pdCgpOwo+ICsgIGlmIChyZXQpIHsKPiArICAgIEFMT0dFKCJGYWlsZWQgdG8gaW5pdGlhbGl6 ZSBPcGVuR0wgY29tcG9zaXRvciAlZCIsIHJldCk7Cj4gKyAgICBwcmVfY29tcG9zaXRvcl8ucmVz ZXQoKTsKPiArICB9Cj4gKwo+ICAgICBpbml0aWFsaXplZF8gPSB0cnVlOwo+ICAgICByZXR1cm4g MDsKPiAgIH0KPiBAQCAtMjk0LDE0ICszMDEsMTYgQEAgaW50IERybURpc3BsYXlDb21wb3NpdG9y OjpBcHBseVNxdWFzaChEcm1EaXNwbGF5Q29tcG9zaXRpb24gKmRpc3BsYXlfY29tcCkgewo+ICAg ICB9Cj4gICAKPiAgICAgc3RkOjp2ZWN0b3I8RHJtQ29tcG9zaXRpb25SZWdpb24+ICZyZWdpb25z ID0gZGlzcGxheV9jb21wLT5zcXVhc2hfcmVnaW9ucygpOwo+IC0gIHJldCA9IHByZV9jb21wb3Np dG9yXy0+Q29tcG9zaXRlKGRpc3BsYXlfY29tcC0+bGF5ZXJzKCkuZGF0YSgpLAo+ICsgIGlmIChw cmVfY29tcG9zaXRvcl8pIHsKPiArICAgIHJldCA9IHByZV9jb21wb3NpdG9yXy0+Q29tcG9zaXRl KGRpc3BsYXlfY29tcC0+bGF5ZXJzKCkuZGF0YSgpLAo+ICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICByZWdpb25zLmRhdGEoKSwgcmVnaW9ucy5zaXplKCksIGZiLmJ1ZmZlcigp LAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkaXNwbGF5X2NvbXAtPmlt cG9ydGVyKCkpOwo+IC0gIHByZV9jb21wb3NpdG9yXy0+RmluaXNoKCk7Cj4gKyAgICBwcmVfY29t cG9zaXRvcl8tPkZpbmlzaCgpOwo+ICAgCj4gLSAgaWYgKHJldCkgewo+IC0gICAgQUxPR0UoIkZh aWxlZCB0byBzcXVhc2ggbGF5ZXJzIik7Cj4gLSAgICByZXR1cm4gcmV0Owo+ICsgICAgaWYgKHJl dCkgewo+ICsgICAgICBBTE9HRSgiRmFpbGVkIHRvIHNxdWFzaCBsYXllcnMiKTsKPiArICAgICAg cmV0dXJuIHJldDsKPiArICAgIH0KPiAgICAgfQo+ICAgCj4gICAgIHJldCA9IGRpc3BsYXlfY29t cC0+Q3JlYXRlTmV4dFRpbWVsaW5lRmVuY2UoKTsKPiBAQCAtMzI4LDE0ICszMzcsMTYgQEAgaW50 IERybURpc3BsYXlDb21wb3NpdG9yOjpBcHBseVByZUNvbXBvc2l0ZSgKPiAgICAgfQo+ICAgCj4g ICAgIHN0ZDo6dmVjdG9yPERybUNvbXBvc2l0aW9uUmVnaW9uPiAmcmVnaW9ucyA9IGRpc3BsYXlf Y29tcC0+cHJlX2NvbXBfcmVnaW9ucygpOwo+IC0gIHJldCA9IHByZV9jb21wb3NpdG9yXy0+Q29t cG9zaXRlKGRpc3BsYXlfY29tcC0+bGF5ZXJzKCkuZGF0YSgpLAo+ICsgIGlmIChwcmVfY29tcG9z aXRvcl8pIHsKPiArICAgIHJldCA9IHByZV9jb21wb3NpdG9yXy0+Q29tcG9zaXRlKGRpc3BsYXlf Y29tcC0+bGF5ZXJzKCkuZGF0YSgpLAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICByZWdpb25zLmRhdGEoKSwgcmVnaW9ucy5zaXplKCksIGZiLmJ1ZmZlcigpLAo+ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkaXNwbGF5X2NvbXAtPmltcG9ydGVyKCkp Owo+IC0gIHByZV9jb21wb3NpdG9yXy0+RmluaXNoKCk7Cj4gKyAgICBwcmVfY29tcG9zaXRvcl8t PkZpbmlzaCgpOwo+ICAgCj4gLSAgaWYgKHJldCkgewo+IC0gICAgQUxPR0UoIkZhaWxlZCB0byBw cmUtY29tcG9zaXRlIGxheWVycyIpOwo+IC0gICAgcmV0dXJuIHJldDsKPiArICAgIGlmIChyZXQp IHsKPiArICAgICAgQUxPR0UoIkZhaWxlZCB0byBwcmUtY29tcG9zaXRlIGxheWVycyIpOwo+ICsg ICAgICByZXR1cm4gcmV0Owo+ICsgICAgfQo+ICAgICB9Cj4gICAKPiAgICAgcmV0ID0gZGlzcGxh eV9jb21wLT5DcmVhdGVOZXh0VGltZWxpbmVGZW5jZSgpOwo+IEBAIC0zOTUsMTUgKzQwNiw2IEBA IGludCBEcm1EaXNwbGF5Q29tcG9zaXRvcjo6UHJlcGFyZUZyYW1lKERybURpc3BsYXlDb21wb3Np dGlvbiAqZGlzcGxheV9jb21wKSB7Cj4gICAgIHN0ZDo6dmVjdG9yPERybUNvbXBvc2l0aW9uUmVn aW9uPiAmcHJlX2NvbXBfcmVnaW9ucyA9Cj4gICAgICAgICBkaXNwbGF5X2NvbXAtPnByZV9jb21w X3JlZ2lvbnMoKTsKPiAgIAo+IC0gIGlmICghcHJlX2NvbXBvc2l0b3JfKSB7Cj4gLSAgICBwcmVf Y29tcG9zaXRvcl8ucmVzZXQobmV3IEdMV29ya2VyQ29tcG9zaXRvcigpKTsKPiAtICAgIGludCBy ZXQgPSBwcmVfY29tcG9zaXRvcl8tPkluaXQoKTsKPiAtICAgIGlmIChyZXQpIHsKPiAtICAgICAg QUxPR0UoIkZhaWxlZCB0byBpbml0aWFsaXplIE9wZW5HTCBjb21wb3NpdG9yICVkIiwgcmV0KTsK PiAtICAgICAgcmV0dXJuIHJldDsKPiAtICAgIH0KPiAtICB9Cj4gLQo+ICAgICBpbnQgc3F1YXNo X2xheWVyX2luZGV4ID0gLTE7Cj4gICAgIGlmIChzcXVhc2hfcmVnaW9ucy5zaXplKCkgPiAwKSB7 Cj4gICAgICAgc3F1YXNoX2ZyYW1lYnVmZmVyX2luZGV4XyA9IChzcXVhc2hfZnJhbWVidWZmZXJf aW5kZXhfICsgMSkgJSAyOwo+IGRpZmYgLS1naXQgYS9kcm1kaXNwbGF5Y29tcG9zaXRvci5oIGIv ZHJtZGlzcGxheWNvbXBvc2l0b3IuaAo+IGluZGV4IGYxOTY1ZmIuLmVkNmM1ZjkgMTAwNjQ0Cj4g LS0tIGEvZHJtZGlzcGxheWNvbXBvc2l0b3IuaAo+ICsrKyBiL2RybWRpc3BsYXljb21wb3NpdG9y LmgKPiBAQCAtOTgsNiArOTgsOSBAQCBjbGFzcyBEcm1EaXNwbGF5Q29tcG9zaXRvciB7Cj4gICAg ICAgcmV0dXJuICZzcXVhc2hfc3RhdGVfOwo+ICAgICB9Cj4gICAKPiArICBib29sIHVzZXNfR0wo KSB7Cj4gKyAgICByZXR1cm4gISFwcmVfY29tcG9zaXRvcl87Cj4gKyAgfQo+ICAgIHByaXZhdGU6 Cj4gICAgIHN0cnVjdCBNb2RlU3RhdGUgewo+ICAgICAgIGJvb2wgbmVlZHNfbW9kZXNldCA9IGZh bHNlOwo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK