dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: phasta@kernel.org, Alex Deucher <alexdeucher@gmail.com>
Cc: dakr@kernel.org, matthew.brost@intel.com,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/sched: avoid killing parent entity on child SIGKILL v3
Date: Wed, 29 Oct 2025 14:57:44 +0100	[thread overview]
Message-ID: <fa72946c-5b69-4f11-802a-0a4e5f9bb390@amd.com> (raw)
In-Reply-To: <ff3db8827921a5b92c3a5915684eee61d6fe74f5.camel@mailbox.org>

On 10/28/25 14:13, Philipp Stanner wrote:
> On Tue, 2025-10-28 at 09:07 -0400, Alex Deucher wrote:
>> Looks like this hasn't landed yet.  Can someone push this?
> 
> Pushed it (with fixed commit message) to drm-misc-fixes.
> 
> I had Acked it for Christian but it seems that was lost.

Sorry, been on vacation last week and it took me till today to get through all my mails and back to this issue.

Thanks for taking care of it.

Christian.

> 
> Thx Alex
> 
> P.
> 
>>
>> Alex
>>
>> On Fri, Oct 17, 2025 at 2:18 AM Philipp Stanner <phasta@mailbox.org> wrote:
>>>
>>> On Wed, 2025-10-15 at 16:01 +0200, Christian König wrote:
>>>> From: David Rosca <david.rosca@amd.com>
>>>>
>>>> The DRM scheduler tracks who last uses an entity and when that process
>>>> is killed blocks all further submissions to that entity.
>>>>
>>>> The problem is that we didn't track who initially created an entity, so
>>>> when a process accidently leaked its file descriptor to a child and
>>>> that child got killed, we killed the parent's entities.
>>>>
>>>> Avoid that and instead initialize the entities last user on entity
>>>> creation. This also allows to drop the extra NULL check.
>>>>
>>>> v2: still use cmpxchg
>>>> v3: improve the commit message
>>>>
>>>> Signed-off-by: David Rosca <david.rosca@amd.com>
>>>> Signed-off-by: Christian König <christian.koenig@amd.com>
>>>> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/4568
>>>> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
>>>> CC: stable@vger.kernel.org
>>>
>>> Acked-by: Philipp Stanner <phasta@kernel.org>
>>>
>>>
>>> Fire at will, Christian. Maybe optionally with the commit message nits
>>> twirked in we discussed before.
>>>
>>>
>>> P.


      reply	other threads:[~2025-10-29 13:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-15 14:01 [PATCH] drm/sched: avoid killing parent entity on child SIGKILL v3 Christian König
2025-10-16 12:31 ` Philipp Stanner
2025-10-16 13:11   ` Christian König
2025-10-16 17:20     ` Philipp Stanner
2025-10-16 17:31       ` Christian König
2025-10-17  6:18 ` Philipp Stanner
2025-10-28 13:07   ` Alex Deucher
2025-10-28 13:13     ` Philipp Stanner
2025-10-29 13:57       ` Christian König [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa72946c-5b69-4f11-802a-0a4e5f9bb390@amd.com \
    --to=christian.koenig@amd.com \
    --cc=alexdeucher@gmail.com \
    --cc=dakr@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    --cc=phasta@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).