From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleksandr Andrushchenko Subject: Re: [PATCH v1] drm/simple_kms_helper: Fix NULL pointer dereference with no active CRTC Date: Thu, 22 Feb 2018 19:16:01 +0200 Message-ID: References: <1519279759-7803-1-git-send-email-andr2000@gmail.com> <1f051697-468d-76b9-a2be-16a281f57249@epam.com> <20180222161128.GC6419@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail-lf0-x242.google.com (mail-lf0-x242.google.com [IPv6:2a00:1450:4010:c07::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id EDCA26EECF for ; Thu, 22 Feb 2018 17:16:04 +0000 (UTC) Received: by mail-lf0-x242.google.com with SMTP id m69so8446200lfe.8 for ; Thu, 22 Feb 2018 09:16:04 -0800 (PST) In-Reply-To: <20180222161128.GC6419@phenom.ffwll.local> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Oleksandr Andrushchenko , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, daniel.vetter@intel.com, airlied@linux.ie List-Id: dri-devel@lists.freedesktop.org T24gMDIvMjIvMjAxOCAwNjoxMSBQTSwgRGFuaWVsIFZldHRlciB3cm90ZToKPiBPbiBUaHUsIEZl YiAyMiwgMjAxOCBhdCAwODoxMjo0OEFNICswMjAwLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3 cm90ZToKPj4gT24gMDIvMjIvMjAxOCAwODowOSBBTSwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28g d3JvdGU6Cj4+PiBGcm9tOiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xla3NhbmRyX2FuZHJ1 c2hjaGVua29AZXBhbS5jb20+Cj4+Pgo+Pj4gSXQgaXMgcG9zc2libGUgdGhhdCBkcm1fc2ltcGxl X2ttc19wbGFuZV9hdG9taWNfY2hlY2sgY2FsbGVkCj4+PiB3aXRoIG5vIENSVEMgc2V0LCBlLmcu IHdoZW4gdXNlci1zcGFjZSBhcHBsaWNhdGlvbiBzZXRzIENSVENfSUQvRkJfSUQKPj4+IHRvIDAg YmVmb3JlIGRvaW5nIGFueSBhY3R1YWwgZHJhd2luZy4gVGhpcyBsZWFkcyB0byBOVUxMIHBvaW50 ZXIKPj4+IGRlcmVmZXJlbmNlIGJlY2F1c2UgaW4gdGhpcyBjYXNlIG5ldyBDUlRDIHN0YXRlIGlz IE5VTEwgYW5kIG11c3QgYmUKPj4+IGNoZWNrZWQgYmVmb3JlIGFjY2Vzc2luZy4KPj4+Cj4+PiBT aWduZWQtb2ZmLWJ5OiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xla3NhbmRyX2FuZHJ1c2hj aGVua29AZXBhbS5jb20+Cj4+PiBSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZl dHRlckBmZndsbC5jaD4KPj4+Cj4+PiAtLS0KPj4+IENoYW5nZXMgc2luY2UgaW5pdGlhbDoKPj4+ IC0gcmUtd29ya2VkIGNoZWNrcyBmb3IgbnVsbCBDUlRDIGFzIHN1Z2dlc3RlZCBieSBEYW5pZWwg VmV0dGVyCj4+PiAtLS0KPj4+ICAgIGRyaXZlcnMvZ3B1L2RybS9kcm1fc2ltcGxlX2ttc19oZWxw ZXIuYyB8IDEwICsrKy0tLS0tLS0KPj4+ICAgIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMo KyksIDcgZGVsZXRpb25zKC0pCj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9k cm1fc2ltcGxlX2ttc19oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fc2ltcGxlX2ttc19o ZWxwZXIuYwo+Pj4gaW5kZXggOWNhOGE0YTU5Yjc0Li40YTFkYmQ4OGIxZWMgMTAwNjQ0Cj4+PiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX3NpbXBsZV9rbXNfaGVscGVyLmMKPj4+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9kcm1fc2ltcGxlX2ttc19oZWxwZXIuYwo+Pj4gQEAgLTEyMSwxMiArMTIx LDYgQEAgc3RhdGljIGludCBkcm1fc2ltcGxlX2ttc19wbGFuZV9hdG9taWNfY2hlY2soc3RydWN0 IGRybV9wbGFuZSAqcGxhbmUsCj4+PiAgICAJcGlwZSA9IGNvbnRhaW5lcl9vZihwbGFuZSwgc3Ry dWN0IGRybV9zaW1wbGVfZGlzcGxheV9waXBlLCBwbGFuZSk7Cj4+PiAgICAJY3J0Y19zdGF0ZSA9 IGRybV9hdG9taWNfZ2V0X25ld19jcnRjX3N0YXRlKHBsYW5lX3N0YXRlLT5zdGF0ZSwKPj4+ICAg IAkJCQkJCSAgICZwaXBlLT5jcnRjKTsKPj4+IC0JaWYgKCFjcnRjX3N0YXRlLT5lbmFibGUpCj4+ PiAtCQlyZXR1cm4gMDsgLyogbm90aGluZyB0byBjaGVjayB3aGVuIGRpc2FibGluZyBvciBkaXNh YmxlZCAqLwo+Pj4gLQo+Pj4gLQlpZiAoY3J0Y19zdGF0ZS0+ZW5hYmxlKQo+Pj4gLQkJZHJtX21v ZGVfZ2V0X2h2X3RpbWluZygmY3J0Y19zdGF0ZS0+bW9kZSwKPj4+IC0JCQkJICAgICAgICZjbGlw LngyLCAmY2xpcC55Mik7Cj4+PiAgICAJcmV0ID0gZHJtX2F0b21pY19oZWxwZXJfY2hlY2tfcGxh bmVfc3RhdGUocGxhbmVfc3RhdGUsIGNydGNfc3RhdGUsCj4+PiAgICAJCQkJCQkgICZjbGlwLAo+ Pj4gQEAgLTEzNyw3ICsxMzEsOSBAQCBzdGF0aWMgaW50IGRybV9zaW1wbGVfa21zX3BsYW5lX2F0 b21pY19jaGVjayhzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKPj4+ICAgIAkJcmV0dXJuIHJldDsK Pj4+ICAgIAlpZiAoIXBsYW5lX3N0YXRlLT52aXNpYmxlKQo+Pj4gLQkJcmV0dXJuIC1FSU5WQUw7 Cj4+IERhbmllbCwgSSBoYXZlIHB1dCB5b3VyIFItYiB0YWcsIGJ1dCBJIGhhZCByZW1vdmVkIHN1 Z2dlc3RlZAo+PiAiV0FSTl9PTihjcnRjX3N0YXRlICYmIGNydGNfc3RhdGUtPmVuYWJsZSk7Igo+ PiBoZXJlIGFzIGl0IGZpcmVzIGVhY2ggdGltZSB3aGVuIGNydGNfc3RhdGUgaXMgbm90IE5VTEwu Cj4+IFBsZWFzZSBsZXQgbWUga25vdyBpZiB0aGlzIGlzIG5vdCBvayBhbmQgeW91IHdhbnQgbWUg dG8gcmVtb3ZlCj4+IHlvdXIgUi1iIHRhZy4KPiBJJ20gYSBiaXQgY29uZnVzZWQgd2h5IHRoYXQg ZmlyZXMsIGJ1dCBvaCB3ZWxsLiBBcHBsaWVkLCB0aGFua3MgZm9yIHlvdXIKPiBwYXRjaC4KVGhh bmsgeW91Cj4gLURhbmllbAo+Cj4+PiArCQlyZXR1cm4gMDsKPj4+ICsKPj4+ICsJZHJtX21vZGVf Z2V0X2h2X3RpbWluZygmY3J0Y19zdGF0ZS0+bW9kZSwgJmNsaXAueDIsICZjbGlwLnkyKTsKPj4+ ICAgIAlpZiAoIXBpcGUtPmZ1bmNzIHx8ICFwaXBlLT5mdW5jcy0+Y2hlY2spCj4+PiAgICAJCXJl dHVybiAwOwo+PiBUaGFuayB5b3UsCj4+IE9sZWtzYW5kcgo+PiBfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+PiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4+ IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=