Re: [PATCH 01/10] drm/ttm: allocate resource object instead of embedding it v2

["Christian König" <ckoenig.leichtzumerken@gmail.com>]

Am 07.06.21 um 18:40 schrieb Thomas Hellström (Intel):
>
> On 6/2/21 12:09 PM, Christian König wrote:
> ...
>> @@ -728,14 +728,15 @@ static int ttm_bo_add_move_fence(struct 
>> ttm_buffer_object *bo,
>>    */
>>   static int ttm_bo_mem_force_space(struct ttm_buffer_object *bo,
>>                     const struct ttm_place *place,
>> -                  struct ttm_resource *mem,
>> +                  struct ttm_resource **mem,
>>                     struct ttm_operation_ctx *ctx)
>>   {
>>       struct ttm_device *bdev = bo->bdev;
>> -    struct ttm_resource_manager *man = ttm_manager_type(bdev, 
>> mem->mem_type);
>> +    struct ttm_resource_manager *man;
>>       struct ww_acquire_ctx *ticket;
>>       int ret;
>>   +    man = ttm_manager_type(bdev, (*mem)->mem_type);
>
> Isn't (*mem) uninitialized here? Should be place->mem_type? Eviction 
> is immediately sent to the bushes.

Indeed and I'm like 99% sure that Nirmoy has pointed that out to me as well.

Looks like I missed to fix that one. We need more CI testing.

Thanks,
Christian.

>
> Got at least one additional NULL pointer deref to track down in the 
> eviction code, but could be a merge error of mine as well.
>
> /Thomas
>
>