dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: maxime.ripard@bootlin.com, sean@poorly.run,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: Ignore drm_gem_vram_mm_funcs in generated documentation
Date: Wed, 5 Jun 2019 11:59:04 +0200	[thread overview]
Message-ID: <fe2df569-da1f-a54c-8a8e-e921a979278f@suse.de> (raw)
In-Reply-To: <20190605090308.efdkhxqnaydorubm@sirius.home.kraxel.org>


[-- Attachment #1.1.1: Type: text/plain, Size: 1258 bytes --]

Hi

Am 05.06.19 um 11:03 schrieb Gerd Hoffmann:
> On Tue, Jun 04, 2019 at 01:13:30PM +0200, Thomas Zimmermann wrote:
>> The documentation tools interpret drm_gem_vram_mm_funcs as function and
>> there appears to be no way of inline-documenting constants.
> 
>> -/**
>> +/*
>>   * drm_gem_vram_mm_funcs - Functions for &struct drm_vram_mm
> 
> "struct drm_gem_vram_mm_funcs" ?
> 
> (see include/drm/drm_gem.h where struct drm_gem_object_funcs is
> documented that way).

The documented source line is

  const struct drm_vram_mm_funcs drm_gem_vram_mm_funcs = {

and I tried to document the purpose of the constant 'drm_gem_vram_mm_funcs'.

Documenting global constants is not described in the kernel guide and I
could not find a source-code example either. Function and struct style
with '-' didn't work; member-field style with '@' neither. The only way
seems to be adding it to an .rst file in Documentation. But then it's
not part of the API documentation, but somewhere in the text.

Best regards
Thomas


> cheers,
>   Gerd
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Linux GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2019-06-05  9:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-04 11:13 [PATCH] drm: Ignore drm_gem_vram_mm_funcs in generated documentation Thomas Zimmermann
2019-06-05  9:03 ` Gerd Hoffmann
2019-06-05  9:59   ` Thomas Zimmermann [this message]
2019-06-05 15:58     ` Gerd Hoffmann
2019-06-06  6:39       ` Thomas Zimmermann
2019-06-06  7:45         ` Gerd Hoffmann
2019-06-06  7:49           ` Daniel Vetter
2019-06-06  8:03             ` Thomas Zimmermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe2df569-da1f-a54c-8a8e-e921a979278f@suse.de \
    --to=tzimmermann@suse.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kraxel@redhat.com \
    --cc=maxime.ripard@bootlin.com \
    --cc=sean@poorly.run \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox