From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3188FC433EF for ; Wed, 10 Nov 2021 13:02:24 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EEA9361248 for ; Wed, 10 Nov 2021 13:02:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EEA9361248 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F2A156E239; Wed, 10 Nov 2021 13:02:22 +0000 (UTC) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by gabe.freedesktop.org (Postfix) with ESMTPS id 601FC6E239 for ; Wed, 10 Nov 2021 13:02:21 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dafna) with ESMTPSA id C97371F45597 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=collabora.com; s=mail; t=1636549340; bh=ErvxNUWA0REJ9i7yu5E9ch2/zI4aNi+H1FtFhszYxCU=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Rl32QoZdJoq1jrOWWYZa33XgRssbyOydx6xd6dMtNNJ2UzT7z2O9KQjcHFDhhWQYw yV2NNImuezONHu5VKY8DKRQRWZioTnuDXlip3c+EV8HN56nRoHjuqCBL6YVQmB6Z42 g5WMif+TKBWr2fQMMD4EH9HeIkb6AU/4jOBU9itrHwUfN9j3DRyupyadbaVr1rJ7gN iOjW+nYibc1RsD2D4DRq5hzApS6qfITJ27zb46C8FvXlyoPBg1HAEgM7qVPB1hm0zV 8xEPwqdAEQyyg7Z8Q2vqLsdUpYUEKlAHvWTPLjHDXgJCYbFg0TG6ANfoSdEW9M0WGq knostVF9UGwNQ== Subject: Re: [PATCH] drm/bridge: parade-ps8640: Assign drm_device to dp aux channel To: AngeloGioacchino Del Regno , a.hajda@samsung.com References: <20211104102035.243305-1-angelogioacchino.delregno@collabora.com> From: Dafna Hirschfeld Message-ID: Date: Wed, 10 Nov 2021 15:02:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211104102035.243305-1-angelogioacchino.delregno@collabora.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jonas@kwiboo.se, airlied@linux.ie, robert.foss@linaro.org, dri-devel@lists.freedesktop.org, narmstrong@baylibre.com, linux-kernel@vger.kernel.org, jernej.skrabec@gmail.com, Laurent.pinchart@ideasonboard.com, kernel@collabora.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 04.11.21 12:20, AngeloGioacchino Del Regno wrote: > As it was done with other bridge drivers and to solve a warning coming > from drm_dp_aux_register(), add a backpointer to drm_device in the > drm_dp_aux that we're registering. > it is common to dump the exact warning in the commit log so people can locate it later. Maybe also add 'Fixes' tag? apart of that Reviewed-by: Dafna Hirschfeld > Signed-off-by: AngeloGioacchino Del Regno > --- > drivers/gpu/drm/bridge/parade-ps8640.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c > index 191cc196c9d1..20d8e606d543 100644 > --- a/drivers/gpu/drm/bridge/parade-ps8640.c > +++ b/drivers/gpu/drm/bridge/parade-ps8640.c > @@ -455,6 +455,7 @@ static int ps8640_bridge_attach(struct drm_bridge *bridge, > goto err_dsi_attach; > } > > + ps_bridge->aux.drm_dev = bridge->dev; > ret = drm_dp_aux_register(&ps_bridge->aux); > if (ret) { > dev_err(dev, "failed to register DP AUX channel: %d\n", ret); >