From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9028C624D4 for ; Thu, 3 Sep 2026 06:52:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1B2E810E0A1; Thu, 3 Sep 2026 06:52:07 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.b="XHBbSQqH"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="de+rhubq"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="UVgfLsaT"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="3/8WztDH"; dkim-atps=neutral Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by gabe.freedesktop.org (Postfix) with ESMTPS id 61A2010E082 for ; Thu, 3 Sep 2026 06:52:05 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B776821D6F; Thu, 3 Sep 2026 06:51:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1788418319; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/dR/ctsOK+KyY9o7eN9esQJj+dT+DeqxclJI3LJ1s4M=; b=XHBbSQqHzINGAEVBcucq0PCaLo8JWtXAx5JWDmnKp+SxORaED6LDGeX1wmWoPPUgbbGZHP YcNyA7F2zBVceMeEeMyRPdgvxs1gEftiLzsUtAimnGWpCMhBsK9K0/dCJRwvtR+QgtSiSq nyVt0cJx7Rz2yV1SA+/7N4Osix5Ktpk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1788418319; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/dR/ctsOK+KyY9o7eN9esQJj+dT+DeqxclJI3LJ1s4M=; b=de+rhubqpHi0PEcQNa2UPzkGqJOyt1k72vmscG4JMqA3+Ekx3AvixQ8+uUWyzVHuKDrrkH 7nUlAePBwnhWxICA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1788418315; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/dR/ctsOK+KyY9o7eN9esQJj+dT+DeqxclJI3LJ1s4M=; b=UVgfLsaTkPqYRifjeLnDtbm9sByfawPhfLh/XKjI2AZnzbByRGTVDwgkWkCYH8R6H4wW0e doW8dJbg7eThFtuLIV1R9Nl8GYJUDPYGI2+zZsm2tswN4UOzVKMd5YHYy3jA1sdAim6YD/ /huAqXJj9IAyjCb6Ib8eyIQo31Gs8qI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1788418315; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/dR/ctsOK+KyY9o7eN9esQJj+dT+DeqxclJI3LJ1s4M=; b=3/8WztDHbB+HcGsMVUU2KY1zgiNxzll5wxES4QXhGg3o5CJvyfV1G+nKWwpguLTegKjQ/F Hi63sX3VgaOiAEAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7EA9C136E6; Thu, 3 Sep 2026 06:51:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 5qx8HQsZmWrlRgAAD6G6ig (envelope-from ); Thu, 03 Sep 2026 06:51:55 +0000 Message-ID: Date: Thu, 3 Sep 2026 08:51:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] drm/sysfb: Use iosys_map_memset() to clear buffer To: Chen-Yu Tsai , Maarten Lankhorst , Maxime Ripard Cc: dri-devel@lists.freedesktop.org References: <20260903060651.3724163-1-wenst@chromium.org> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <20260903060651.3724163-1-wenst@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.993]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; URIBL_BLOCKED(0.00)[suse.de:mid,chromium.org:email,imap1.dmz-prg2.suse.org:helo,suse.com:url]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[chromium.org:email,suse.de:mid,suse.com:url] X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Am 03.09.26 um 08:06 schrieb Chen-Yu Tsai: > The atomic disable in drm/sysfb currently clears the buffer using > memset_io(). Since the mapping is provided in a |struct iosys_map|, > it is better to use the related API instead of extracting the vaddr. > This is mentioned as a TODO item. > > Switch to iosys_map_memset(), which takes the mapping as well as an > offset into the mapping. > > Signed-off-by: Chen-Yu Tsai > --- > drivers/gpu/drm/sysfb/drm_sysfb_modeset.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/sysfb/drm_sysfb_modeset.c b/drivers/gpu/drm/sysfb/drm_sysfb_modeset.c > index d2de29caf89e..99b13af4e391 100644 > --- a/drivers/gpu/drm/sysfb/drm_sysfb_modeset.c > +++ b/drivers/gpu/drm/sysfb/drm_sysfb_modeset.c > @@ -375,13 +375,11 @@ void drm_sysfb_plane_helper_atomic_disable(struct drm_plane *plane, There's a newer version of this function in the drm-misc-next branch. Please rebase your patch onto this code. Best regards Thomas > { > struct drm_device *dev = plane->dev; > struct drm_sysfb_device *sysfb = to_drm_sysfb_device(dev); > - struct iosys_map dst = sysfb->fb_addr; > struct drm_plane_state *plane_state = drm_atomic_get_new_plane_state(state, plane); > - void __iomem *dst_vmap = dst.vaddr_iomem; /* TODO: Use mapping abstraction */ > unsigned int dst_pitch = sysfb->fb_pitch; > const struct drm_format_info *dst_format = sysfb->fb_format; > struct drm_rect dst_clip; > - unsigned long lines, linepixels, i; > + unsigned long lines, linepixels, i, offset; > int idx; > > drm_rect_init(&dst_clip, > @@ -395,11 +393,10 @@ void drm_sysfb_plane_helper_atomic_disable(struct drm_plane *plane, > return; > > /* Clear buffer to black if disabled */ > - dst_vmap += drm_fb_clip_offset(dst_pitch, dst_format, &dst_clip); > - for (i = 0; i < lines; ++i) { > - memset_io(dst_vmap, 0, linepixels * dst_format->cpp[0]); > - dst_vmap += dst_pitch; > - } > + offset = drm_fb_clip_offset(dst_pitch, dst_format, &dst_clip); > + for (i = 0; i < lines; ++i) > + iosys_map_memset(&sysfb->fb_addr, offset + dst_pitch * i, 0, > + linepixels * dst_format->cpp[0]); > > drm_dev_exit(idx); > } -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, (HRB 36809, AG Nürnberg)