From: Frej Drejhammar <frej.drejhammar@gmail.com>
To: Kevin Hao <haokexin@gmail.com>
Cc: dri-devel@lists.freedesktop.org, "Jyri Sarha" <jyri.sarha@iki.fi>,
"Tomi Valkeinen" <tomi.valkeinen@ideasonboard.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Maíra Canal" <mcanal@igalia.com>
Subject: Re: [PATCH] drm/tilcdc: Set preferred depth
Date: Sun, 17 Mar 2024 20:18:57 +0100 [thread overview]
Message-ID: <kh6h4bra6.fsf@gmail.com> (raw)
In-Reply-To: <20240317033918.535716-1-haokexin@gmail.com> (Kevin Hao's message of "Sun, 17 Mar 2024 11:39:18 +0800")
Hi Kevin,
Kevin Hao <haokexin@gmail.com> writes:
> But after kernel commit c91acda3a380, the FB will not be created
> successfully due to the check of the valid pixel format. Then the bpp
> is set to 24, but the 'depth = 16' and 'bpp = 24' combo is not a valid
> pixel format.
>
> Fix this issue by explicitly setting the preferred_depth in this driver.
> With this change, the modesetting driver would choose the correct
> depth/bpp combo based on our setting in xorg.conf.
Check the fix in [1], with it not only does the X-server work with a
color depth of 16 bits, it also enables the use of a 24 bit color depth.
As I'm the author of the solution in [1] I'm partial to it as it is a
more general solution to the regression. I have no standing in this
community as [1] is my first contribution to the DRM system, but if I
had, I would NAK this patch as it only fixes the regression for one
driver and does not enable the use of a 24 bit color depth which is
something the hardware is capable of.
Best regards,
--Frej
[1] https://lore.kernel.org/all/e7ef6d422365986f49746b596735f7a0b939574d.1710698387.git.frej.drejhammar@gmail.com/
next prev parent reply other threads:[~2024-03-17 19:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-17 3:39 [PATCH] drm/tilcdc: Set preferred depth Kevin Hao
2024-03-17 19:18 ` Frej Drejhammar [this message]
2024-03-18 0:48 ` Kevin Hao
2024-03-18 19:21 ` Frej Drejhammar
2024-03-19 11:05 ` sarha
2024-03-19 19:17 ` Frej Drejhammar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=kh6h4bra6.fsf@gmail.com \
--to=frej.drejhammar@gmail.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=haokexin@gmail.com \
--cc=jyri.sarha@iki.fi \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mcanal@igalia.com \
--cc=mripard@kernel.org \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox