Re: [PATCH v2 5/5] dt-bindings: add documentation for Rockchip rk3399 display controllers

[Tomasz Figa <tfiga@chromium.org>]

Hi Mark,

Mark Yao <mark.yao <at> rock-chips.com> writes:

> 
> Cc: Rob Herring <robh+dt <at> kernel.org>
> Cc: Pawel Moll <pawel.moll <at> arm.com>
> Cc: Mark Rutland <mark.rutland <at> arm.com>
> Cc: Ian Campbell <ijc+devicetree <at> hellion.org.uk>
> Cc: Kumar Gala <galak <at> codeaurora.org>
> 
> Signed-off-by: Mark Yao <mark.yao <at> rock-chips.com>
> ---
>  .../bindings/display/rockchip/rockchip-vop.txt     |    5 +++++
>  1 file changed, 5 insertions(+)

Please see my comment inline.

> 
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-
vop.txt b/Documentation/devicetree/bindings/display/rockchip/rockchip-
vop.txt
> index 196121f..6bf8473 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
>  <at>  <at>  -8,6 +8,11  <at>  <at>  Required properties:
>  - compatible: value should be one of the following
>  		"rockchip,rk3036-vop";
>  		"rockchip,rk3288-vop";
> +		"rockchip,rk3399-vop-big";
> +		"rockchip,rk3399-vop-lit";
> +Document compatible values for rk3399 display controllers.
> +Big and little display controllers are not identical and have differing
> +feature sets on the rk3399.

I think this doesn't really need any explanation. If two separate 
compatible strings are given, it means that the hardware is different. :)

Other than that,

Reviewed-by: Tomasz Figa <tfiga@chromium.org>

Best regards,
Tomasz


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel