From: Kevin Hilman <khilman@baylibre.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-pm@vger.kernel.org, "Len Brown" <len.brown@intel.com>,
"Pavel Machek" <pavel@ucw.cz>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Lina Iyer" <lina.iyer@linaro.org>,
"Axel Haslam" <ahaslam@baylibre.com>,
"Marek Szyprowski" <m.szyprowski@samsung.com>,
"Jon Hunter" <jonathanh@nvidia.com>,
"Andy Gross" <andy.gross@linaro.org>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"David Airlie" <airlied@linux.ie>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Maruthi Srinivas Bayyavarapu" <Maruthi.Bayyavarapu@amd.com>,
dri-devel@lists.freedesktop.org,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [RESEND PATCH v3 2/2] PM / Domains: Remove redundant wrapper functions for system PM
Date: Wed, 15 Jun 2016 14:01:43 -0700 [thread overview]
Message-ID: <m2bn32p3ns.fsf@baylibre.com> (raw)
In-Reply-To: <1464601388-26693-3-git-send-email-ulf.hansson@linaro.org> (Ulf Hansson's message of "Mon, 30 May 2016 11:43:08 +0200")
Ulf Hansson <ulf.hansson@linaro.org> writes:
> Due to the previous changes to genpd, which removed the suspend_power_off
> flag, several of the system PM callbacks is no longer doing any additional
> checks but only invoking a corresponding pm_generic_* helper function.
>
> To clean up the code let's remove these wrapper functions as they have
> become redundant. Instead assign the system PM callbacks directly to
> the pm_generic_*() helper function.
>
> While changing this, it became clear that some of the current system PM
> callbacks in genpd, invokes the wrong callback at the driver level. For
> example, genpd's ->restore() callback invokes pm_generic_resume(), while
> it should be pm_generic_restore(). Let's fix this as well.
>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
Acked-by: Kevin Hilman <khilman@baylibre.com>
Kevin
next prev parent reply other threads:[~2016-06-15 21:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 9:43 [RESEND PATCH v3 0/2] PM / Domains: Second step in improving system PM code in genpd Ulf Hansson
2016-05-30 9:43 ` [RESEND PATCH v3 1/2] PM / Domains: Allow genpd to power on during the system PM phases Ulf Hansson
2016-06-15 21:00 ` Kevin Hilman
2016-06-16 11:30 ` maruthi srinivas
2016-05-30 9:43 ` [RESEND PATCH v3 2/2] PM / Domains: Remove redundant wrapper functions for system PM Ulf Hansson
2016-06-15 21:01 ` Kevin Hilman [this message]
2016-06-15 8:22 ` [RESEND PATCH v3 0/2] PM / Domains: Second step in improving system PM code in genpd Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2bn32p3ns.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=Maruthi.Bayyavarapu@amd.com \
--cc=ahaslam@baylibre.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=andy.gross@linaro.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=jonathanh@nvidia.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=len.brown@intel.com \
--cc=lina.iyer@linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox