From: James Cloos <cloos@jhcloos.com>
To: Christian Schmidt <schmidt@digadd.de>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] Fix wrong assumptions in cea_for_each_detailed_block v2
Date: Tue, 15 Nov 2011 04:39:34 -0500 [thread overview]
Message-ID: <m3aa7xu3kh.fsf@jhcloos.com> (raw)
In-Reply-To: <4EBF866F.1090805@digadd.de> (Christian Schmidt's message of "Sun, 13 Nov 2011 09:57:19 +0100")
>>>>> "CS" == Christian Schmidt <schmidt@digadd.de> writes:
CS> The current logic misunderstands the spec about CEA 18byte descriptors.
CS> First, the spec doesn't state "detailed timing descriptors" but "18 byte
CS> descriptors", so any data record could be stored, mixed timings and
CS> other data, just as in the standard EDID.
CS> Second, the lower four bit of byte 3 of the CEA record do not contain
CS> the number of descriptors, but "the total number of DTDs defining native
CS> formats in the whole EDID [...], starting with the first DTD in the DTD
CS> list (which starts in the base EDID block)." A device can of course
CS> support non-native formats.
CS> As such the number can't be used to determine n, and the existing code
CS> will filter non-timing 18byte descriptors anyway.
CS> V2 removes an unused variable warning.
CS> Signed-off-by: Christian Schmidt <schmidt@digadd,de>
Tested-by: James Cloos <cloos@jhcloos.com>
Works fine here on top of Linus’ 7f80850d3f9f with a Radeon HD 4290 and
an hdmi-connected tv.
-JimC
--
James Cloos <cloos@jhcloos.com> OpenPGP: 1024D/ED7DAEA6
CS> _______________________________________________
CS> dri-devel mailing list
CS> dri-devel@lists.freedesktop.org
CS> http://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2011-11-15 9:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-13 8:57 [PATCH] Fix wrong assumptions in cea_for_each_detailed_block v2 Christian Schmidt
2011-11-14 22:53 ` Adam Jackson
2011-11-15 9:39 ` James Cloos [this message]
2011-11-15 12:40 ` Andy Furniss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3aa7xu3kh.fsf@jhcloos.com \
--to=cloos@jhcloos.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=schmidt@digadd.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox