From: Takashi Iwai <tiwai@suse.de>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
peter.ujfalusi@ti.com, tomi.valkeinen@ti.com,
arnaud.pouliquen@st.com, dri-devel@lists.freedesktop.org,
liam.r.girdwood@linux.intel.com, tony@atomide.com,
broonie@kernel.org, Jyri Sarha <jsarha@ti.com>,
bcousson@baylibre.com, linux-omap@vger.kernel.org
Subject: Re: [PATCH v8 1/6] ALSA: pcm: add IEC958 channel status helper for hw_params
Date: Wed, 30 Mar 2016 08:21:18 +0200 [thread overview]
Message-ID: <s5h4mbo8p0h.wl-tiwai@suse.de> (raw)
In-Reply-To: <20160329172312.GR5783@n2100.arm.linux.org.uk>
On Tue, 29 Mar 2016 19:23:12 +0200,
Russell King - ARM Linux wrote:
>
> On Tue, Mar 29, 2016 at 10:54:08AM +0200, Takashi Iwai wrote:
> > On Thu, 17 Mar 2016 13:22:29 +0100,
> > Jyri Sarha wrote:
> > >
> > > Add IEC958 channel status helper that gets the audio properties from
> > > snd_pcm_hw_params instead of snd_pcm_runtime. This is needed to
> > > produce the channel status bits already in audio stream configuration
> > > phase.
> > >
> > > Signed-off-by: Jyri Sarha <jsarha@ti.com>
> >
> > This patch looks almost good to me, but...
> >
> > > @@ -71,6 +59,7 @@ int snd_pcm_create_iec958_consumer(struct snd_pcm_runtime *runtime, u8 *cs,
> > > IEC958_AES4_CON_MAX_WORDLEN_24;
> > > break;
> > > case 24:
> > > + case 32: /* Assume 24-bit width for 32-bit samples. */
> > > ws = IEC958_AES4_CON_WORDLEN_24_20 |
> > > IEC958_AES4_CON_MAX_WORDLEN_24;
> > > break;
> >
> > ... this change is silently slipped in. It should be mentioned in the
> > changelog, or split to another patch, as this is basically an
> > orthogonal change.
>
> Does it even make sense - AES doesn't have support for 32-bit samples,
> it can only ever truncate them down to 24-bit.
Well, using SNDRV_PCM_FORMAT_S32_* for 24 bit samples is seen often on
real devices, mostly on PCI ones. So, adding the value 32 check there
itself is valid, I suppose. It's rather due to a bad design in the
current API.
The actual bits should be specified hw_params.msbits field, instead.
But, not all drivers set this properly, unfortunately.
Takashi
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-03-30 6:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 12:22 [PATCH v8 0/6] Implement generic ASoC HDMI codec and use it in tda998x Jyri Sarha
2016-03-17 12:22 ` [PATCH v8 1/6] ALSA: pcm: add IEC958 channel status helper for hw_params Jyri Sarha
2016-03-28 19:38 ` Mark Brown
[not found] ` <164484552294777b0b9b88d7982bd6bfb0da9a9f.1458214526.git.jsarha-l0cyMroinI0@public.gmane.org>
2016-03-29 8:54 ` Takashi Iwai
2016-03-29 17:23 ` Russell King - ARM Linux
2016-03-30 6:21 ` Takashi Iwai [this message]
[not found] ` <s5h4mbo8p0h.wl-tiwai-l3A5Bk7waGM@public.gmane.org>
2016-03-30 8:25 ` Jyri Sarha
2016-03-30 10:24 ` Takashi Iwai
2016-03-17 12:22 ` [PATCH v8 2/6] ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders Jyri Sarha
[not found] ` <cover.1458214526.git.jsarha-l0cyMroinI0@public.gmane.org>
2016-03-17 12:22 ` [PATCH v8 3/6] ASoC: hdmi-codec: Add audio abort() callback for video side to use Jyri Sarha
2016-03-17 12:22 ` [PATCH v8 4/6] drm/i2c: tda998x: Improve tda998x_configure_audio() audio related pdata Jyri Sarha
2016-03-17 12:22 ` [PATCH v8 5/6] drm/i2c: tda998x: Register ASoC hdmi-codec and add audio DT binding Jyri Sarha
2016-03-17 12:22 ` [PATCH v8 6/6] ARM: dts: am335x-boneblack: Add HDMI audio support Jyri Sarha
[not found] ` <dd3484868647610840d4803dd3378014ce1c95b7.1458214526.git.jsarha-l0cyMroinI0@public.gmane.org>
2016-03-19 6:39 ` Jean-Francois Moine
2016-03-21 7:53 ` Jyri Sarha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h4mbo8p0h.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=arnaud.pouliquen@st.com \
--cc=bcousson@baylibre.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=peter.ujfalusi@ti.com \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox