dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Christian K6nig <christian.koenig@amd.com>
Cc: Huang Rui <ray.huang@amd.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/ttm: Use scnprintf() for avoiding potential buffer overflow
Date: Wed, 11 Mar 2020 08:57:53 +0100	[thread overview]
Message-ID: <s5h8sk79vcu.wl-tiwai@suse.de> (raw)
In-Reply-To: <85766da1-7021-2ea1-990f-813f08d80cd8@amd.com>

On Wed, 11 Mar 2020 08:56:11 +0100,
Christian K6nig wrote:
> 
> Am 11.03.20 um 08:52 schrieb Huang Rui:
> > On Wed, Mar 11, 2020 at 03:34:52PM +0800, Takashi Iwai wrote:
> >> Since snprintf() returns the would-be-output size instead of the
> >> actual output size, the succeeding calls may go beyond the given
> >> buffer limit.  Fix it by replacing with scnprintf().
> >>
> >> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > Reviewed-by: Huang Rui <ray.huang@amd.com>
> 
> Reviewed-by: Christian König <christian.koenig@amd.com>
> 
> Takashi, should I push this to drm-misc-next or do you want to merge
> that somehow else?

Please take through your tree as you like.


Thanks!

Takashi
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

      reply	other threads:[~2020-03-11  7:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-11  7:34 [PATCH] drm/ttm: Use scnprintf() for avoiding potential buffer overflow Takashi Iwai
2020-03-11  7:52 ` Huang Rui
2020-03-11  7:56   ` Christian König
2020-03-11  7:57     ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h8sk79vcu.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=ray.huang@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox