From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: Atomicity in KMS panic notifier
Date: Mon, 05 May 2014 17:04:57 +0200
Message-ID: <s5h8uqgfequ.wl%tiwai@suse.de>
References: <s5htx94fkfi.wl%tiwai@suse.de>
	<CAKMK7uHcYvuViEeyxLc75+kMVPPaKMr8svJQysk124--cjGL+g@mail.gmail.com>
	<s5hd2fsffhk.wl%tiwai@suse.de>
	<CAKMK7uGD5JCQSfk+Vuf=qrjU9x+Y+-W3o-xyGyTM_BreR_XZcw@mail.gmail.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <CAKMK7uGD5JCQSfk+Vuf=qrjU9x+Y+-W3o-xyGyTM_BreR_XZcw@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel <dri-devel@lists.freedesktop.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, David Herrmann <dh.herrmann@gmail.com>
List-Id: dri-devel@lists.freedesktop.org

At Mon, 5 May 2014 16:52:45 +0200,
Daniel Vetter wrote:
> 
> On Mon, May 5, 2014 at 4:48 PM, Takashi Iwai <tiwai@suse.de> wrote:
> >
> > The current problem I see is that the rest of panic notifier chain
> > won't be called once when we hit the problem in KMS notifier.  So,
> > this bug in KMS influences on the rest panic behavior.
> >
> > Maybe a hackish solution would be to keep KMS notifier at the end of
> > notifier chain so that it crashes at last.  I don't like this either,
> > but...
> 
> You need to do that with both the kms panic notifier in
> drm_fb_helper.c and with the fbcon panic notifier. And iirc there's
> also a console->unblank call somewhere which _also_ can end up in
> ->set_par. But I'm not sure anymore when exactly that one is run, I've
> tried hard to forget this all ;-)

Oh well, you're suggesting the need for Propranolol overdose ;)


Takashi