From: Takashi Iwai <tiwai@suse.de>
To: "Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
Cc: alsa-devel@alsa-project.org, patches.audio@intel.com,
lgirdwood@gmail.com, dri-devel@lists.freedesktop.org,
broonie@kernel.org, Daniel Vetter <daniel.vetter@intel.com>,
Vinod Koul <vinod.koul@intel.com>
Subject: Re: [PATCH v2 05/14] ALSA: pcm: Add DRM helper to set constraint for format
Date: Fri, 04 Dec 2015 06:59:19 +0100 [thread overview]
Message-ID: <s5hlh9a4uvc.wl-tiwai@suse.de> (raw)
In-Reply-To: <20151204110818.GA7669@subhransu-desktop>
On Fri, 04 Dec 2015 12:08:26 +0100,
Subhransu S. Prusty wrote:
>
> On Thu, Dec 03, 2015 at 04:57:14PM +0100, Takashi Iwai wrote:
> > On Thu, 03 Dec 2015 22:08:53 +0100,
> > Subhransu S. Prusty wrote:
> > >
> > > Setting the constraint format based on ELD was missing bit in
> > > the sound/core pcm drm. Added with this patch.
> >
> > No, you can't define these here. The format really depends on the
> > hardware, while the rate and the channels are independent.
>
> Probably then I will move this definition to driver.
>
> > How do you know it's little-endian? And why it must be S24_LE for
> > 24bit, not S32_LE?
>
> Regarding the little-endian, In the driver I think I should set the
> constraint for both LE and BE. And the platform as it only supports LE alone
> it will set the constraint accordingly and edianness will be taken care of.
>
> Regarding the sample size, from short audio descriptor, the samples can be
> one of 16/20/24 bit. I could use the format bits for 16 and 24 bits but
> don't know which format bits macro is suitable for 20bits. So kept it as
> S32_LE for 20bits. Should I fix the format bits for 20bits to use S24?
No you seem misunderstanding the concept...
Takashi
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-12-04 5:59 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 21:02 [PATCH v2 00/14] ASoC: hdac_hdmi: Add DP & notification support Subhransu S. Prusty
2015-12-03 21:08 ` [PATCH v2 01/14] ASoC: hdac_hdmi: Fix to check num nodes correctly Subhransu S. Prusty
2015-12-03 21:08 ` [PATCH v2 02/14] ASoC: hdac_hdmi: Fix to warn instead of err for no connected nids Subhransu S. Prusty
2015-12-03 21:08 ` [PATCH v2 03/14] ASoC: hdac_hdmi - Use list to add pins and converters Subhransu S. Prusty
2015-12-03 15:44 ` Takashi Iwai
2015-12-04 10:16 ` Subhransu S. Prusty
2015-12-03 21:08 ` [PATCH v2 04/14] ASoC: hdac_hdmi: Add hotplug notification and read eld Subhransu S. Prusty
2015-12-03 15:51 ` Takashi Iwai
2015-12-04 10:16 ` Subhransu S. Prusty
2015-12-03 21:08 ` [PATCH v2 05/14] ALSA: pcm: Add DRM helper to set constraint for format Subhransu S. Prusty
2015-12-03 15:57 ` Takashi Iwai
2015-12-04 11:08 ` Subhransu S. Prusty
2015-12-04 5:59 ` Takashi Iwai [this message]
2015-12-05 11:27 ` Subhransu S. Prusty
2015-12-05 8:12 ` Takashi Iwai
2015-12-05 14:05 ` Subhransu S. Prusty
2015-12-05 9:05 ` Takashi Iwai
2015-12-03 21:08 ` [PATCH v2 06/14] ASoC: hdac_hdmi: Apply constraints based on ELD Subhransu S. Prusty
2015-12-03 21:08 ` [PATCH v2 07/14] ASoC: hdac_hdmi: Enable DP1.2 and all converters/pins Subhransu S. Prusty
2015-12-03 21:08 ` [PATCH v2 08/14] ASoC: hdac_hdmi - create dais based on number of streams Subhransu S. Prusty
2015-12-03 16:13 ` Takashi Iwai
2015-12-03 21:08 ` [PATCH v2 09/14] ASoC: hdac_hdmi: Create widget/route based on nodes enumerated Subhransu S. Prusty
2015-12-03 21:08 ` [PATCH v2 10/14] ASoC: hdac_hdmi: Assign pin for stream based on dapm connection Subhransu S. Prusty
2015-12-03 21:08 ` [PATCH v2 11/14] drm/edid: Add API to help find connection type Subhransu S. Prusty
2015-12-03 16:16 ` Takashi Iwai
2015-12-04 10:30 ` Subhransu S. Prusty
2015-12-03 21:09 ` [PATCH v2 12/14] ASoC: hdac_hdmi: Add infoframe support for dp audio Subhransu S. Prusty
2015-12-03 17:13 ` Daniel Stone
2015-12-04 10:32 ` Subhransu S. Prusty
2015-12-03 21:09 ` [PATCH v2 13/14] ASoC: hdac_hdmi: Add codec suspend/resume handler Subhransu S. Prusty
2015-12-03 21:09 ` [PATCH v2 14/14] ASoC: hdac_hdmi: Fix to keep display active while enumerating codec Subhransu S. Prusty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hlh9a4uvc.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=lgirdwood@gmail.com \
--cc=patches.audio@intel.com \
--cc=subhransu.s.prusty@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox