From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] drm/fb-helper: Don't call dirty callback for untouched clips Date: Fri, 21 Oct 2016 14:48:49 +0200 Message-ID: References: <20161020143952.2538-1-tiwai@suse.de> <20161020145604.GW4329@intel.com> <20161021123032.GZ20761@phenom.ffwll.local> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id ED2846ECFC for ; Fri, 21 Oct 2016 12:49:00 +0000 (UTC) In-Reply-To: <20161021123032.GZ20761@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCAyMSBPY3QgMjAxNiAxNDozMDozMiArMDIwMCwKRGFuaWVsIFZldHRlciB3cm90ZToK PiAKPiBPbiBUaHUsIE9jdCAyMCwgMjAxNiBhdCAwNTowMDozNVBNICswMjAwLCBUYWthc2hpIEl3 YWkgd3JvdGU6Cj4gPiBPbiBUaHUsIDIwIE9jdCAyMDE2IDE2OjU2OjA0ICswMjAwLAo+ID4gVmls bGUgU3lyasOkbMOkIHdyb3RlOgo+ID4gPiAKPiA+ID4gT24gVGh1LCBPY3QgMjAsIDIwMTYgYXQg MDQ6Mzk6NTJQTSArMDIwMCwgVGFrYXNoaSBJd2FpIHdyb3RlOgo+ID4gPiA+IFNpbmNlIDQuNyBr ZXJuZWwsIHdlJ3ZlIHNlZW4gdGhlIGVycm9yIG1lc3NhZ2VzIGxpa2UKPiA+ID4gPiAKPiA+ID4g PiAga2VybmVsOiBbVFRNXSBCdWZmZXIgZXZpY3Rpb24gZmFpbGVkCj4gPiA+ID4gIGtlcm5lbDog cXhsIDAwMDA6MDA6MDIuMDogb2JqZWN0X2luaXQgZmFpbGVkIGZvciAoNDAyNjU0MDAzMiwgMHgw MDAwMDAwMSkKPiA+ID4gPiAga2VybmVsOiBbZHJtOnF4bF9hbGxvY19ib19yZXNlcnZlZCBbcXhs XV0gKkVSUk9SKiBmYWlsZWQgdG8gYWxsb2NhdGUgVlJBTSBCTwo+ID4gPiA+IAo+ID4gPiA+IG9u IFFYTCB3aGVuIHN3aXRjaGluZyBhbmQgYWNjZXNzaW5nIG9uIFZULiAgVGhlIGN1bHByaXQgd2Fz IHRoZQo+ID4gPiA+IGdlbmVyaWMgZGVmZXJyZWRfaW8gY29kZSAocXhsIGRyaXZlciBzd2l0Y2hl ZCB0byBpdCBzaW5jZSA0LjcpLgo+ID4gPiA+IFRoZXJlIGlzIGEgcmFjZSBiZXR3ZWVuIHRoZSBk aXJ0eSBjbGlwIHVwZGF0ZSBhbmQgdGhlIGNhbGwgb2YKPiA+ID4gPiBjYWxsYmFjay4KPiA+ID4g PiAKPiA+ID4gPiBJbiBkcm1fZmJfaGVscGVyX2RpcnR5KCksIHRoZSBkaXJ0eSBjbGlwIGlzIHVw ZGF0ZWQgaW4gdGhlIHNwaW5sb2NrLAo+ID4gPiA+IHdoaWxlIGl0IGtpY2tzIG9mZiB0aGUgdXBk YXRlIHdvcmtlciBvdXRzaWRlIHRoZSBzcGlubG9jay4gIE1lYW53aGlsZQo+ID4gPiA+IHRoZSB1 cGRhdGUgd29ya2VyIGNsZWFycyB0aGUgZGlydHkgY2xpcCBpbiB0aGUgc3BpbmxvY2ssIHRvby4g IFRodXMsCj4gPiA+ID4gd2hlbiBkcm1fZmJfaGVscGVyX2RpcnR5KCkgaXMgY2FsbGVkIGNvbmN1 cnJlbnRseSwgc2NoZWR1bGVfd29yaygpIGlzCj4gPiA+ID4gY2FsbGVkIGFmdGVyIHRoZSBjbGlw IGlzIGNsZWFyZWQgaW4gdGhlIGZpcnN0IHdvcmtlciBjYWxsLgo+ID4gPiA+IAo+ID4gPiA+IFRo aXMgcGF0Y2ggYWRkcmVzc2VzIGl0IGJ5IHZhbGlkYXRpbmcgdGhlIGNsaXAgYmVmb3JlIGNhbGxp bmcgdGhlCj4gPiA+ID4gZGlydHkgZmIgY2FsbGJhY2suCj4gPiA+ID4gCj4gPiA+ID4gQnVnemls bGE6IGh0dHBzOi8vYnVncy5mcmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTk4MzIyCj4g PiA+ID4gQnVnemlsbGE6IGh0dHBzOi8vYnVnemlsbGEuc3VzZS5jb20vc2hvd19idWcuY2dpP2lk PTEwMDMyOTgKPiA+ID4gPiBGaXhlczogZWFhNDM0ZGVmYWNhICgnZHJtL2ZiLWhlbHBlcjogQWRk IGZiX2RlZmVycmVkX2lvIHN1cHBvcnQnKQo+ID4gPiA+IENjOiA8c3RhYmxlQHZnZXIua2VybmVs Lm9yZz4KPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBUYWthc2hpIEl3YWkgPHRpd2FpQHN1c2UuZGU+ Cj4gPiA+ID4gLS0tCj4gPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMgfCAx MyArKysrKysrKystLS0tCj4gPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCA5IGluc2VydGlvbnMoKyks IDQgZGVsZXRpb25zKC0pCj4gPiA+ID4gCj4gPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9kcm1fZmJfaGVscGVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jCj4g PiA+ID4gaW5kZXggMDM0MTRiZGUxZjE1Li5kNzkwZDIwNTEyOWUgMTAwNjQ0Cj4gPiA+ID4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYwo+ID4gPiA+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9kcm1fZmJfaGVscGVyLmMKPiA+ID4gPiBAQCAtNjM2LDE1ICs2MzYsMjAgQEAgc3Rh dGljIHZvaWQgZHJtX2ZiX2hlbHBlcl9kaXJ0eV93b3JrKHN0cnVjdCB3b3JrX3N0cnVjdCAqd29y aykKPiA+ID4gPiAgCQkJCQkJICAgIGRpcnR5X3dvcmspOwo+ID4gPiA+ICAJc3RydWN0IGRybV9j bGlwX3JlY3QgKmNsaXAgPSAmaGVscGVyLT5kaXJ0eV9jbGlwOwo+ID4gPiA+ICAJc3RydWN0IGRy bV9jbGlwX3JlY3QgY2xpcF9jb3B5Owo+ID4gPiA+ICsJYm9vbCBkaXJ0eTsKPiA+ID4gPiAgCXVu c2lnbmVkIGxvbmcgZmxhZ3M7Cj4gPiA+ID4gIAo+ID4gPiA+ICAJc3Bpbl9sb2NrX2lycXNhdmUo JmhlbHBlci0+ZGlydHlfbG9jaywgZmxhZ3MpOwo+ID4gPiA+IC0JY2xpcF9jb3B5ID0gKmNsaXA7 Cj4gPiA+ID4gLQljbGlwLT54MSA9IGNsaXAtPnkxID0gfjA7Cj4gPiA+ID4gLQljbGlwLT54MiA9 IGNsaXAtPnkyID0gMDsKPiA+ID4gPiArCWRpcnR5ID0gKGNsaXAtPngxIDwgY2xpcC0+eDIgJiYg Y2xpcC0+eTEgPCBjbGlwLT55Mik7Cj4gPiA+ID4gKwlpZiAoZGlydHkpIHsKPiA+ID4gPiArCQlj bGlwX2NvcHkgPSAqY2xpcDsKPiA+ID4gPiArCQljbGlwLT54MSA9IGNsaXAtPnkxID0gfjA7Cj4g PiA+ID4gKwkJY2xpcC0+eDIgPSBjbGlwLT55MiA9IDA7Cj4gPiA+ID4gKwl9Cj4gPiA+ID4gIAlz cGluX3VubG9ja19pcnFyZXN0b3JlKCZoZWxwZXItPmRpcnR5X2xvY2ssIGZsYWdzKTsKPiA+ID4g PiAgCj4gPiA+ID4gLQloZWxwZXItPmZiLT5mdW5jcy0+ZGlydHkoaGVscGVyLT5mYiwgTlVMTCwg MCwgMCwgJmNsaXBfY29weSwgMSk7Cj4gPiA+ID4gKwlpZiAoZGlydHkpCj4gPiA+IAo+ID4gPiBD b3VsZCBkbyBpdCB0aGUgb3RoZXIgd2F5IHRvbywgaWUuIGp1c3QgbWFrZSB0aGUgY29weSwgYW5k IHRoZW4gY2hlY2sgdGhlCj4gPiA+IGNvcHkgKGNhbiBiZSBkb25lIGFmdGVyIGRyb3BwaW5nIHRo ZSBsb2NrIGV2ZW4pLiBXb3VsZCBhdm9pZCBoYXZpbmcgdG8KPiA+ID4gYWRkIHRoZSAnZGlydHkn IHZhcmlhYmxlLgo+ID4gCj4gPiBTb3VuZHMgZ29vZC4gIExldCBtZSB0cnkuLi4KPiAKPiBBbm90 aGVyIHRoaW5nOiBIb3cgZG8gd2UgcHJldmVudCB1c2Vyc3BhY2UgZnJvbSBkb2luZyB0aGUgc2Ft ZSwgaS5lLgo+IHN1Ym1pdHRpbmcgYW4gZW1wdHkgcmVjdGFuZ2xlPyBEbyB3ZSBuZWVkIHRvIHBh dGNoIHVwCj4gZHJtX21vZGVfZGlydHlmYl9pb2N0bCB0b28/IE5vdCBtdWNoIHBvaW50IGlmIHdl IGZpeCB0aGlzIGJ1ZyBpbiB0aGUgZmIKPiBoZWxwZXJzIGFuZCBsZWF2ZSB0aGUgYmFybiBkb29y IHdpZGUgb3BlbiBmb3IgdXNlcnNwYWNlIHRvIG9vcHMgZHJpdmVycwo+IDstKQoKT0ssIHRoZW4g aG93IGFib3V0IGFkZGluZyBhIGhlbHBlciB0byBjYWxsIHRoZSBkaXJ0eSBjYWxsYmFjayB3aXRo IGEKc2FuaXR5IGNoZWNrIGxpa2UgYmVsb3c/CgoKVGFrYXNoaQoKLS0tCmRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9mYl9o ZWxwZXIuYwppbmRleCAwMzQxNGJkZTFmMTUuLjdiZWY0ZDY0MjUxMSAxMDA2NDQKLS0tIGEvZHJp dmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYworKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2Zi X2hlbHBlci5jCkBAIC02NDQsNyArNjQ0LDcgQEAgc3RhdGljIHZvaWQgZHJtX2ZiX2hlbHBlcl9k aXJ0eV93b3JrKHN0cnVjdCB3b3JrX3N0cnVjdCAqd29yaykKIAljbGlwLT54MiA9IGNsaXAtPnky ID0gMDsKIAlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZoZWxwZXItPmRpcnR5X2xvY2ssIGZsYWdz KTsKIAotCWhlbHBlci0+ZmItPmZ1bmNzLT5kaXJ0eShoZWxwZXItPmZiLCBOVUxMLCAwLCAwLCAm Y2xpcF9jb3B5LCAxKTsKKwlkcm1fZnJhbWVidWZmZXJfdXBkYXRlX2RpcnR5KGhlbHBlci0+ZmIs IE5VTEwsIDAsIDAsICZjbGlwX2NvcHksIDEpOwogfQogCiAvKioKZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9kcm1fZnJhbWVidWZmZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZnJhbWVi dWZmZXIuYwppbmRleCAzOThlZmQ2N2NiOTMuLjA4MTdhMGI2MDdjNSAxMDA2NDQKLS0tIGEvZHJp dmVycy9ncHUvZHJtL2RybV9mcmFtZWJ1ZmZlci5jCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1f ZnJhbWVidWZmZXIuYwpAQCAtNTI5LDYgKzUyOSwyNSBAQCBpbnQgZHJtX21vZGVfZ2V0ZmIoc3Ry dWN0IGRybV9kZXZpY2UgKmRldiwKIH0KIAogLyoqCisgKiBibGFoIGJsYWgKKyAqLworaW50IGRy bV9mcmFtZWJ1ZmZlcl91cGRhdGVfZGlydHkoc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIsCisJ CQkJIHN0cnVjdCBkcm1fZmlsZSAqZmlsZV9wcml2LAorCQkJCSB1bnNpZ25lZCBmbGFncywgdW5z aWduZWQgY29sb3IsCisJCQkJIHN0cnVjdCBkcm1fY2xpcF9yZWN0ICpjbGlwcywKKwkJCQkgdW5z aWduZWQgbnVtX2NsaXBzKQoreworCWlmICghZmItPmZ1bmNzLT5kaXJ0eSkKKwkJcmV0dXJuIC1F Tk9TWVM7CisJaWYgKCFudW1fY2xpcHMpCisJCXJldHVybiAwOworCWlmIChjbGlwcy0+eDEgPj0g Y2xpcHMtPngyIHx8IGNsaXBzLT55MSA+PSBjbGlwcy0+eTIpCisJCXJldHVybiAwOworCXJldHVy biBmYi0+ZnVuY3MtPmRpcnR5KGZiLCBmaWxlX3ByaXYsIGZsYWdzLCBjb2xvciwgY2xpcHMsIG51 bV9jbGlwcyk7Cit9CitFWFBPUlRfU1lNQk9MKGRybV9mcmFtZWJ1ZmZlcl91cGRhdGVfZGlydHkp OworCisvKioKICAqIGRybV9tb2RlX2RpcnR5ZmJfaW9jdGwgLSBmbHVzaCBmcm9udGJ1ZmZlciBy ZW5kZXJpbmcgb24gYW4gRkIKICAqIEBkZXY6IGRybSBkZXZpY2UgZm9yIHRoZSBpb2N0bAogICog QGRhdGE6IGRhdGEgcG9pbnRlciBmb3IgdGhlIGlvY3RsCkBAIC02MDAsMTIgKzYxOSw4IEBAIGlu dCBkcm1fbW9kZV9kaXJ0eWZiX2lvY3RsKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCiAJCX0KIAl9 CiAKLQlpZiAoZmItPmZ1bmNzLT5kaXJ0eSkgewotCQlyZXQgPSBmYi0+ZnVuY3MtPmRpcnR5KGZi LCBmaWxlX3ByaXYsIGZsYWdzLCByLT5jb2xvciwKLQkJCQkgICAgICAgY2xpcHMsIG51bV9jbGlw cyk7Ci0JfSBlbHNlIHsKLQkJcmV0ID0gLUVOT1NZUzsKLQl9CisJcmV0ID0gZHJtX2ZyYW1lYnVm ZmVyX3VwZGF0ZV9kaXJ0eShmYiwgZmlsZV9wcml2LCBmbGFncywgci0+Y29sb3IsCisJCQkJCSAg IGNsaXBzLCBudW1fY2xpcHMpOwogCiBvdXRfZXJyMjoKIAlrZnJlZShjbGlwcyk7CmRpZmYgLS1n aXQgYS9pbmNsdWRlL2RybS9kcm1fZnJhbWVidWZmZXIuaCBiL2luY2x1ZGUvZHJtL2RybV9mcmFt ZWJ1ZmZlci5oCmluZGV4IGY1YWUxZjQzNmE0Yi4uZmVhYmQ5MTM5ZmRiIDEwMDY0NAotLS0gYS9p bmNsdWRlL2RybS9kcm1fZnJhbWVidWZmZXIuaAorKysgYi9pbmNsdWRlL2RybS9kcm1fZnJhbWVi dWZmZXIuaApAQCAtMjE3LDYgKzIxNywxMiBAQCB2b2lkIGRybV9mcmFtZWJ1ZmZlcl9yZW1vdmUo c3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIpOwogdm9pZCBkcm1fZnJhbWVidWZmZXJfY2xlYW51 cChzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYik7CiB2b2lkIGRybV9mcmFtZWJ1ZmZlcl91bnJl Z2lzdGVyX3ByaXZhdGUoc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIpOwogCitpbnQgZHJtX2Zy YW1lYnVmZmVyX3VwZGF0ZV9kaXJ0eShzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiwKKwkJCQkg c3RydWN0IGRybV9maWxlICpmaWxlX3ByaXYsCisJCQkJIHVuc2lnbmVkIGZsYWdzLCB1bnNpZ25l ZCBjb2xvciwKKwkJCQkgc3RydWN0IGRybV9jbGlwX3JlY3QgKmNsaXBzLAorCQkJCSB1bnNpZ25l ZCBudW1fY2xpcHMpOworCiAvKioKICAqIGRybV9mcmFtZWJ1ZmZlcl9yZWZlcmVuY2UgLSBpbmNy IHRoZSBmYiByZWZjbnQKICAqIEBmYjogZnJhbWVidWZmZXIKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==