Re: [PATCH v2 1/4] dt-bindings: misc: qcom,fastrpc: add iommu-ranges support for context bank

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: namespace violation and missing type for iommu-ranges
--

commit dcdf3e61cd19c2e633ae438160d6dad2d5a26363
Author: Vinayak Katoch <vinayak.katoch@oss.qualcomm.com>

dt-bindings: misc: qcom,fastrpc: add iommu-ranges support for context bank

This commit adds support for the iommu-ranges property to the compute-cb
subnode in the qcom,fastrpc device tree binding. It allows the context bank
nodes to specify IOVA ranges for the IOMMU allocator, and relaxes the
address and size cells properties to accommodate 64-bit values.

> diff --git a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
> index e945c8ba75e30..f4ca9a7672556 100644
> --- a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
> +++ b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
[ ... ]
> @@ -98,6 +98,8 @@ patternProperties:
>          minItems: 1
>          maxItems: 10
>  
> +      iommu-ranges: true
> +

[Severity: Low]
Does this property need a vendor prefix since it appears to be specific to
this driver rather than a standard device tree property? Device tree namespace
conventions generally expect a vendor prefix for non-standard properties, such
as qcom,iommu-ranges.

Additionally, should this property include a structural or type constraint?
Defining it simply as true without a type reference, such as
$ref: /schemas/types.yaml#/definitions/uint32-matrix, seems to bypass schema
validation. This could potentially allow malformed data to silently pass
the dt_binding_check validation.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261007-extended-mapping-v2-0-5dca3aa2c2d3@oss.qualcomm.com?part=1