From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4D25CA601F for ; Fri, 9 Oct 2026 18:35:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1E98610EADF; Fri, 9 Oct 2026 18:35:00 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="oCw/4jI6"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 74EEB10EADF for ; Fri, 9 Oct 2026 18:34:58 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id B15336020C; Fri, 9 Oct 2026 18:34:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 832AD1F000FF; Fri, 9 Oct 2026 18:34:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791570897; bh=ukJJhCUpy6ZAQIKANWi251pWONvGRx1MC9S4NHPidcE=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=oCw/4jI6s8YnDpOPKOjVp6M3uJgVEhX0t2pFHdZ3rrpz7UU5Sh/9Jz2AAYGebMARe bQVhZFEMjLE/97M5fy2rq6DB1sYmVVi6nLyWPol9AWmgQ3aiubLnrUNEKgWkGwwHsc 3QuYxl7hc8BqzVJeIT2dEduchgqTYfNPniwNOE75u7OlOCUqzZ5oFsZRx0KwG/kNo5 pZtglswmdx61scyVRUZssfRoq6L9WfK5i9oCwHHTWi7ws0cvMcnxnWycVwWxIHQxY2 GcOkmoSykFgpDfaRpyVhft+YBjZkHwpNijSIIfKxo2J4YTE42taXp7PI7p1OO+3Tqy M4ceDd5shQFPg== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v5 20/38] mm/gup: error out early on !VMA_MAYREAD_BIT VMAs To: =?utf-8?b?TG9yZW56byBTdG9ha2VzIChBUk0p?= Cc: linux-scsi@vger.kernel.org, "Vasily Gorbik" , "Alexander Gordeev" , kvm@vger.kernel.org, "Christian Borntraeger" , "Heiko Carstens" , bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, selinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-s390@vger.kernel.org, "Marc Zyngier" , kvmarm@lists.linux.dev, linux-trace-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, "Oliver Upton" , dri-devel@lists.freedesktop.org In-Reply-To: <20261009-b4-mmap-prepare-vma-flag-sanify-v5-20-923b70125b1e@kernel.org> References: <20261009-b4-mmap-prepare-vma-flag-sanify-v5-0-923b70125b1e@kernel.org> <20261009-b4-mmap-prepare-vma-flag-sanify-v5-20-923b70125b1e@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 09 Oct 2026 18:34:56 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > When populating a VMA range via the aptly named populate_vma_page_range() > an unreadable VMA will always eventually fail with -EFAULT. >=20 > That a VMA is accessible is always checked, however VMA_MAYREAD_BIT is no= t. >=20 > All user mappings always have VMA_MAYREAD_BIT set, so this check only > impacts kernel mappings. >=20 > It is implemented specifically to disallow population of uprobes XOL > mappings which are exec-only. >=20 > A nasty interaction with these mappings may occur if they are mlocked, so > actively disallow this early. >=20 > This allows a subsequent commit to remove the VM_IO check in > __mm_populate() which otherwise requires non-MMIO mappings to be wrongly > flagged simply as a workaround. >=20 > Acked-by: Zi Yan > Reviewed-by: Suren Baghdasaryan > Signed-off-by: Lorenzo Stoakes (ARM) Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261009-b4-mmap-pr= epare-vma-flag-sanify-v5-0-923b70125b1e@kernel.org?part=3D20