From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6DCD0CA601F for ; Fri, 9 Oct 2026 18:44:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C0FCB10EB08; Fri, 9 Oct 2026 18:44:03 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="lr94gk4Q"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id EB62210EB0A for ; Fri, 9 Oct 2026 18:44:02 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id D428C403D2; Fri, 9 Oct 2026 18:44:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 032881F000FF; Fri, 9 Oct 2026 18:44:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791571442; bh=tMkCnvhuZKPJ18phjKy3R2NY9oh2hTQcU5jUe9DRdTI=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=lr94gk4QvV6SugCkaAxyZvaLpzRhuXfwtbMfdvIKhnew2haMD/9zIv98qkoEp0kiu RyJbDs7iNmUoGBzakZ2L9THUUGsE/D2R+iLN0f5GWAVPqwpwkCsW6CE67PGfMD0Rld +2juPpBtHE+m1tjGGwS/xP9TUl8Hjhdjwfe5hgR4+4+Hq0+HBC7oItxhbTalc0pvZd AMlSl7emNsN9fxuaF5DBN4paVgVW5oN9r3YAqXMCFeofLR6g1HErIQzCx5cR0+tJnN k2ChFFV3wYO6fjc8v0leW43/c2OlPQyqM3z7MJaNyz94pceI6KuvGCeC9B30p9ISPM q2IrbFY3eJKpA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v5 29/38] mm/madvise: update is_valid_guard_vma() to use vma_can_merge() To: =?utf-8?b?TG9yZW56byBTdG9ha2VzIChBUk0p?= Cc: bpf@vger.kernel.org, selinux@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-trace-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, "Alexander Gordeev" , linux-usb@vger.kernel.org, "Christian Borntraeger" , "Oliver Upton" , kvm@vger.kernel.org, "Heiko Carstens" , linux-rdma@vger.kernel.org, linux-perf-users@vger.kernel.org, "Marc Zyngier" , linux-s390@vger.kernel.org, "Vasily Gorbik" , kvmarm@lists.linux.dev In-Reply-To: <20261009-b4-mmap-prepare-vma-flag-sanify-v5-29-923b70125b1e@kernel.org> References: <20261009-b4-mmap-prepare-vma-flag-sanify-v5-0-923b70125b1e@kernel.org> <20261009-b4-mmap-prepare-vma-flag-sanify-v5-29-923b70125b1e@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 09 Oct 2026 18:44:00 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > We currently disallow the installation of lightweight guard regions in VM= As > whose flags intersect VMA_SPECIAL_FLAGS or VMA_HUGETLB_BIT, or > VMA_LOCKED_BIT unless allow_locked is set. >=20 > hugetlb VMAs set VMA_DONTEXPAND_BIT so this was already redundant, > VMA_SPECIAL_FLAGS already sufficed. >=20 > However, now that VMA_IO_BIT is only set if VMA_PFNMAP or VMA_MIXEDMAP_BIT > is set, this check collapses to being the equivalent of > !vma_can_merge(). >=20 > Update is_valid_guard_vma() to reflect this. >=20 > No functional change intended. >=20 > Acked-by: Zi Yan > Acked-by: David Hildenbrand (Arm) > Signed-off-by: Lorenzo Stoakes (ARM) Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261009-b4-mmap-pr= epare-vma-flag-sanify-v5-0-923b70125b1e@kernel.org?part=3D29