From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE7F5CA9EBD for ; Fri, 9 Oct 2026 18:48:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5735310EB19; Fri, 9 Oct 2026 18:48:47 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="anh0FGAR"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2814E10EB19 for ; Fri, 9 Oct 2026 18:48:45 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 4AEFA6020C; Fri, 9 Oct 2026 18:48:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E3F651F000FF; Fri, 9 Oct 2026 18:48:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791571724; bh=LfJvDFNDixbvgbvbALUIlQV9E4F1Hb5P1YLX6fvGO0s=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=anh0FGARTlPPdhEZbG3n5RQyiaWGuHqWeBzYEy/H+4vUgnW9ONrhyi/6wZZA9YFeS MVhve4DEjLR0/rrwXHE2e+Fk/I+6+iONkfWXuPu4vumrKrWS7r5hGMwlXwrfeJgrfu oilBKNhPwmOBgAjV9JfOhcXg7cBqmOXMcF0sIMyX9plpnI4bMYj2thGBPKg2cmil+u bmhGQqFXJ3lYeDJKXrIlFbuWSCQlTTSjEMyNBslOGBH570Pa8CsfE/2Xd5Kfgd+dfj 5yZjsLt7BknuXoh/uv1vT1jhS2rTCI7dFQYObs6rePNde+G0pS4ZOIqlod/SCEwJOv ZtA+USt3t5qQg== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v5 36/38] mm: eliminate VM_SPECIAL, VMA_SPECIAL_FLAGS To: =?utf-8?b?TG9yZW56byBTdG9ha2VzIChBUk0p?= Cc: dri-devel@lists.freedesktop.org, linux-usb@vger.kernel.org, kvmarm@lists.linux.dev, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, "Christian Borntraeger" , selinux@vger.kernel.org, "Alexander Gordeev" , "Heiko Carstens" , "Marc Zyngier" , bpf@vger.kernel.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-trace-kernel@vger.kernel.org, "Oliver Upton" , "Vasily Gorbik" In-Reply-To: <20261009-b4-mmap-prepare-vma-flag-sanify-v5-36-923b70125b1e@kernel.org> References: <20261009-b4-mmap-prepare-vma-flag-sanify-v5-0-923b70125b1e@kernel.org> <20261009-b4-mmap-prepare-vma-flag-sanify-v5-36-923b70125b1e@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 09 Oct 2026 18:48:42 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > Every user of the VM_SPECIAL or VMA_SPECIAL_FLAGS has now been converted = to > predicates which explicitly express what is actually being checked for > rather than the nebulous concept of possessing 'special' VMA flags. >=20 > In any case 'special' is not so special a term of art in mm - it includes > VDSO/VVAR mappings, special in the sense of vm_normal_folio() and probably > other cases too. >=20 > Therefore make things less special by eliminating these now unused flags. >=20 > No functional change intended. >=20 > Acked-by: Zi Yan > Acked-by: David Hildenbrand (Arm) > Signed-off-by: Lorenzo Stoakes (ARM) Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261009-b4-mmap-pr= epare-vma-flag-sanify-v5-0-923b70125b1e@kernel.org?part=3D36