From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B52F0CA9EC5 for ; Mon, 12 Oct 2026 13:20:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 044CB10F0FC; Mon, 12 Oct 2026 13:20:33 +0000 (UTC) Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 452FD10F0F9 for ; Mon, 12 Oct 2026 13:20:26 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id BCC1A602D1; Mon, 12 Oct 2026 13:20:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2784F1F0089C; Mon, 12 Oct 2026 13:20:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791811225; bh=1QhUi/Eypm06QxXsczGu0b+m/a1gDlMPO8/nG1uCXO8=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=WRBf3RZXF3UUIRGWD5ZZGYnOJ16O8SPKkN5SZ2Pp9bHWzEiN9NEmyju/NR+qd6au5 4y2P8x/QoPixFH2UepqPoyC2iEsTMZ2Clw1OmfQgV7eLtTEhYbZ4lkRd1nsk4kj8lv fDL9UTqnwUco/Fy4oaRYamNDSRpKSYUHQKemC5xD8UJhiYnEaui98xqN6cQBaLzHPI VA7lzsjsYRgiEoGC194RkysBtYWponEBAr8+sVcvEHSOED6sYydAUZJs7keRJGJvQo lJJac5ct7dA0lUkXpeW+BS2GRJ1PqW79DvoAiqp7V5+LwPoUEz9zMaX5b//PDQaapE uIqU8EqvXTk6Q== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v10 03/18] PCI: Reject unreadable ACS controls in isolation checks To: "Leon Romanovsky" Cc: dri-devel@lists.freedesktop.org, kvm@vger.kernel.org, linux-pci@vger.kernel.org, media-ci@linuxtv.org, linux-rdma@vger.kernel.org In-Reply-To: <20261012-fix-p2p-acs-v4-0-v10-3-6ffe7b7a4517@nvidia.com> References: <20261012-fix-p2p-acs-v4-0-v10-0-6ffe7b7a4517@nvidia.com> <20261012-fix-p2p-acs-v4-0-v10-3-6ffe7b7a4517@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 12 Oct 2026 13:20:24 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > From: Leon Romanovsky >=20 > pci_acs_flags_enabled() and the Intel SPT PCH quirk use ACS registers > without checking config-space read errors. A failed read may leave control > state indeterminate yet allow the device to satisfy requested isolation > controls. >=20 > Return false when either ACS capability or control state cannot be read. > An unknown state cannot prove isolation. >=20 > Reviewed-by: Logan Gunthorpe > Tested-by: Tushar Dave > Signed-off-by: Leon Romanovsky Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261012-fix-p2p-ac= s-v4-0-v10-0-6ffe7b7a4517@nvidia.com?part=3D3