From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 75AA3CC6B33 for ; Thu, 15 Oct 2026 14:35:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7DBE110E595; Thu, 15 Oct 2026 14:35:26 +0000 (UTC) Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id CB1DC10E595 for ; Thu, 15 Oct 2026 14:35:20 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 7DD1140C2D; Thu, 15 Oct 2026 14:35:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 114351F000C4; Thu, 15 Oct 2026 14:35:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792074920; bh=jK78+sdXkAYkVIFvDJ166BEtBLJyB5I14yIVxhQVhEg=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=hjzGSMbffRqHGzc6eA+RBY48b7aYLLm0QoBL9rMZhyFGE+9pAexNtGaXvL5tXYVPL sRLSOQoWWj3FMHDOC5SixoXciBTrCfURThF6GsP6zbmU6HQ1fHDhbp5cC1fNeAlBWt tQGeneAGmUcd8KNEwGEvY7S1CxQsfQWxqX1SIQrkQz/oEyrP8dTNS2+MM/GLF9guQo D7JAN2Raw/in5VgGdYKU3Y2cg/47woQu2B3zcFSssdzYmxMmJ4FOdNqi6wXPdgnhv6 Ykvk/XgWnY+xBN4lZoZPHKDTHHv3NRfyI8F7WR93EYoNsfgiJ0zXhpu96IqCKiU/qb s5hx/EU3gXk2g== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [RFC PATCH v2 01/15] misc/arm-cla: Add driver skeleton and documentation To: "Ryan Roberts" Cc: kvmarm@lists.linux.dev, kvm@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, robh@kernel.org, conor+dt@kernel.org, "Oliver Upton" , "Marc Zyngier" In-Reply-To: <20261015142552.4128028-2-ryan.roberts@arm.com> References: <20261015142552.4128028-1-ryan.roberts@arm.com> <20261015142552.4128028-2-ryan.roberts@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 15 Oct 2026 14:35:19 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] macro: multiple evaluation of macro argument _dev -- commit eeea2acb1fe471c02eee65ef8f991f70efeb7b69 Author: Jean-Philippe Brucker misc/arm-cla: Add driver skeleton and documentation This commit introduces the initial driver skeleton and documentation for the Arm Core Local Accelerator (CLA). It adds the required Kconfig, Makefil= e, register definitions, and a common driver header. > diff --git a/drivers/misc/arm-cla/arm-cla.h b/drivers/misc/arm-cla/arm-cl= a.h > new file mode 100644 > index 0000000000000..1e8ffca28bc6e > --- /dev/null > +++ b/drivers/misc/arm-cla/arm-cla.h [ ... ] > +struct cla_dev { > + unsigned int cpu; > + struct device *dev; > +}; > + > +#define cla_dbg(_dev, fmt, ...) \ > + dev_dbg((_dev)->dev, "[%u] " fmt, (_dev)->cpu, ##__VA_ARGS__) > +#define cla_info(_dev, fmt, ...) \ > + dev_info((_dev)->dev, "[%u] " fmt, (_dev)->cpu, ##__VA_ARGS__) > +#define cla_err(_dev, fmt, ...) \ > + dev_err((_dev)->dev, "[%u] " fmt, (_dev)->cpu, ##__VA_ARGS__) [Severity: Low] The _dev macro parameter is evaluated twice here. Could this lead to unintended duplicate execution if a caller passes an expression with side-effects, such as get_device(dev++)? Would it be safer to rewrite these as static inline functions, or use a statement expression with a local variable to evaluate _dev only once? > + > +#endif /* _ARM_CLA_H_ */ --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261015142552.4128= 028-1-ryan.roberts@arm.com?part=3D1