Re: [PATCH v2 52/59] drm/connector: Remove drm_atomic_helper_connector_reset()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] drm/connector: removing drm_atomic_helper_connector_reset() breaks 21 files
--

commit 948666959edea381d867894c27d616519ac047c5
Author: Maxime Ripard <mripard@kernel.org>

drm/connector: Remove drm_atomic_helper_connector_reset()

This commit removes the drm_atomic_helper_connector_reset() helper and its
declaration from the DRM atomic state helper headers and implementation.

> diff --git a/drivers/gpu/drm/drm_atomic_state_helper.c b/drivers/gpu/drm/drm_atomic_state_helper.c
> index 3534925636d54..5efda28bb2b07 100644
> --- a/drivers/gpu/drm/drm_atomic_state_helper.c
> +++ b/drivers/gpu/drm/drm_atomic_state_helper.c
> @@ -435,26 +435,6 @@ __drm_atomic_helper_connector_reset(struct drm_connector *connector,
>  }
>  EXPORT_SYMBOL(__drm_atomic_helper_connector_reset);
>  
> -/**
> - * drm_atomic_helper_connector_reset - default &drm_connector_funcs.reset hook for connectors
> - * @connector: drm connector
> - *
> - * Resets the atomic state for @connector by freeing the state pointer (which
> - * might be NULL, e.g. at driver load time) and allocating a new empty state
> - * object.
> - */
> -void drm_atomic_helper_connector_reset(struct drm_connector *connector)
> -{
> -	struct drm_connector_state *conn_state = kzalloc_obj(*conn_state);
> -
> -	if (connector->state)
> -		__drm_atomic_helper_connector_destroy_state(connector->state);
> -
> -	kfree(connector->state);
> -	__drm_atomic_helper_connector_reset(connector, conn_state);
> -}
> -EXPORT_SYMBOL(drm_atomic_helper_connector_reset);
> -

[Severity: Medium]
Does removing drm_atomic_helper_connector_reset() here and in
include/drm/drm_atomic_state_helper.h cause build regressions when compiling
drivers and KUnit tests that still reference this symbol?

In drivers/gpu/drm/sysfb/drm_sysfb_helper.h, DRM_SYSFB_CONNECTOR_FUNCS still
uses drm_atomic_helper_connector_reset (affecting corebootdrm.c, efidrm.c,
ofdrm.c, simpledrm.c, and vesadrm.c):

    #define DRM_SYSFB_CONNECTOR_FUNCS \
            .reset = drm_atomic_helper_connector_reset, \

In addition, several other drivers and KUnit test suites still assign
.reset = drm_atomic_helper_connector_reset (or call it directly):

- drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c (komeda_wb_connector_funcs)
- drivers/gpu/drm/bridge/lontium-lt8912b.c (lt8912_connector_funcs)
- drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c (ge_b850v3_lvds_connector_funcs)
- drivers/gpu/drm/bridge/sii902x.c (sii902x_connector_funcs)
- drivers/gpu/drm/bridge/simple-bridge.c (simple_bridge_con_funcs)
- drivers/gpu/drm/hyperv/hyperv_drm_modeset.c (hv_drm_connector_funcs)
- drivers/gpu/drm/imx/ipuv3/imx-tve.c (imx_tve_connector_funcs)
- drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c (dpu_wb_conn_funcs)
- drivers/gpu/drm/solomon/ssd130x.c (ssd130x_connector_funcs)
- drivers/gpu/drm/stm/lvds.c (lvds_conn_funcs)
- drivers/gpu/drm/tiny/appletbdrm.c (appletbdrm_connector_funcs)
- drivers/gpu/drm/vc4/vc4_txp.c (vc4_txp_connector_funcs)
- drivers/gpu/drm/vc4/tests/vc4_mock_output.c (vc4_dummy_connector_funcs)
- drivers/gpu/drm/amd/display/amdgpu_dm/tests/amdgpu_dm_audio_test.c (dm_test_audio_connector_funcs)
- drivers/gpu/drm/amd/display/amdgpu_dm/tests/amdgpu_dm_backlight_test.c (dm_backlight_test_connector_funcs)
- drivers/gpu/drm/amd/display/amdgpu_dm/tests/amdgpu_dm_crc_test.c (dm_test_crc_connector_funcs and a direct call to drm_atomic_helper_connector_reset(wb_conn))
- drivers/gpu/drm/amd/display/amdgpu_dm/tests/amdgpu_dm_helpers_test.c (dm_test_connector_funcs)
- drivers/gpu/drm/amd/display/amdgpu_dm/tests/amdgpu_dm_irq_test.c (dm_test_connector_funcs)
- drivers/gpu/drm/amd/display/amdgpu_dm/tests/amdgpu_dm_mst_types_test.c (dm_mst_test_connector_funcs and dm_mst_test_dsc_link_conn_funcs)
- drivers/gpu/drm/amd/display/amdgpu_dm/tests/amdgpu_dm_wb_test.c (dm_wb_test_connector_funcs)

Should those remaining users be converted to atomic_create_state before
drm_atomic_helper_connector_reset() is removed?

>  /**
>   * drm_atomic_helper_connector_create_state - default &drm_connector_funcs.atomic_create_state hook for connectors
>   * @connector: connector object

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261022-drm-no-more-connector-reset-v2-0-0b7e4e85b1e8@kernel.org?part=52