Re: [PATCH] drm/amdgpu: use drm_gem_ttm_dumb_map_offset() for dumb_map_offset

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] drm/amdgpu: amdgpu_mode_dumb_mmap() left non-static after callback removal
--

commit 20dcb7dcf18d16b07933bf4a8650d805f6e17934
Author: saad <primecoder8@gmail.com>

drm/amdgpu: use drm_gem_ttm_dumb_map_offset() for dumb_map_offset

This commit switches amdgpu_kms_driver and amdgpu_partition_driver from the
custom amdgpu_mode_dumb_mmap() callback to the generic TTM helper
drm_gem_ttm_dumb_map_offset() for .dumb_map_offset.

> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 731fe8f9e9228..134d2fe4beae8 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
[ ... ]
> @@ -3177,7 +3178,7 @@ const struct drm_driver amdgpu_partition_driver = {
>  	.ioctls = amdgpu_ioctls_kms,
>  	.num_ioctls = ARRAY_SIZE(amdgpu_ioctls_kms),
>  	.dumb_create = amdgpu_mode_dumb_create,
> -	.dumb_map_offset = amdgpu_mode_dumb_mmap,
> +	.dumb_map_offset = drm_gem_ttm_dumb_map_offset,

[Severity: Low]
This isn't a bug, but now that neither amdgpu_kms_driver nor
amdgpu_partition_driver in drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c uses
amdgpu_mode_dumb_mmap(), it has no callers outside
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c:

drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c:
int amdgpu_mode_dumb_mmap(struct drm_file *filp,
			  struct drm_device *dev,
			  uint32_t handle, uint64_t *offset_p)
{
...
}

int amdgpu_gem_mmap_ioctl(struct drm_device *dev, void *data,
			  struct drm_file *filp)
{
	union drm_amdgpu_gem_mmap *args = data;
	uint32_t handle = args->in.handle;

	memset(args, 0, sizeof(*args));
	return amdgpu_mode_dumb_mmap(filp, dev, handle, &args->out.addr_ptr);
}

Since amdgpu_gem_mmap_ioctl() is now the sole caller of
amdgpu_mode_dumb_mmap(), and the unused dev parameter and mode_dumb name only
existed for the .dumb_map_offset callback signature, should
amdgpu_mode_dumb_mmap() be folded directly into amdgpu_gem_mmap_ioctl() (or at
least made static) and its prototype removed from
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.h?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261105-amdgpu-dumb-map-offset-v1-1-7299d94ede11@gmail.com?part=1