dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Maxime Ripard" <mripard@kernel.org>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v8 01/39] drm/ingenic: Convert to devm_drm_bridge_alloc()
Date: Fri, 06 Nov 2026 13:33:10 +0000	[thread overview]
Message-ID: <sashiko-outbox-201471@kernel.org> (raw)
In-Reply-To: <20261106-drm-state-readout-v8-1-cbe78624e1bc@kernel.org>

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] drm/ingenic: use-after-free in ingenic_drm_bind() from
  devm/drmm mismatch
- [Low] drm/ingenic: missing devm_drm_bridge_add() in ingenic_drm_bind()
--

commit b0cc78f8ec81445f2abbfeb18a785a51d40b8824
Author: Maxime Ripard <mripard@kernel.org>

drm/ingenic: Convert to devm_drm_bridge_alloc()

This commit converts struct ingenic_drm_bridge allocation in
ingenic_drm_bind() from drmm_encoder_alloc() to devm_drm_bridge_alloc()
paired with drmm_encoder_init().

> diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> index 63198fd594984..8cad8dcfae609 100644
> --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> @@ -1303,20 +1303,27 @@ static int ingenic_drm_bind(struct device *dev, bool has_components)
>  			drm_panel_put(panel);
>  		}
>  
> -		ib = drmm_encoder_alloc(drm, struct ingenic_drm_bridge, encoder,
> -					NULL, DRM_MODE_ENCODER_DPI, NULL);
> +		ib = devm_drm_bridge_alloc(dev, struct ingenic_drm_bridge,
> +					   bridge, &ingenic_drm_bridge_funcs);
>  		if (IS_ERR(ib)) {
>  			ret = PTR_ERR(ib);
> -			dev_err(dev, "Failed to init encoder: %d\n", ret);
> +			dev_err(dev, "Failed to allocate bridge: %d\n", ret);
>  			goto err_drvdata;
>  		}
>  
>  		encoder = &ib->encoder;
> +
> +		ret = drmm_encoder_init(drm, encoder, NULL,
> +					DRM_MODE_ENCODER_DPI, NULL);
> +		if (ret) {
> +			dev_err(dev, "Failed to init encoder: %d\n", ret);
> +			goto err_drvdata;
> +		}

[Severity: High]
Can mixing devm_drm_bridge_alloc() and drmm_encoder_init() on the same
struct ingenic_drm_bridge cause a use-after-free of ib->encoder during
teardown?

ingenic_drm_bind() allocates drm via devm_drm_dev_alloc() before calling
devm_drm_bridge_alloc(), so devres runs drm_bridge_put_void(&ib->bridge)
before devm_drm_dev_init_release() runs drm_managed_release().

On unbind, drm_bridge_put_void() drops the devm reference on ib->bridge,
leaving only the reference taken by drm_bridge_attach().  When
drmm_encoder_alloc_release() then calls drm_encoder_cleanup(&ib->encoder),
detaching ib->bridge drops its last reference and __drm_bridge_free() frees
the entire struct ingenic_drm_bridge container while drm_encoder_cleanup()
is still accessing encoder:

drivers/gpu/drm/drm_encoder.c:drm_encoder_cleanup() {
	...
	list_for_each_entry_safe(bridge, next, &tmplist, chain_node)
		drm_bridge_detach(bridge);

	drm_mode_object_unregister(dev, &encoder->base);
	kfree(encoder->name);
	list_del(&encoder->head);
	dev->mode_config.num_encoder--;
	mutex_destroy(&encoder->bridge_chain_mutex);

	memset(encoder, 0, sizeof(*encoder));
}

If drm_bridge_attach() fails earlier during bind (for example with
-EPROBE_DEFER), drm_bridge_put_void() frees ib before drm_managed_release()
even enters drm_encoder_cleanup().

> +
>  		encoder->possible_crtcs = drm_crtc_mask(&priv->crtc);
>  
>  		drm_encoder_helper_add(encoder, &ingenic_drm_encoder_helper_funcs);
>  
> -		ib->bridge.funcs = &ingenic_drm_bridge_funcs;
>  		ib->next_bridge = bridge;
>  
>  		ret = drm_bridge_attach(encoder, &ib->bridge, NULL,

[Severity: Low]
Does attaching &ib->bridge without calling devm_drm_bridge_add() first
trigger a warning in drm_bridge_attach()?

Previously drmm_encoder_alloc() zero-initialized ib->bridge.list, so
list_empty(&bridge->list) was false.  __devm_drm_bridge_alloc() initializes
bridge->list with INIT_LIST_HEAD(), causing drm_bridge_attach() to hit
DRM_WARN("Missing drm_bridge_add() before attach\n") on every probe.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106-drm-state-readout-v8-0-cbe78624e1bc@kernel.org?part=1

  reply	other threads:[~2026-11-06 13:33 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06 13:14 [PATCH v8 00/39] drm: Implement state readout support Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 01/39] drm/ingenic: Convert to devm_drm_bridge_alloc() Maxime Ripard
2026-11-06 13:33   ` sashiko-bot [this message]
2026-11-06 13:55   ` Luca Ceresoli
2026-11-06 13:59     ` Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 02/39] drm/bridge-helper: Don't unlock the connection mutex after a backoff Maxime Ripard
2026-11-06 13:39   ` sashiko-bot
2026-11-06 13:14 ` [PATCH v8 03/39] drm/tests: hdmi-state-helper: Handle EDEADLK in the 420-only test Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 04/39] drm/tests: hdmi-state-helper: Handle EDEADLK in the color format test Maxime Ripard
2026-11-06 13:32   ` sashiko-bot
2026-11-06 13:14 ` [PATCH v8 05/39] drm/colorop: Export drm_atomic_helper_colorop_create_state() Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 06/39] drm/atomic: Fix private obj error handling Maxime Ripard
2026-11-06 13:29   ` sashiko-bot
2026-11-06 13:14 ` [PATCH v8 07/39] drm/atomic: Add drm_private_obj name Maxime Ripard
2026-11-06 13:35   ` sashiko-bot
2026-11-19 15:20   ` Luca Ceresoli
2026-11-06 13:14 ` [PATCH v8 08/39] drm/bridge: Switch print_state to use bridge name Maxime Ripard
2026-11-19 15:25   ` Luca Ceresoli
2026-11-06 13:14 ` [PATCH v8 09/39] drm/bridge: Add drm_private_obj_is_bridge() Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 10/39] drm/fb-dma-helper: Handle framebuffers without a GEM object Maxime Ripard
2026-11-06 13:32   ` sashiko-bot
2026-11-06 13:14 ` [PATCH v8 11/39] drm/gem-atomic-helper: " Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 12/39] drm/atomic: Export drm_atomic_*_print_state Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 13/39] drm/atomic_sro: Create drm_atomic_sro_state container Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 14/39] drm/atomic_sro: Create kernel parameter to force or disable readout Maxime Ripard
2026-11-06 13:31   ` sashiko-bot
2026-11-06 13:14 ` [PATCH v8 15/39] drm/atomic_sro: Add atomic state readout infrastructure Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 16/39] drm/atomic_sro: Add function to install state into drm objects Maxime Ripard
2026-11-06 13:33   ` sashiko-bot
2026-11-06 13:14 ` [PATCH v8 17/39] drm/atomic_sro: Create documentation Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 18/39] drm/bridge: Handle bridges with hardware state readout Maxime Ripard
2026-11-06 13:33   ` sashiko-bot
2026-11-06 13:14 ` [PATCH v8 19/39] drm/mode-config: Read out hardware state in drm_mode_config_create_state Maxime Ripard
2026-11-06 13:33   ` sashiko-bot
2026-11-06 13:14 ` [PATCH v8 20/39] drm/atomic_sro: Provide helpers to implement hardware state readout Maxime Ripard
2026-11-06 13:44   ` sashiko-bot
2026-11-06 13:14 ` [PATCH v8 21/39] drm/mode-config: Introduce hw_reset hook Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 22/39] drm/modeset-helper: Add drm_mode_config_helper_hw_reset() Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 23/39] drm/atomic_helper: Compare actual and readout states once the commit is done Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 24/39] drm/atomic-state-helper: Provide comparison macros Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 25/39] drm/atomic-state-helper: Provide atomic_compare_state helpers Maxime Ripard
2026-11-06 13:44   ` sashiko-bot
2026-11-06 13:14 ` [PATCH v8 26/39] drm/atomic-helper: Document State Read-Out as a state initialization approach Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 27/39] drm/tests: kunit: Add a drm_printer helper Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 28/39] drm/tests: Add tests for the atomic state readout Maxime Ripard
2026-11-06 13:44   ` sashiko-bot
2026-11-06 13:14 ` [PATCH v8 29/39] drm/encoder: Create atomic_sro_get_current_crtc hook Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 30/39] drm/bridge: display-connector: Implement readout support Maxime Ripard
2026-11-06 13:50   ` sashiko-bot
2026-11-06 13:14 ` [PATCH v8 31/39] drm/bridge_connector: Implement hw readout for connector Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 32/39] drm/tidss: crtc: Add atomic_print_state implementation Maxime Ripard
2026-11-17  7:24   ` Tomi Valkeinen
2026-11-06 13:14 ` [PATCH v8 33/39] drm/tidss: dispc: Improve mode checking logs Maxime Ripard
2026-11-17  7:25   ` Tomi Valkeinen
2026-11-06 13:14 ` [PATCH v8 34/39] drm/tidss: Implement hw_reset Maxime Ripard
2026-11-06 13:50   ` sashiko-bot
2026-11-06 13:14 ` [PATCH v8 35/39] drm/tidss: Implement readout support Maxime Ripard
2026-11-06 14:06   ` sashiko-bot
2026-11-06 13:14 ` [PATCH v8 36/39] drm/tidss: encoder: Implement atomic_sro_get_current_crtc Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 37/39] drm/bridge: sii902x: Implement hw state readout Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 38/39] drm/panel: Implement state readout support Maxime Ripard
2026-11-06 13:45   ` sashiko-bot
2026-11-06 13:14 ` [PATCH v8 39/39] fixup! drm/tidss: Implement " Maxime Ripard
2026-11-06 13:57   ` sashiko-bot
2026-11-17 15:17 ` [PATCH v8 00/39] drm: Implement state " Tomi Valkeinen
2026-11-18 12:37   ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-201471@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=mripard@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox