Re: [PATCH v2 2/3] drm/msm/dp: Remove redundant force_link_train flag

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] drm/msm/dp: inaccurate commit message for
  msm_dp_ctrl_prepare_stream_on()
--

commit c06a5a571a6cad37f7087d19d2c71c6677e8fbc7
Author: Saurabh Anand <saurabh.anand@oss.qualcomm.com>

> drm/msm/dp: Remove redundant force_link_train flag
>
> force_link_train is always false when passed to
> msm_dp_ctrl_prepare_stream_on(): the initial link is trained by
> msm_dp_ctrl_on_link(), and the flag is cleared before stream preparation.
> For active streams, it is never set.
>
> Remove the dead flag and parameter. Stream preparation still retrains
> when channel equalization is incomplete.
>
> Signed-off-by: Saurabh Anand <saurabh.anand@oss.qualcomm.com>

[Severity: Medium]
Is the commit message accurate about force_link_train always being false?

In msm_dp_display_prepare_link(), when !msm_dp_display->power_on holds on
display enable, force_link_train is set to true and passed directly to
msm_dp_ctrl_prepare_stream_on() without being cleared.  Rather than
removing a dead flag, this change stops msm_dp_ctrl_prepare_stream_on()
from unconditionally calling msm_dp_ctrl_link_retrain() a second time
right after msm_dp_ctrl_on_link() has already trained the link.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111104434.2222182-1-naidu.nama@oss.qualcomm.com?part=2