From: sashiko-bot@kernel.org
To: "Helge Deller" <deller@gmx.de>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/2] fbcon: Don't drop last logo line if logo is same size as screen
Date: Fri, 20 Nov 2026 18:38:53 +0000 [thread overview]
Message-ID: <sashiko-outbox-225856@kernel.org> (raw)
In-Reply-To: <20261120175413.176249-2-deller@gmx.de>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] fbcon: full-screen boot-logo overwritten by update_region()
in fbcon_switch()
--
commit 1d5d014858b9e8c6374a333c00292505b2a11f3a
Author: Helge Deller <deller@gmx.de>
fbcon: Don't drop last logo line if logo is same size as screen
This commit allows logo_lines to reach new_rows in fbcon_prepare_logo() so
a full-screen boot logo is not truncated by one character row, while
keeping vc->vc_top unchanged when logo_lines reaches vc->vc_bottom.
> diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
> index 7720dfc80c165..12a27b520260e 100644
> --- a/drivers/video/fbdev/core/fbcon.c
> +++ b/drivers/video/fbdev/core/fbcon.c
> @@ -637,7 +637,7 @@ static void fbcon_prepare_logo(struct vc_data *vc, struct fb_info *info,
> logo_height = fb_prepare_logo(info, par->rotate);
> logo_lines = DIV_ROUND_UP(logo_height, vc->vc_font.height);
> logo_lines = min(logo_lines, rows);
> - logo_lines = min(logo_lines, new_rows - 1);
> + logo_lines = min(logo_lines, new_rows);
> if (logo_lines <= 0) {
> logo_lines = 0;
> logo_shown = FBCON_LOGO_DONTSHOW;
> @@ -705,7 +705,9 @@ static void fbcon_prepare_logo(struct vc_data *vc, struct fb_info *info,
> pr_info("fbcon: disable boot-logo (boot-logo bigger than screen).\n");
> } else {
> logo_shown = FBCON_LOGO_DRAW;
> - vc->vc_top = logo_lines;
> + /* keep vc_top if logo covers whole screen */
> + if (logo_lines < vc->vc_bottom)
> + vc->vc_top = logo_lines;
> }
> }
> #endif /* MODULE */
[Severity: Medium]
When the boot logo covers the whole screen (logo_lines == vc->vc_bottom),
does leaving vc->vc_top at 0 cause fbcon_switch() to immediately erase the
logo?
Earlier in fbcon_prepare_logo(), scr_memsetw() fills logo_lines rows of
vc->vc_origin with erase characters. When fbcon_switch() runs with
logo_shown == FBCON_LOGO_DRAW, it draws the logo and then redraws the text
region starting from vc->vc_top:
drivers/video/fbdev/core/fbcon.c:fbcon_switch() {
...
if (logo_shown == FBCON_LOGO_DRAW) {
logo_shown = fg_console;
fb_show_logo(info, par->rotate);
update_region(vc,
vc->vc_origin + vc->vc_size_row * vc->vc_top,
vc->vc_size_row * (vc->vc_bottom -
vc->vc_top) / 2);
return false;
}
...
}
With vc->vc_top left at 0, update_region() blits those blank erase
characters from vc->vc_origin over all rows 0..vc->vc_bottom - 1 right
after fb_show_logo(), wiping out the full-screen logo.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261120175413.176249-1-deller@gmx.de?part=2
prev parent reply other threads:[~2026-11-20 18:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 17:54 [PATCH 1/2] fbdev: radeonfb: reject a zero pixclock in radeonfb_check_var() Helge Deller
2026-11-20 17:54 ` [PATCH 2/2] fbcon: Don't drop last logo line if logo is same size as screen Helge Deller
2026-11-20 18:38 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-225856@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox