From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA956606A320 for ; Sat, 21 Nov 2026 07:45:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Gd2RaALu Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 24A8510E393; Sat, 21 Nov 2026 07:45:34 +0000 (UTC) Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id A079210E393 for ; Sat, 21 Nov 2026 07:45:27 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 5744C4117E; Sat, 21 Nov 2026 07:45:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C94FD1F000C0; Sat, 21 Nov 2026 07:45:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795247127; bh=g7uVbYqCYWmetjl6f9vcUu3yNhR9LD4vfFPastZ9L80=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Gd2RaALu/YwbhvRDd0Z4V8W6BDTN9LuaxkRmnYQ3o29ncAnI2Yy07hmk6WoEs5M8C 0uaGgL6Dpq9MBTHFE+ELK8/L3ih2cjUaNW5g7xsHPgRUEJDqDW2UQrCx9JmlcWU1s0 xIzR5pD30TG84Ry+nSipDMeqlFRrT2ovl41W3X39S4wTH8PcZS6kkCgiIgASvtEu3m MeKxmjon2kT9EHKitQHsJOv3rVPuW2neXaWWNX0zhhKHVuMOuGsxaYng0im3etEtny 1kugrSda3VgMibAhhXnKbUueroRVF76HoK1T9SPMBSZc4mFaLbhjmQevzCbyQQTCXh jcVnZHUezUDCQ== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 03/17] dt-bindings: display: spacemit: add K3 Innosilicon DP/eDP controller To: "Cody Kang" Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-phy@lists.infradead.org, linux-clk@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com In-Reply-To: <20261121-k3-display-v3-3-ec419e8e96b8@gmail.com> References: <20261121-k3-display-v3-0-ec419e8e96b8@gmail.com> <20261121-k3-display-v3-3-ec419e8e96b8@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Sat, 21 Nov 2026 07:45:26 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Sender: "dri-devel" X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 X-Archived-By: Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] dt-bindings: display: spacemit: interrupts listed before clocks in k3-inno-dp -- commit ec123ddd0dcb86d2168d07ef0954ffae1dd9d9aa Author: Cody Kang dt-bindings: display: spacemit: add K3 Innosilicon DP/eDP controller This commit adds the Device Tree binding schema for the SpacemiT K3 Innosilicon DisplayPort and embedded DisplayPort controller. > diff --git a/Documentation/devicetree/bindings/display/spacemit/spacemit,= k3-inno-dp.yaml b/Documentation/devicetree/bindings/display/spacemit/spacem= it,k3-inno-dp.yaml > new file mode 100644 > index 0000000000000..491d25730da9f > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/spacemit/spacemit,k3-inno= -dp.yaml > @@ -0,0 +1,141 @@ [ ... ] > +properties: > + compatible: > + const: spacemit,k3-inno-dp > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + description: Link and hot-plug events. > + > + clocks: > + items: > + - description: Pixel clock for the controller. > + - description: > + Pixel clock generated by the DP PHY PLL; the pixel clock above= is > + parented onto it in use. > + > + clock-names: > + items: > + - const: pxclk > + - const: pll [ ... ] > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names [ ... ] > + edp@cac84000 { > + compatible =3D "spacemit,k3-inno-dp"; > + reg =3D <0x0 0xcac84000 0x0 0x4000>; > + interrupts =3D <132 IRQ_TYPE_LEVEL_HIGH>; > + clocks =3D <&syscon_apmu CLK_APMU_EDP0_PXCLK>, <&edp0_phy>; > + clock-names =3D "pxclk", "pll"; [Severity: Low] This isn't a bug, but DT binding schemas and example nodes follow the canonical property ordering where clocks and clock-names appear before interrupts. Could interrupts be moved after clock-names in properties, required, and the edp@cac84000 example node? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261121-k3-display= -v3-0-ec419e8e96b8@gmail.com?part=3D3