dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: ZhuXiangyu <1194781887@qq.com>
Cc: linux-phy@lists.infradead.org, dri-devel@lists.freedesktop.org,
	vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com
Subject: Re: [PATCH] drm/phy: rockchip: fix RK3506 DSI low-power command handling
Date: Sat, 21 Nov 2026 08:03:21 +0000	[thread overview]
Message-ID: <sashiko-outbox-226818@kernel.org> (raw)
In-Reply-To: <tencent_6F7C9E04169BCBAE4E162DAA3DCD5395B209@qq.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/phy: rockchip: missing Fixes: trailers for RK3506 DSI and
  DPHY fixes
--

commit d9fc037cd18d975d189c46c8a1d083b08c417a92
Author: ZhuXiangyu <1194781887@qq.com>

> drm/phy: rockchip: fix RK3506 DSI low-power command handling
>
> Two bugs keep the RK3506 MIPI-DSI link from initialising a panel: the
> DPHY programs the wrong high-speed timing entry, and the PHY data lanes
> are never enabled in the GRF.
>
> 1. phy-rockchip-inno-dsidphy picks the wrong HS timing entry
>
>    The 1.5 GHz inno DSI PHY timing table stores its rates in Mbps while
>    the other tables and the lookup use Hz. The mode enable code compares
>    inno->pll.rate in Hz (e.g. 372000000) against timings[].rate in Mbps
>    (e.g. 400), so the comparison never matches. The loop runs to the end
>    and the last, fastest entry is used, which programs a TLPX/LPX
>    counter that is far too large. The panel then cannot decode the
>    low-power DCS commands and stays in sleep mode, so the display stays
>    black even though the LP packets are visible on the data lane.
>
>    Convert the 1.5 GHz timing table rates to Hz so that the lookup
>    selects the correct entry.
>
> 2. The RK3506 DSI GRF lane enable bits are never written
>
>    rk3506_chip_data only clears the turnaround / force-stop fields, so
>    the PHY data lanes stay disabled unless the boot loader happens to
>    enable them. Program RK3506_DSI_PHY_ENABLE_LANE0/1 as well.
>
> Tested on the RK3506B JerryTech board: the panel now receives the init
> sequence over LP and the framebuffer console is visible.
>
> Signed-off-by: ZhuXiangyu <1194781887@qq.com>

[Severity: Low]
This fixes bugs in the RK3506 DPHY and DSI support.  Should the commit
message include:

  Fixes: 785a9d5bb145 ("phy: rockchip: inno-dsidphy: Add support for rk3506")
  Fixes: cabeacc7eadc ("drm/rockchip: dsi: Add support for rk3506")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/tencent_6F7C9E04169BCBAE4E162DAA3DCD5395B209@qq.com?part=1

       reply	other threads:[~2026-11-21  8:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <tencent_6F7C9E04169BCBAE4E162DAA3DCD5395B209@qq.com>
2026-11-21  8:03 ` sashiko-bot [this message]
     [not found] <tencent_F495CC22423581B98A12990F93C04F33CB06@qq.com>
2026-11-21 13:33 ` [PATCH] drm/phy: rockchip: fix RK3506 DSI low-power command handling Heiko Stübner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-226818@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=1194781887@qq.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=neil.armstrong@linaro.org \
    --cc=olteanv@gmail.com \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox