dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] gpu/trace: TRACE_GPU_MEM should depend on DRM
@ 2025-07-31  7:51 Geert Uytterhoeven
  2025-08-08 13:11 ` Lucas De Marchi
  0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2025-07-31  7:51 UTC (permalink / raw)
  To: Juston Li, Lucas De Marchi, David Airlie, Simona Vetter
  Cc: dri-devel, linux-kernel, Geert Uytterhoeven

GPU memory usage tracepoints are only used by DRM GPU drivers.
Hence add a dependency on DRM, to prevent asking the user about this
functionality when configuring a kernel without DRM GPU support.

Fixes: 5d95cbf21a4a550f ("gpu/trace: make TRACE_GPU_MEM configurable")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/gpu/trace/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/trace/Kconfig b/drivers/gpu/trace/Kconfig
index cd3d19c4a201c9c6..7f405ce7df5a0a42 100644
--- a/drivers/gpu/trace/Kconfig
+++ b/drivers/gpu/trace/Kconfig
@@ -2,6 +2,7 @@
 
 config TRACE_GPU_MEM
 	bool "Enable GPU memory usage tracepoints"
+	depends on DRM || COMPILE_TEST
 	default n
 	help
 	  Choose this option to enable tracepoints for tracking
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] gpu/trace: TRACE_GPU_MEM should depend on DRM
  2025-07-31  7:51 [PATCH] gpu/trace: TRACE_GPU_MEM should depend on DRM Geert Uytterhoeven
@ 2025-08-08 13:11 ` Lucas De Marchi
  0 siblings, 0 replies; 2+ messages in thread
From: Lucas De Marchi @ 2025-08-08 13:11 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Juston Li, David Airlie, Simona Vetter, dri-devel, linux-kernel

On Thu, Jul 31, 2025 at 09:51:13AM +0200, Geert Uytterhoeven wrote:
>GPU memory usage tracepoints are only used by DRM GPU drivers.
>Hence add a dependency on DRM, to prevent asking the user about this
>functionality when configuring a kernel without DRM GPU support.
>
>Fixes: 5d95cbf21a4a550f ("gpu/trace: make TRACE_GPU_MEM configurable")
>Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Currently there are 2 drivers using it: drm/xe and drm/msm, but there's
no real dependency and in future more drivers may add these tracepoints.
Juston, do you have any other drivers planned?

Lucas De Marchi

>---
> drivers/gpu/trace/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/gpu/trace/Kconfig b/drivers/gpu/trace/Kconfig
>index cd3d19c4a201c9c6..7f405ce7df5a0a42 100644
>--- a/drivers/gpu/trace/Kconfig
>+++ b/drivers/gpu/trace/Kconfig
>@@ -2,6 +2,7 @@
>
> config TRACE_GPU_MEM
> 	bool "Enable GPU memory usage tracepoints"
>+	depends on DRM || COMPILE_TEST
> 	default n
> 	help
> 	  Choose this option to enable tracepoints for tracking
>-- 
>2.43.0
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-08-08 13:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-31  7:51 [PATCH] gpu/trace: TRACE_GPU_MEM should depend on DRM Geert Uytterhoeven
2025-08-08 13:11 ` Lucas De Marchi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).