From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCH] drm/i915/bios: Avoid temporary allocation whilst searching for downclock Date: Wed, 13 Jul 2011 11:13:24 -0700 Message-ID: References: <20110704205520.6adf862a@lxorguk.ukuu.org.uk> <1309856134-20486-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1523223326==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id 0997B9F380 for ; Wed, 13 Jul 2011 12:32:38 -0700 (PDT) In-Reply-To: <1309856134-20486-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Chris Wilson , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1523223326== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Tue, 5 Jul 2011 09:55:34 +0100, Chris Wilson = wrote: > Alan Cox reported a missing check on the kmalloc return value for the > allocation of a temporary mode used for searching for the LVDS downlock > frequency. This allocation is roughly 200 bytes, a little too large to > friviously place on the stack. However, we can simply use the few bytes > we need stored within the original DVO timing data, skip the translation > and do the compare directly between the timing data rather than on a > mode, thus avoiding the need for any temporary allocations. Can you clean this one up for -next? I'm merging bug fixes to -next to send off for post-3.0 integration. =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iD8DBQFOHeBEQp8BWwlsTdMRAjBEAJwLjT7gYKc2sn+/EAQMg3T8U3gK3gCePTcX 4TiYU9C3VQvBBspQVfQhLrI= =PHKf -----END PGP SIGNATURE----- --=-=-=-- --===============1523223326== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1523223326==--