From: Heiner Kallweit <hkallweit1@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
driver-core@lists.linux.dev
Subject: Re: [PATCH 1/3] driver core: constify group arrays arguments in driver_add_groups and driver_remove_groups
Date: Thu, 2 Apr 2026 18:25:28 +0200 [thread overview]
Message-ID: <1e904f24-63f3-4876-8d9e-63e2b5465269@gmail.com> (raw)
In-Reply-To: <2026040222-progress-thrive-220c@gregkh>
On 02.04.2026 17:11, Greg Kroah-Hartman wrote:
> On Mon, Mar 16, 2026 at 11:09:37PM +0100, Heiner Kallweit wrote:
>> Constify the groups array argument in driver_add_groups and
>> driver_remove_groups. This allows to pass constant arrays as
>> arguments.
>
> But do we? How down the * const depth do we want to go? :)
>
Not yet, but this is the next step. __ATTRIBUTE_GROUPS() would be
complemented by a version creating a constant array. If something
that de-facto is constant, lives in .rodata, then that's a good
thing IMO.
> And does any of this series require any other fixups? If not, does it
> actually do anything?
>
According to my checks no fixups are needed. And so far no CI
complained about the series, what I interpret as a positive sign.
This series doesn't do anything, it's a prerequisite for changes
like the one described in aforementioned comment.
> thanks,
>
> greg k-h
Heiner
next prev parent reply other threads:[~2026-04-02 16:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 22:08 [PATCH 0/3] driver core: make struct device_driver and bus_type groups members constant arrays Heiner Kallweit
2026-03-16 22:09 ` [PATCH 1/3] driver core: constify group arrays arguments in driver_add_groups and driver_remove_groups Heiner Kallweit
2026-04-02 15:11 ` Greg Kroah-Hartman
2026-04-02 16:25 ` Heiner Kallweit [this message]
2026-03-16 22:10 ` [PATCH 2/3] driver core: make struct bus_type groups members constant arrays Heiner Kallweit
2026-03-16 22:11 ` [PATCH 3/3] device core: make struct device_driver " Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e904f24-63f3-4876-8d9e-63e2b5465269@gmail.com \
--to=hkallweit1@gmail.com \
--cc=dakr@kernel.org \
--cc=driver-core@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox