From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Brown <broonie@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-kernel@vger.kernel.org, driver-core@lists.linux.dev
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>
Subject: [PATCH v2 1/5] regcache: Remove duplicate check in regcache_hw_init()
Date: Wed, 25 Feb 2026 17:15:55 +0100 [thread overview]
Message-ID: <20260225161659.3811671-2-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20260225161659.3811671-1-andriy.shevchenko@linux.intel.com>
The regcache_hw_init() is never called without preliminary check
for num_reg_defaults_raw not being 0. Thus, remove duplicate in
the function.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/base/regmap/regcache.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c
index a35f2b20298b..d41cdb39c78f 100644
--- a/drivers/base/regmap/regcache.c
+++ b/drivers/base/regmap/regcache.c
@@ -50,9 +50,6 @@ static int regcache_hw_init(struct regmap *map)
unsigned int reg, val;
void *tmp_buf;
- if (!map->num_reg_defaults_raw)
- return -EINVAL;
-
/* calculate the size of reg_defaults */
for (count = 0, i = 0; i < map->num_reg_defaults_raw; i++)
if (regmap_readable(map, i * map->reg_stride) &&
--
2.50.1
next prev parent reply other threads:[~2026-02-25 16:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 16:15 [PATCH v2 0/5] regcache: Avoid accessing non-initialised cache Andy Shevchenko
2026-02-25 16:15 ` Andy Shevchenko [this message]
2026-02-25 16:15 ` [PATCH v2 2/5] regcache: Split regcache_count_cacheable_registers() helper Andy Shevchenko
2026-02-25 16:15 ` [PATCH v2 3/5] regcache: Move HW readback after cache initialisation Andy Shevchenko
2026-02-26 12:20 ` Mark Brown
2026-02-26 13:27 ` Andy Shevchenko
2026-02-26 13:41 ` Andy Shevchenko
2026-02-26 13:57 ` Mark Brown
2026-02-25 16:15 ` [PATCH v2 4/5] regcache: Define iterator inside for-loop and align their types Andy Shevchenko
2026-02-25 16:15 ` [PATCH v2 5/5] regcache: Amend printf() specifiers when printing registers Andy Shevchenko
2026-02-25 19:15 ` Mark Brown
2026-02-25 19:24 ` Andy Shevchenko
2026-02-25 19:26 ` Andy Shevchenko
2026-02-26 11:10 ` Mark Brown
2026-02-26 11:47 ` (subset) [PATCH v2 0/5] regcache: Avoid accessing non-initialised cache Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260225161659.3811671-2-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=dakr@kernel.org \
--cc=driver-core@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox