From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4C7A35F5F9 for ; Thu, 5 Mar 2026 21:46:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772747197; cv=none; b=j1OU6umAHcvSnFnj+jMvO+h0YKzwCUKpWqXlsgZNxWuQUOrPnZfIXN3F4c7kWvZi3wvVD5LMkIwuPfgn7OFbpLK97JPzC1TBQaTZnifmsxZeHDmVqoG+ZvdCbLlY5NjpMTcXHIWD5km5/X5eCgLU4Tu32jUZN26w1aznjmdwVKY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772747197; c=relaxed/simple; bh=aBbZ3fBywOvpHZwjLuwnPh4cf1hQWBZWB8iOkYD1Dl0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aBijfaN4eTWbUTV8TEVfxw8OAfS+kh/YoappPPfbYt22W79vowDlF6nOlkGMUKrMhMbzXghZEJ58jaSZZDQ6EFAUVTOGv+WLqWTesB9H/n8Gy8zcP6uChxOcFuXt/8pfGWyLYGuEudZEfiYepFN15wvWR4Im86THkBJm/5ThkKU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nr4T+3eb; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=e51fmknv; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nr4T+3eb"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="e51fmknv" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 625KmW8Y3725846 for ; Thu, 5 Mar 2026 21:46:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= n4xjjhrcSsGg/B56PKtYV9FcQh+keTvXc9MMcImQ6Q8=; b=nr4T+3ebr1GJrOG6 oJS1QoImgPAnuAAGCrayURKG6BxlosUfnXUwq/PWK6ywxT/K4BzCHSJlmRScuKc1 YDLEDC5EdgKDgnHIwOhbJ/ypifKbXb2fXrY1kSU4BqI/Xivne2zrKiU09upW9WEk hj8gxxcO8lu5OhvwP+/vBktvBJOdsqEsZ2M6GXGhPExJUogJ4BQCPR12z3cHFnqQ g+J7fjOh6uDcM3BbxgUZzqyeD5r8JJhyfVR6c5VcNNIFaFuyIrGZF1RpPoBQNJaC fxQ/UGt1g+KdbfOt/8gi4RDZ0HrqA1I61U2/o3j42lldLnNas1910ChS8YzrA/K0 OcGQZQ== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cq85dj4j6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 05 Mar 2026 21:46:34 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cb706313beso1085819985a.3 for ; Thu, 05 Mar 2026 13:46:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772747194; x=1773351994; darn=lists.linux.dev; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=n4xjjhrcSsGg/B56PKtYV9FcQh+keTvXc9MMcImQ6Q8=; b=e51fmknvUh4yFAZahwocXPLj2OXWCKOD1204w3P+25+L1EZXQ8An5parYtX3YH6Ezb CLpzOKfl+425zF+Q8ATx3qSzW8dX03tVTPMu9JLa607Jz32fCZBUeun2FVFTAJcWXwGJ Z6aC6MLrpU80+7aOh6EQZQLc7XkaX7AiIRqUwKGn41pDFxEKuRImsKFb3cgVRt0/xFQ0 gsWO8PE8GhUhIHoR1pU7cNIMyN7SFGcyE9fKyxEI9tLtrOIEaYW4wgDnopOtDEQLDF2d D6taTP+yd4CMsCqDSbehyG3qHs9SeeVEW6Lf4PbI5Qb17DaKUowFCLz+X6iIW1pO9k0y lKRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772747194; x=1773351994; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=n4xjjhrcSsGg/B56PKtYV9FcQh+keTvXc9MMcImQ6Q8=; b=tfV7BmAr/ofTmkqT5MoxSEuwBlhDTOxM3KqEVKLdYM1Eekjwe2zGIAnA+d0ZbeM0Rq W1H5qifuk68tR/aklXB6Gsb9GJqNjZ9rzMNn1VF4Yv8yzmDxzeBq8fdlMsNFPAbvz1wt axTfAo3SuCQ5Sq08RK7vP847NzsbAx3Uer9FSYKQM9UC0owwJyk7b0Uk+zG3U0hBpWz4 x/wmgieAG05x/ex6VuGKENaTkO69OTqM1Xq7Eo2whJzBT/nhvGn85YxBlo7W8u5M29qC 3VtzAZrkRDbzh+dqLgwa/3RKLjUlABTvoaY/46OQQk3LFQC15bVWq5OVLR7iGm119vW6 2NqQ== X-Forwarded-Encrypted: i=1; AJvYcCWcGYL42Q5Bk1sEBIj68IspQ1OYD4tY286h29mB9upgm8jdRIeNettSQbfqFmYSz2pqlIWdShfDX/cpdA==@lists.linux.dev X-Gm-Message-State: AOJu0YzLaXELQCPW2H3Jk+MSGubs/SqcovIJztRQV2gVOA3FTwWZONbw Ys0lTWPmElH24l6OmGJbltf6bHAWFiouJS526XdmRYMSLq3WSKR9cwhVZSDgUk/Ty0ZS9BUgmaV AGISHz666hY5kRAXsrCrgjb7q1wSIaSpIzMCxV9z22XIvms85uxEkCwmomAaMINRe3w== X-Gm-Gg: ATEYQzyCI23mEUL/6YZRsSSKEnn8rk0zt0ppJVeUsyMfNA09iEGvvE0tIJaePNnJ/o4 B6q7nbnzAkQ10EcBuugTpe2JP66ZdEacJbH8Bkmt5ZQ6cJlOz6hsXBFUv5yhH49aE/8DL+4zoFL FKDNsb0eKvOBQfhqPWZ6cNFJwmSIkrRDyCcH1udrbo2B0DZzaqPlbWGmQSQmcjUvMbtAHzIgL8w gAg3HEQv9ez3HGvFMoDQDpJX5Lz2ogNQlj1GFlvoHH24SRjEXmSc31LDnEBHwm+811rOX7hlPId Oho4L2rFzykRiAKOuMud3/5uV4DdHkskL8CeyNHhoyeGzMkHjaSXK65Mq+tzED7S6dUitVkFaIH s8ZGiDiWaJChbxPnm2151u94O5VgxK3bXVBLxfaP91Ab4 X-Received: by 2002:a05:620a:2806:b0:8c7:9e6:3a72 with SMTP id af79cd13be357-8cd6d31f36emr6487485a.6.1772747194111; Thu, 05 Mar 2026 13:46:34 -0800 (PST) X-Received: by 2002:a05:620a:2806:b0:8c7:9e6:3a72 with SMTP id af79cd13be357-8cd6d31f36emr6484285a.6.1772747193616; Thu, 05 Mar 2026 13:46:33 -0800 (PST) Received: from [127.0.1.1] ([178.197.219.94]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439ba2a58dasm28571575f8f.27.2026.03.05.13.46.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 13:46:32 -0800 (PST) From: Krzysztof Kozlowski Date: Thu, 05 Mar 2026 22:45:47 +0100 Subject: [PATCH v2 08/10] mfd: ezx-pcap: Return directly instead of empty gotos Precedence: bulk X-Mailing-List: driver-core@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260305-workqueue-devm-v2-8-66a38741c652@oss.qualcomm.com> References: <20260305-workqueue-devm-v2-0-66a38741c652@oss.qualcomm.com> In-Reply-To: <20260305-workqueue-devm-v2-0-66a38741c652@oss.qualcomm.com> To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Jonathan Corbet , Shuah Khan , Tejun Heo , Lai Jiangshan , Tobias Schrammm , Sebastian Reichel , Andy Shevchenko , Dan Carpenter , Krzysztof Kozlowski , Lee Jones , Dzmitry Sankouski , Matthias Brugger , AngeloGioacchino Del Regno , Benson Leung , Tzung-Bi Shih Cc: Matti Vaittinen , driver-core@lists.linux.dev, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, chrome-platform@lists.linux.dev, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1584; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=aBbZ3fBywOvpHZwjLuwnPh4cf1hQWBZWB8iOkYD1Dl0=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpqfmfZyTBQ2+zfg1PVbm//IV3ttzRuDFXfJ09L Fi7SOtMm4iJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaan5nwAKCRDBN2bmhouD 13yRD/9atq9XS2gdzOD4iwNE2NzTH/fSxgzEasdtz+9zZKfFoTpfnxFWtJTbN7SumZgig525A5R VdZmzIWGbcYZpE3xAn4xsvjLbNB8/GeTpJ1kt8T1rcPPpX94dr5Ht/K5pRdjnVycWFPiKJXtfcA iRY5/XOeIZEhXpU7ClLZTrejxnGjsURe8r+u+LlmWrGlfT4VYT4yepmb5E8OIVDUXnlKFEepRKQ WYPZ09Oyl21MABeuojbxhRPxzoA/jzjdLe+iCBVzlFihUMfiFrrWvfX872J1GXClSLlGaYFGLeA VYOoHJFuO57Q7+4oULKXpzkUTIexLmRp3dGkkprPpzpR0q6+gCsLVeSHJfIl54kgDeKlSJVa4tP 3tx68crLjDIkHq147LN+7Nlv1yacTQ1Drn3PPXGsOwNHTmOkKt6eoO1tJSU8dItyVB3VdAVUtW5 YLK5tSgOKhSGndBJaJennrnsayMckl9rhJer7AXlC+sKZ31Ii2uZY9DFB4tGUXtmtDRpX+Nnw1u mTECOe4Qt/1YAn962XvbBJjzoZWliJdxuREn2dZiFlamnSKzxS8Tk9zX12OJI6nHFFiZNZESZ3L 13YIinDTo1FuLh5Fosug3FzrBQlUb6CCIR4714nwcgAQpBhwwMlKDWA4q46CeQ1kxUm2ocxmk0m CC5zMWv80d+IrUw== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-ORIG-GUID: ATWRUvzf0Ca5LrLXbxuwSTJ4pUx8u1jk X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA1MDE4NSBTYWx0ZWRfX6VwraHwaHjp4 A2yDhupKhQjKTgtslg4VTV9klY2xRQ0Kar9pVjJxz4XQcyvJYobhdHBzXujOWovmUGp/fmVUAKq ZriY+e+ivyJYzp82eemunumNtgxnhcA/Ti3W/if42p19LgJtAfyP8JQUPDRUI3vdw0YrcE4clnj DL/+THxBnWtZ2jHanjzsqLNMw6wGOKa3Q2ELp1CHmr+ZKDdbSaQ6jRGHvw9cEyJ7E2hd1I1aW6V foJO0pH0N9dGFmmBIMBiHD//4H5TWHXq7W3hkpBKooxJmmgCYreRZ2O6zbY+uh7HRrJhhZLhQGI pA7T96pnBWK0vE+8aMwPTFPT24uOUUwvUrvsOVj8gGoPg/JS6C5JdIXud/DIBnF9ufY27mIoGu1 jier4xsy4rFvk73pSfmhzmG9AFDqYdqHLvkesBvV51AQTXSVS1PL6VTMUw2F2/5VQMLACBmE1fG lkSjjwPe6IDyLpbQmXg== X-Authority-Analysis: v=2.4 cv=aOb9aL9m c=1 sm=1 tr=0 ts=69a9f9ba cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=gOEeR9iKwsj33Yj5oN/cWg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=VGyNsPSQNFFz0_f43M8A:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-GUID: ATWRUvzf0Ca5LrLXbxuwSTJ4pUx8u1jk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-05_06,2026-03-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 clxscore=1015 adultscore=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603050185 Code is easier to read if empty error paths simply return, instead of jumping to empty label doing only "return ret". Signed-off-by: Krzysztof Kozlowski --- drivers/mfd/ezx-pcap.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/mfd/ezx-pcap.c b/drivers/mfd/ezx-pcap.c index cd0520a08224..8e51c113a320 100644 --- a/drivers/mfd/ezx-pcap.c +++ b/drivers/mfd/ezx-pcap.c @@ -384,17 +384,15 @@ static int ezx_pcap_probe(struct spi_device *spi) struct pcap_platform_data *pdata = dev_get_platdata(&spi->dev); struct pcap_chip *pcap; int i, adc_irq; - int ret = -ENODEV; + int ret; /* platform data is required */ if (!pdata) - goto ret; + return -ENODEV; pcap = devm_kzalloc(&spi->dev, sizeof(*pcap), GFP_KERNEL); - if (!pcap) { - ret = -ENOMEM; - goto ret; - } + if (!pcap) + return -ENOMEM; spin_lock_init(&pcap->io_lock); spin_lock_init(&pcap->adc_lock); @@ -407,17 +405,15 @@ static int ezx_pcap_probe(struct spi_device *spi) spi->mode = SPI_MODE_0 | (pdata->config & PCAP_CS_AH ? SPI_CS_HIGH : 0); ret = spi_setup(spi); if (ret) - goto ret; + return ret; pcap->spi = spi; /* setup irq */ pcap->irq_base = pdata->irq_base; pcap->workqueue = create_singlethread_workqueue("pcapd"); - if (!pcap->workqueue) { - ret = -ENOMEM; - goto ret; - } + if (!pcap->workqueue) + return -ENOMEM; /* redirect interrupts to AP, except adcdone2 */ if (!(pdata->config & PCAP_SECOND_PORT)) -- 2.51.0