From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CE8435F193 for ; Thu, 5 Mar 2026 21:46:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772747200; cv=none; b=XdGfT3aibkfFLkkPou5XoV6Kkx9FfTl0oqfKAcSnGKjjCaRvk1k58FpOqDxCIbHDjw+FjBo0z6L/VfoGrGYdrBchTZc0BGBAwJ01rVB0Eb4zWfOLp5CFziQ77ayxSM+Ew20ZkiE/WPrIs6IwQkxnAdOx2b3TKzrMGshTMlBFI3A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772747200; c=relaxed/simple; bh=8HCvYehjmNIH+BlrLf3/jZA0T/6LceXynB2MmBf1YZo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NX5+ndZ2wIHth2su6TJy+VQ7kklTlTYvDIVdlMwwycDCoVH1GgGWJ3l6mRmGiV0zehrVAmGx2j/8eqlAj2Tf5WBqO1B5wdr0GKN7u2NKdgQyie0c2BP9GGsA2aDIaQXrrR9a15qd2KbjS6wCxyclivoe7kcvQJ1K0znHgfn8R6c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kTDsn66d; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HgalVcW/; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kTDsn66d"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HgalVcW/" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 625Kma2u1809304 for ; Thu, 5 Mar 2026 21:46:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xF762MP0D0x0cXFJ11pLhifB9krYSxT1GrxhCZLRMoE=; b=kTDsn66dim843s3x bzoXPIj8EMMuopwYjRQyxsAK0/F0JrLLNjwqqwjHiYKYbhwfPNhqEV4WSOKJTCUw 8oRKJBIWpwqKxNHZ57CpnugwbQWqPa5aSY2ouGRwOTL8lVMY7JpN/Y+1wNYXwsZk q/ZtWA4mj04NpXSgvJwO18yHZexy5y1y+Tj+Fzp0aTNXH93IRWMLAetDFFsYR4U2 Hpbx66OeSEqYiZt20rz+ClqHIZThDHpoZ3Ovg9QCfci4I6W4FyKD5qPoLWMoyLGk x0hL5k9uvxjBs8nNVHiSI8VkubHB0rMzXHqth4SYLMXk9Lp7OmDgRmKB3vX5TH+e YzxRLQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqgp407q4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 05 Mar 2026 21:46:38 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8c70ab7f67fso1088310185a.3 for ; Thu, 05 Mar 2026 13:46:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772747197; x=1773351997; darn=lists.linux.dev; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=xF762MP0D0x0cXFJ11pLhifB9krYSxT1GrxhCZLRMoE=; b=HgalVcW/Ap+Jo/KTuSQu0ELgFSEoqldh6zfVpptt81Sqmwvx6ZYO9Vel8vc69xyQhU tllyuNJuOF9W8Ue3JTVhlWIW8rO4bm0UDbpc+EpaIO9Lv2Rlg1snEbtjwkBJze8OmDZW sm44huBPZi/7tk1+k3OmvOp2z+bA4/7BrIaAFYKFD+y+tMzJyuL0+bDLM8KlNkr6dl5Q 4E1Onn+VfMZ8DBP7poX2gbHB9fwHoFlkGZHNSxJwrcWyU2eypBG3c5+Oe3ScCIivHThZ dOek296GI3oY1g+ZkKZCu/TjG9ESlcwzrJRjUK84l8lW3EfQHaAohT4Xgdi7MJ+tiM95 Bmaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772747197; x=1773351997; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=xF762MP0D0x0cXFJ11pLhifB9krYSxT1GrxhCZLRMoE=; b=DQRvPISLR7T4lC+2tjmI5ArB5aX3FA7PW/8y5Qr/z7IzPIuIRfF8ByZnL1wQCK3ybE zGoZQ7XfJZlzxf52Js4mt2FqVSNmitMl6vs2B0ZfbVAJZy6jzUxDkyPmrOcLg+FBp4NR zXN6u4RUzv7iWznjn55uNENXsfZXK8sJfNXDOgpKXpobjsFE2tmEk3qlFEdgmbyU9Yd1 UeQuegx1GnTorZG/y/fEXAHTzMSTB9vIpt3tY0FV4QAKdrlc+kyVYX1I8P85ACqM8QX5 MaAjDs0F0AjU323E0hU8gQ/Eu0RvUfwZvCY/2+H5SFuJVD76jLn8G9sYfWsjQCRzuBs4 nRtg== X-Forwarded-Encrypted: i=1; AJvYcCWxvlsm5AYU7JlUWLNPQfAMABMh86MySAxkTgIJyCKdjppGU6tA81ofN82DPWP/czEREfW2BEFhnVa6XQ==@lists.linux.dev X-Gm-Message-State: AOJu0YxhVNXaXSd4d+EH7kGPvSpzPss/2K5FXdk55AEzRWlciTRZtQvx 5AUt+igQETMgu15k7F64+h4lz1TX8Jl9rEHpYOGbTTTFEc4TxoBnvDjW0jY2SOP0m4+a7Xf8/Xq 5HAaBPyDtYiGXcRN+0/Tbd1Y966brJ3vAY06dRhtwUfb6DUMmv0cXCqcJzQq3yd8g6A== X-Gm-Gg: ATEYQzxH4rDo0xcrOsnu47AGAL+5ARz1z7CqA+OigJmZrSynHsuSkfPDNlWRO3wjI3D 6TIUX7xrUblpFBT0lm+Qh0cVdrQpH4oLF8p55HmkbRsWTgm8yDkffBSvekIs5HGUPTVnrTiTxPg xuUG+d8jCTYhKLI9KU4fUma0Aj5wTO46XQK+tNoBiJOVvQrdcUho/NEme2S1KDO82xLWmjkhmRT ed7KBA+R+NZdUmnVbHXWD9Cbmm+zxskommnBnKG0w31hhU3BUEveD4A4d06cHEqGFbmcD8yPM4H ZvnFc02rbloFa/ROVdAa0vfz5m1SGWurlGjt/56O4+UiqqWGiPLe2uC+MaojV5Eq+PmPmQ5kvd5 itWciPLyZws604vFqM6BEn6wIViNFTToxcqOJGtaO+RHk X-Received: by 2002:a05:620a:4687:b0:8ca:3fb7:2570 with SMTP id af79cd13be357-8cd6d4cc0d0mr1696685a.42.1772747197570; Thu, 05 Mar 2026 13:46:37 -0800 (PST) X-Received: by 2002:a05:620a:4687:b0:8ca:3fb7:2570 with SMTP id af79cd13be357-8cd6d4cc0d0mr1693585a.42.1772747197119; Thu, 05 Mar 2026 13:46:37 -0800 (PST) Received: from [127.0.1.1] ([178.197.219.94]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439ba2a58dasm28571575f8f.27.2026.03.05.13.46.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 13:46:36 -0800 (PST) From: Krzysztof Kozlowski Date: Thu, 05 Mar 2026 22:45:48 +0100 Subject: [PATCH v2 09/10] mfd: ezx-pcap: Avoid rescheduling after destroying workqueue Precedence: bulk X-Mailing-List: driver-core@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260305-workqueue-devm-v2-9-66a38741c652@oss.qualcomm.com> References: <20260305-workqueue-devm-v2-0-66a38741c652@oss.qualcomm.com> In-Reply-To: <20260305-workqueue-devm-v2-0-66a38741c652@oss.qualcomm.com> To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Jonathan Corbet , Shuah Khan , Tejun Heo , Lai Jiangshan , Tobias Schrammm , Sebastian Reichel , Andy Shevchenko , Dan Carpenter , Krzysztof Kozlowski , Lee Jones , Dzmitry Sankouski , Matthias Brugger , AngeloGioacchino Del Regno , Benson Leung , Tzung-Bi Shih Cc: Matti Vaittinen , driver-core@lists.linux.dev, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, chrome-platform@lists.linux.dev, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2299; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=8HCvYehjmNIH+BlrLf3/jZA0T/6LceXynB2MmBf1YZo=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpqfmgTLUiHh6rin6gIR8tn/yHPbJ7keLcVF5yZ GGBAe1ny7CJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaan5oAAKCRDBN2bmhouD 1+A1D/46IEOXU4c7rCB302yiUbZqrN3J0Box+FRnliJ/p6E8EXiDnmOg4obwzDlEUpFEf7ibEyq GYEw9cFAKDrszgDdGRbIFVYHr8RFOirL2Hdrl9Km81dPKqBQLXZQWnvAIKZe4uFGm8rDEiTS3FV gXubYix78Obr5LtZTm+Tn3H4VlOmRf/a1n/SAYakf/wp8btHWAgUY7J9nNAMK2Lbwsc4nzYJoHi vZbjtyC/9Gclm/CRe1O8vCpyJktvnNgAqHtQ/jojtr4XybHQF965vKIWwvLvoJBrhi2yylmf/EG S8CxeogMKobJs6UveopZ0d5TANJ1DRYacznxvzG9KA6g6X2xQKhxgYl480SHuTQMwdI5ygPt58U YlxL6+Ij5kO4Fz14qrhXHTZ40edvx0sQflZMFPcB4RVEyHUSnt2upCd3xRWA+BtmXbJ3NVnN7YE 7JHqzNSdItYNG4lO1wHyEOQRHGJ6KLMq+xqetuC7XXGt+e2iAroOx4ODQ1itWBm9mnLq0brsQkX aZkgptRJCcNG6nj6JfVtXI5u3cZGNevrxo+gGHIhTsR2iQROE0tCQbAzduBnKIEtq3Pm4AyCrGB GzbjoRK4ad8uW8GvCPBi00G3EXVvoOWPBuOLeQPVp8BuTwkTHYs7DVw1wsrnE0aEKQYge+pTQo1 a1ws7+4oKjEY6DQ== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-ORIG-GUID: pe-1RVCKlVyOfMSbHh38wYmi4efkeLHJ X-Authority-Analysis: v=2.4 cv=LegxKzfi c=1 sm=1 tr=0 ts=69a9f9be cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=gOEeR9iKwsj33Yj5oN/cWg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=3MYFky5D01qQmCoSdzEA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA1MDE4NSBTYWx0ZWRfX74tfpmlrz+uR N9O/Xeay6/S4TnEiNN7CTjJmMW8m8kvwg43HOa6bJhTLJ/2NjOe7hSqlpTBRjaw9uYE4hChsH+6 I5nVkoxBKgGU2vS4HnIXtjwByhwKv2JBOCxYccrl3SWQGhvcmljOoBtexCkhmxGzqzQUkXMX8QO tYwKmrg0OAzCt/Vb99BUezP8UPD47z8uxL61ZiKEGq9xTnP6mGZLsybKeBzscUEELOIqY/Gw3Ay XNyhRABacmtcNFPWM4hic8BQKbVzB7Yw4XiG3KRbszPLvb/b2g5CUmyolscugYCxwb3RULWQEQZ T4zEQ2qs/lJmEOQ9ckLNGuA0l/7TAghX/5I6xFkKQvjp1Qp2uCcoSVhfLh7+4ZxtW9NqALra9Nf 5ffSVg4c6gjeIf4UjcXLjuVTos0BzVIKFN6TEHZDzoYZ9gjQFFObk1avZKGLLXdB/XrdYB5NJib ap7/TnVZavheVVCe7fw== X-Proofpoint-GUID: pe-1RVCKlVyOfMSbHh38wYmi4efkeLHJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-05_06,2026-03-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 bulkscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603050185 Driver allocates workqueue and then registers additional interrupt handler with devm interface. This means that device removal will not use a reversed order, but first destroy workqueue and then, via devm release handlers, free the interrupt. The interrupt handler registered with devm does not directly use/schedule work items on the workqueue and the remove() function correctly removes other IRQs handlers, however the code mixing devm and non-devm interfaces is difficult to analyze and read. Make the code flow much more obvious by using devm interface for allocating the workqueue, so it will be freed with the rest of devm resources. Change is not equivalent in the workqueue itself: use non-legacy API which does not set (__WQ_LEGACY | WQ_MEM_RECLAIM). The workqueue is used to update device registers, thus there is no point to run it for memory reclaim. Signed-off-by: Krzysztof Kozlowski --- Depends on devm_xxx() from earlier patches. Changes in v2: 1. Use devm_alloc_ordered_workqueue(), mention this in commit msg --- drivers/mfd/ezx-pcap.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/mfd/ezx-pcap.c b/drivers/mfd/ezx-pcap.c index 8e51c113a320..9a685ff8cd15 100644 --- a/drivers/mfd/ezx-pcap.c +++ b/drivers/mfd/ezx-pcap.c @@ -375,8 +375,6 @@ static void ezx_pcap_remove(struct spi_device *spi) /* cleanup irqchip */ for (i = pcap->irq_base; i < (pcap->irq_base + PCAP_NIRQS); i++) irq_set_chip_and_handler(i, NULL, NULL); - - destroy_workqueue(pcap->workqueue); } static int ezx_pcap_probe(struct spi_device *spi) @@ -411,7 +409,7 @@ static int ezx_pcap_probe(struct spi_device *spi) /* setup irq */ pcap->irq_base = pdata->irq_base; - pcap->workqueue = create_singlethread_workqueue("pcapd"); + pcap->workqueue = devm_alloc_ordered_workqueue(&spi->dev, "pcapd", 0); if (!pcap->workqueue) return -ENOMEM; @@ -463,9 +461,7 @@ static int ezx_pcap_probe(struct spi_device *spi) free_irqchip: for (i = pcap->irq_base; i < (pcap->irq_base + PCAP_NIRQS); i++) irq_set_chip_and_handler(i, NULL, NULL); -/* destroy_workqueue: */ - destroy_workqueue(pcap->workqueue); -ret: + return ret; } -- 2.51.0