From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
Shivendra Pratap <shivendra.pratap@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, driver-core@lists.linux.dev,
linux-kernel@vger.kernel.org, brgl@kernel.org
Subject: Re: [PATCH RFT] driver core: faux: allow to set the firmware node for a faux device
Date: Fri, 6 Mar 2026 14:54:08 +0100 [thread overview]
Message-ID: <2026030649-evacuate-emotion-422c@gregkh> (raw)
In-Reply-To: <20260306-faux-dev-with-fwnode-v1-1-792a86a62530@oss.qualcomm.com>
On Fri, Mar 06, 2026 at 02:45:56PM +0100, Bartosz Golaszewski wrote:
> Add a new variant of faux_device_create() taking a firmware node handle
> as argument and attaching it to the created faux device. This allows
> users to define and read device properties using the standard property
> accessors.
Why would a faux device have firmware backing? Doesn't that mean it
should be a platform device?
> While at it: order includes in faux.c alphabetically for easier
> maintenance.
Hint, that should be a separate patch, and is never something that I
enforce or require in .c files I maintain :)
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> ---
> Hi Shivendra et al!
>
> This patch is related to my response to your reboot-mode patch[1].
>
> You should be able to use the new function like:
>
> faux_device_create_full("psci-reboot-mode", NULL, NULL, NULL, of_fwnode_handle(np));
What is the fwnode handle here for? Why is it required at all? What
resources are involved that would want this?
thanks,
greg k-h
next prev parent reply other threads:[~2026-03-06 13:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 13:45 [PATCH RFT] driver core: faux: allow to set the firmware node for a faux device Bartosz Golaszewski
2026-03-06 13:54 ` Greg Kroah-Hartman [this message]
2026-03-06 14:07 ` Bartosz Golaszewski
2026-03-06 14:13 ` Greg Kroah-Hartman
2026-03-06 14:24 ` Bartosz Golaszewski
2026-03-09 15:46 ` Shivendra Pratap
2026-03-09 15:55 ` Greg Kroah-Hartman
2026-03-10 12:29 ` Bartosz Golaszewski
2026-03-10 12:43 ` Greg Kroah-Hartman
2026-03-10 13:18 ` Bartosz Golaszewski
2026-03-12 15:25 ` Greg Kroah-Hartman
2026-03-10 13:16 ` Bartosz Golaszewski
2026-03-10 13:21 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026030649-evacuate-emotion-422c@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=dakr@kernel.org \
--cc=driver-core@lists.linux.dev \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=shivendra.pratap@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox