From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AA2B3128DF; Fri, 6 Mar 2026 13:54:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772805252; cv=none; b=kO+9mCTenMhVoc690SpV8tfB2oFTNoozk8iA1SUVPyKrsh1IMP3v+EjBNCJdDj89NDcUabvDoTw02bi3VgwIfoE/0cUG+mRnZt/yyC8SafB84WfZ89wvX9gCWqCH7a8QuO0CYOxysMJgQ63blxIWbDDBMDKgHalM7Q8da2TEzjQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772805252; c=relaxed/simple; bh=QK20wJ7vAN6elUgA6Rrsu8MYEpvqGJelM3EQs+d5oYY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=I4M/NdjMGlI1Lufs/KnMLtuUbE3ymrV4Aq2S+zpIMi+fM/H52vGRojY+I9KVDx/qsZu+wWVmDmpyPskyahHp0P/FGpt4qbiWGSvuQ4nHUKYPqtzF33sReReMIUELr0yw1ctXljr76Oc9UzieCBd6nAiGBsKe+b+30WPwb5XkQsQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=fQlPkydE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="fQlPkydE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4927BC4CEF7; Fri, 6 Mar 2026 13:54:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1772805251; bh=QK20wJ7vAN6elUgA6Rrsu8MYEpvqGJelM3EQs+d5oYY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fQlPkydEjR6GZoL2byjlhrnRHmzJyIN1k34lQ3mWvimNYF6oU2ca5TObEUJigl9vx FK0OHsvuHUPM+xXxGqMnabjGP8hd/T2VUfzg9aLXwoR0Z40MDu06yLvogaJLnh2eQD s8ZK1P5m4XiXpADyC4WSY267MUWNqdM7EC5R3r9s= Date: Fri, 6 Mar 2026 14:54:08 +0100 From: Greg Kroah-Hartman To: Bartosz Golaszewski Cc: "Rafael J. Wysocki" , Danilo Krummrich , Shivendra Pratap , linux-arm-msm@vger.kernel.org, driver-core@lists.linux.dev, linux-kernel@vger.kernel.org, brgl@kernel.org Subject: Re: [PATCH RFT] driver core: faux: allow to set the firmware node for a faux device Message-ID: <2026030649-evacuate-emotion-422c@gregkh> References: <20260306-faux-dev-with-fwnode-v1-1-792a86a62530@oss.qualcomm.com> Precedence: bulk X-Mailing-List: driver-core@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260306-faux-dev-with-fwnode-v1-1-792a86a62530@oss.qualcomm.com> On Fri, Mar 06, 2026 at 02:45:56PM +0100, Bartosz Golaszewski wrote: > Add a new variant of faux_device_create() taking a firmware node handle > as argument and attaching it to the created faux device. This allows > users to define and read device properties using the standard property > accessors. Why would a faux device have firmware backing? Doesn't that mean it should be a platform device? > While at it: order includes in faux.c alphabetically for easier > maintenance. Hint, that should be a separate patch, and is never something that I enforce or require in .c files I maintain :) > Signed-off-by: Bartosz Golaszewski > --- > Hi Shivendra et al! > > This patch is related to my response to your reboot-mode patch[1]. > > You should be able to use the new function like: > > faux_device_create_full("psci-reboot-mode", NULL, NULL, NULL, of_fwnode_handle(np)); What is the fwnode handle here for? Why is it required at all? What resources are involved that would want this? thanks, greg k-h