Re: [PATCH] rust: ACPI: fix missing match data for PRP0001

Markus Probst
2026-04-01T18:46:46Z

[-- Attachment #1: Type: text/plain, Size: 824 bytes --]

On Wed, 2026-04-01 at 20:32 +0200, Greg Kroah-Hartman wrote:
> On Wed, Apr 01, 2026 at 02:06:25PM +0000, Markus Probst wrote:
> > Export `acpi_of_match_device` function and use it to match the of device
> > table against ACPI PRP0001 in Rust.
> >
> > This fixes id_info being None on ACPI PRP0001 devices.
> >
> > Using `device_get_match_data` is not possible, because Rust stores an
> > index in the of device id instead of a data pointer.
>
> I'm confused, why are we open-coding this in the rust layer? What do we
> need to change in the C side to make both layers be able to call the
> same function instead?
No commit message I have seen has explained why it was done this way. I
don't think we would need to change anything on the C side.

Thanks
- Markus Probst

>
> thanks,
>
> greg k-h

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 870 bytes --]