From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0E843E0247 for ; Fri, 8 May 2026 12:39:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778243972; cv=none; b=hPRa+rO+pQ2g3f7XHTffzmTV6sBR0lrM/7BmE2tVTGdYpWfka7peQs0fwodS363fvQGfNY3IhHODdiyZT82EsB67WRlJ2E71YXFg46Bm9pXoeS38bBT6BBThct+cBuOx+8OuXwkYvGWAERA+z/Qx1d5tweqW5fcY0bRegXBZj3o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778243972; c=relaxed/simple; bh=sXCjyMUZo4URsDmSQZ9Vo8gr83eBVJtEB1jj+SkQaL0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jTewG++i5RYrlHhyItdeobiPI9zBL/KhdV/NGpi2XQ4swJg17kOY6w8ua6vRfjHbavKOca/T+EZChuQxeFwVE5Ni/EvUlOTx3mX33O2+xR9S9piACKprsy0MewFOuod73gjpQrV8FiyKuy9q9n/lhsdc4VyUrcVLBMSIaqsjrlw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=KXIGby47; arc=none smtp.client-ip=209.85.208.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KXIGby47" Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-38e8292423fso14213881fa.0 for ; Fri, 08 May 2026 05:39:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778243965; x=1778848765; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/rXkI/5pJxJgQUkPnjmS1Ch3OvikdB3cgLvtk24pgs8=; b=KXIGby47lWqcjHWTIPsVOzrRwbsE3xdUbntCpHJBUxKBUMPabx6v1Uqz06cKOtf5Cw Ivokrjo36eL3leknXFJPZN6GD1i23ZR9PiyP1Y4YW045obQE0QMwbbshJPuCBTSdeh42 OVx4MpCJmcK/aWYBUrkBJCOH3zR2vkZXcyoHkpE5WzzVrLINshS8qWRpE9WjpQDL5eTh 1GYyEstvio96YMUoDG4qaA1gNJQhr09euAeWIJUmhUXMXx7ylNsA9+N/Gc6/wRBx0odC j9/1G2ruoCCkE/gZ4bxluLni+zKPRoWfFqMjzMlJpID76MO4lQM1Oll03XoIJkXgHiHy KGpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778243965; x=1778848765; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/rXkI/5pJxJgQUkPnjmS1Ch3OvikdB3cgLvtk24pgs8=; b=TDhMwHAdgNcYZjVfX7i4H9/SPcGJ/zJDOeS701+JHOmaCC4wDOswO99CCOssuipJ05 ag1S7qucQ3tSEL1m7v6nCVQmkQCf6h/hPtANHslcgts9T5cr2NLeVyqrr/iUPG21dkU4 CiJNrCjS87EwJvNkZRQb95J7ZVQCXaR9IrtEi0Ob2cC8uySuhathj4yNgkt8RqdKle7B i50WLlf86yX1HUC8X1SS3gEhMP+jPZVRYlq5l1sqRXYEhC5f9Txmf0g9eJkEOmZofzQ/ 0WPGfIxVWsgp6qrepKCd6WwDJ32XyxtLmKNfQIJQdCOVxOQuzviVdSZSXckb5aQbwWf/ WULg== X-Forwarded-Encrypted: i=1; AFNElJ8kXWZ3FT8dZ4S5heh5gnbCvVRR2PwHLMiTWhj0QxE/PvD42wsm5z1dHvTSfg+BCM2Ld0OYA6A6CxVXNg==@lists.linux.dev X-Gm-Message-State: AOJu0YwR8cUv/0iOwl9SBIU0SedOErDR14i+z8ncGZRwByU9MDhPCUWe nzJKdNp9YvzDfm9a+BkiTk5vU2kabsAd8L0vGnZNpLxOkv3stCamurlVUxt2E1L3LmY= X-Gm-Gg: Acq92OFbwEe5XaENUQdPJzkli5yviqfTe5zXKj1V0d504OO08ULqtZY/Iq1qwTAvNi0 edNssBmbSU+rhR+K7hUxS7OIoOfZ2SGtbu+VNyGhx+uBBcpmS7dp9fUZRegsOQEIa6783BtP0Z0 3Xyd/c/MSGzEeGH8YOixbhscz66sIqH2OThbMMvDXj7IvjlzVJRogxaoQeYySyWoqP1xmb4QKNS VU54TjUtF0dyI5jWKKLIgl2ljGnkOtxsrl43f/Nr/Vu4ay1hl/zNVWNvIzd5XQWQJW3x7nlFK9Y LoI6ljL0DvJ1HC+eEO1pZGRXsIajki9JIlHLqBPpFdMPl/kLQDvPAPeKr9xBi98oaoQO6jbelqo 6TtZPZsOJaxbH8Fw6poFq2kUI8qgn7al+JVPcDODD/gb7+uNm8p7A7thaHZJTe4PU5mxqe6aLsF kKC2f72IopI/zO3KaMz3grAaQXE3SUCI1Xu5eMcO+ORnMvH71xG10loSN3FNK3GvwsB+sYP0fE X-Received: by 2002:a05:6512:3f1a:b0:5a3:cc81:eff3 with SMTP id 2adb3069b0e04-5a887cdff2emr4839959e87.26.1778243964852; Fri, 08 May 2026 05:39:24 -0700 (PDT) Received: from uffe-tuxpro14.. (h-178-174-189-39.A498.priv.bahnhof.se. [178.174.189.39]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-393f5f5fcc7sm4569621fa.18.2026.05.08.05.39.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 05:39:24 -0700 (PDT) From: Ulf Hansson To: Danilo Krummrich , Saravana Kannan , "Rafael J . Wysocki" , Greg Kroah-Hartman , driver-core@lists.linux.dev, linux-pm@vger.kernel.org Cc: Sudeep Holla , Cristian Marussi , Kevin Hilman , Stephen Boyd , Marek Szyprowski , Bjorn Andersson , Abel Vesa , Peng Fan , Tomi Valkeinen , Maulik Shah , Konrad Dybcio , Thierry Reding , Jonathan Hunter , Geert Uytterhoeven , Dmitry Baryshkov , Ulf Hansson , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 06/13] pmdomain: core: Add initial fine grained sync_state support Date: Fri, 8 May 2026 14:38:55 +0200 Message-ID: <20260508123910.114273-7-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260508123910.114273-1-ulf.hansson@linaro.org> References: <20260508123910.114273-1-ulf.hansson@linaro.org> Precedence: bulk X-Mailing-List: driver-core@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A onecell (#power-domain-cells = <1 or 2>; in DT) power domain provider typically provides multiple independent power domains, each with their own corresponding consumers. In these cases we have to wait for all consumers for all the provided power domains before the ->sync_state() callback gets called for the supplier. In a first step to improve this, let's implement support for fine grained sync_state support a per genpd basis by using the ->queue_sync_state() callback. To take step by step, let's initially limit the improvement to the internal genpd provider driver and to its corresponding genpd devices for onecell providers. Signed-off-by: Ulf Hansson --- Changes in v3: - Addressed some cosmetic comments from Geert. --- drivers/pmdomain/core.c | 124 ++++++++++++++++++++++++++++++++++++++ include/linux/pm_domain.h | 1 + 2 files changed, 125 insertions(+) diff --git a/drivers/pmdomain/core.c b/drivers/pmdomain/core.c index ad57846f02a3..c01a9a96e5c2 100644 --- a/drivers/pmdomain/core.c +++ b/drivers/pmdomain/core.c @@ -2699,6 +2699,119 @@ static struct generic_pm_domain *genpd_get_from_provider( return genpd; } +static bool genpd_should_wait_for_consumer(struct device_node *np) +{ + struct generic_pm_domain *genpd; + bool should_wait = false; + + mutex_lock(&gpd_list_lock); + list_for_each_entry(genpd, &gpd_list, gpd_list_node) { + if (genpd->provider == of_fwnode_handle(np)) { + genpd_lock(genpd); + + /* Clear the previous state before reevaluating. */ + genpd->wait_for_consumer = false; + + /* + * Unless there is at least one genpd for the provider + * that is being kept powered-on, we don't have to care + * about waiting for consumers. + */ + if (genpd->stay_on) + should_wait = true; + + genpd_unlock(genpd); + } + } + mutex_unlock(&gpd_list_lock); + + return should_wait; +} + +static void genpd_parse_for_consumer(struct device_node *sup, + struct device_node *con) +{ + struct generic_pm_domain *genpd; + + for (unsigned int i = 0; ; i++) { + struct of_phandle_args pd_args; + + if (of_parse_phandle_with_args(con, "power-domains", + "#power-domain-cells", + i, &pd_args)) + break; + + /* + * The phandle must correspond to the supplier's genpd provider + * to be relevant else let's move to the next index. + */ + if (sup != pd_args.np) { + of_node_put(pd_args.np); + continue; + } + + mutex_lock(&gpd_list_lock); + genpd = genpd_get_from_provider(&pd_args); + if (!IS_ERR(genpd)) { + genpd_lock(genpd); + genpd->wait_for_consumer = true; + genpd_unlock(genpd); + } + mutex_unlock(&gpd_list_lock); + + of_node_put(pd_args.np); + } +} + +static void _genpd_queue_sync_state(struct device_node *np) +{ + struct generic_pm_domain *genpd; + + mutex_lock(&gpd_list_lock); + list_for_each_entry(genpd, &gpd_list, gpd_list_node) { + if (genpd->provider == of_fwnode_handle(np)) { + genpd_lock(genpd); + if (genpd->stay_on && !genpd->wait_for_consumer) { + genpd->stay_on = false; + genpd_queue_power_off_work(genpd); + } + genpd_unlock(genpd); + } + } + mutex_unlock(&gpd_list_lock); +} + +static void genpd_queue_sync_state(struct device *dev) +{ + struct device_node *np = dev->of_node; + struct device_link *link; + + if (!genpd_should_wait_for_consumer(np)) + return; + + list_for_each_entry(link, &dev->links.consumers, s_node) { + struct device *consumer = link->consumer; + + if (!device_link_test(link, DL_FLAG_MANAGED)) + continue; + + if (link->status == DL_STATE_ACTIVE) + continue; + + if (!consumer->of_node) + continue; + + /* + * A consumer device has not been probed yet. Let's parse its + * device node for the power-domains property, to find out the + * genpds it may belong to and then prevent sync state for them. + */ + genpd_parse_for_consumer(np, consumer->of_node); + } + + _genpd_queue_sync_state(np); +} + static void genpd_sync_state(struct device *dev) { return of_genpd_sync_state(dev->of_node); @@ -3531,6 +3644,16 @@ static int genpd_provider_probe(struct device *dev) return 0; } +static void genpd_provider_queue_sync_state(struct device *dev) +{ + struct generic_pm_domain *genpd = container_of(dev, struct generic_pm_domain, dev); + + if (genpd->sync_state != GENPD_SYNC_STATE_ONECELL) + return; + + genpd_queue_sync_state(dev); +} + static void genpd_provider_sync_state(struct device *dev) { struct generic_pm_domain *genpd = container_of(dev, struct generic_pm_domain, dev); @@ -3559,6 +3682,7 @@ static struct device_driver genpd_provider_drv = { .name = "genpd_provider", .bus = &genpd_provider_bus_type, .probe = genpd_provider_probe, + .queue_sync_state = genpd_provider_queue_sync_state, .sync_state = genpd_provider_sync_state, .suppress_bind_attrs = true, }; diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h index b299dc0128d6..7aa49721cde5 100644 --- a/include/linux/pm_domain.h +++ b/include/linux/pm_domain.h @@ -215,6 +215,7 @@ struct generic_pm_domain { cpumask_var_t cpus; /* A cpumask of the attached CPUs */ bool synced_poweroff; /* A consumer needs a synced poweroff */ bool stay_on; /* Stay powered-on during boot. */ + bool wait_for_consumer; /* Consumers awaits to be probed. */ enum genpd_sync_state sync_state; /* How sync_state is managed. */ int (*power_off)(struct generic_pm_domain *domain); int (*power_on)(struct generic_pm_domain *domain); -- 2.43.0