From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 687D8383993 for ; Thu, 21 May 2026 08:37:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779352634; cv=none; b=ExroFxu2LpLQhJQy83R8v/eyMYThGT+YD8k4n4FIQY2pay0L7m19w6M/882p8Gaz34OfEdytifJ96si/GQK66ZYSLHyzBM8fwcSBAyAM4Ygw9mgAxVyZ5a5Pe8uW+rKSpmuOQ04h/GEL3BP89Nay+29FXEYlvPdXzdtZosHurtA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779352634; c=relaxed/simple; bh=/aRY/vb3/hIBTIMJYLxhoggrOSD5XZpzRvD5IEGaQ84=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=om2zky5hT+IzfIYWOrw2QTv15B0ntv26rsxZhIt1LZeJj3rMpXZ11+a4o6UIb0TLO3G8dIYuwkdRQdoDqiC71hoITONxt5ElBMLsH9MA7WjeMn0uKyILaGXpoitel8h8CjKaFRvq7vivlGJFV1PjXX/Bour1Pr1e5DXSztiaoHE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oHrTiXeE; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Sc/kRbZB; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oHrTiXeE"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Sc/kRbZB" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64L8Jli0748564 for ; Thu, 21 May 2026 08:37:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ukktCil6qFV5J1LkkLCVMIGTbGIgPkyHII6gX5uRxIU=; b=oHrTiXeEYw0WRHRT 0JryuBJBVPGqSxjyOTxM5WpWR6iIX+t5Ehvvw7Ijy/GBhhIDg6CRp4j3QlEKLHrd +T96al+7FsYIjjP2jU6FOexSof2OZMQ8rNPgA0pbm1sVXGeUZU2LmQlLaiX36fx3 MG+nBBELBSvdKBlncwtRnvz10SEQ3fEi44Jsy2GFv/ny2/9kv77+p55hQ3FGnrzQ IKaYfJHP4+j/gv2GVgK5+Euq6Esk471OF7JFruDCfx2cLtA7CQELRBGCRGfJBFlZ KngEWPif/BD7w3A+cd5xrKALQ79BP1Zurh4FsssoVkSxxz+bgCaXm7XUBHfW97zx +2sblA== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e9fb6kj3x-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 21 May 2026 08:37:11 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-5104b861649so230841161cf.1 for ; Thu, 21 May 2026 01:37:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779352630; x=1779957430; darn=lists.linux.dev; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ukktCil6qFV5J1LkkLCVMIGTbGIgPkyHII6gX5uRxIU=; b=Sc/kRbZB2Sio4gHITvhml8G9vK6dnMssPLsOxNDdCnDnCJbA5cUatgKRQjrYNed3Tz WGEIwxSGUv51HSNtj2gZwRSbMKdvBYIvqYft3iEzAf30s70r6dNyrVqIIEGCKANHJuU/ ezxOjq7AeKLJqVHg8v8a20AceaFNVL0Xs/vmcI7G41S92+NmqOM5Z/QwFNUP4beTcSG8 HDcO7R2t9WpES+G7YPchsUVD/utARvv0gSzoycuwGb7FD27OY9TB8FbhtNlhbCAAy1CC IXj4ipaptE2xjtllJ5la2wmyBq3vrSEDHEbzbIKnkcfGnvd4x1sD0sQHwCFvvy0Z3Hjm q8EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779352630; x=1779957430; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ukktCil6qFV5J1LkkLCVMIGTbGIgPkyHII6gX5uRxIU=; b=GjFn6qmca1BkPaX0gSSVXwVJ84XPlgQyGVS8O2JsxG1Wl11zAPZ5ULOJDVuhzyyszK EZ2suf4n3GwXVBnuRk4gQCIiJvmG+Lo6O0KH4zRGl8JzMwPe5saJnpSjmOw331i0V4Pe OtaBhZv+Fxh7AJTmuZGxZ300vmBxbJ5DyS3v96T7u5R5vh2wmqu3RBOY9JwikccV7YoB 7kE3ZkOFHVIKsgNsSm/I35s6LL55kOKypFMNVR2ej5PyH5GTwsq15vyrtK8uJnI2/5kT bpxz/HfSgMQ132+Z10GH6sHvftgMQz0fSfKo7HQ0mD2cRUSb4xKMGTl47c27CLR3MPyK WqLg== X-Forwarded-Encrypted: i=1; AFNElJ+PnPmIO3jg6TZuZWL3UQxWPL556yVKznpB3zlS5x+MXBweMcl57fN0R8r1mYZJBiKVQuxqel1XxHRyeA==@lists.linux.dev X-Gm-Message-State: AOJu0Yys6kLc6Q8CbeOJ3dgMqRduOu78vQddOBEjOAK0eMxRi/pFVPmp I/wj8c0efX3fKzyouNojNL/Qbm5/bG2LSoj7iGSdv5USOmumVgURfwoKv2wj+5w9uug0EXgnBex x72fbcYEnSw5iHkQrQCHVOS7HxF3SWQRloA3phB/FTIf3EBRL9K7H+zwVCnqu9YahSQ== X-Gm-Gg: Acq92OHyTTEmePH4FzTX+1dHwTBh6780MIWOH6CKPS6I7Wmq7xUiPD/Hl37ddM1+2bH LZ7m/FadRpkjepKY3WpIgEhomHec+eB6hZL1rkLeq0jMRfn+tjdPrXyInNmGNJoR+iUKLkVmHFo 5HDAzEmvQZ5/APMOa9HII8mLYz78LFizbz/4MvsIctVcrQ6M/lpXoRBU8rw8iVuMSXMzeREBJzq 3M6TTkGVdaH3eJBd6+kjk8sIJyBsOlZtLzNa+R8WRpQrxsGXCLledIHQfg67/rW0mqUnqchd/Xy auvcHN+71ECThEk64py1arfMVfusMH9MRz1zVrHHBfM/Z7wqATzwgQDO7aa7b7GOCpe/U0q3phN 0GAJWhr9OsBRY7XfrDXRzu82s1riHM/MNi0See7Baeaa/lnGucdA= X-Received: by 2002:ac8:5f47:0:b0:50f:bcfe:e8e0 with SMTP id d75a77b69052e-516c5477e17mr25148191cf.13.1779352630349; Thu, 21 May 2026 01:37:10 -0700 (PDT) X-Received: by 2002:ac8:5f47:0:b0:50f:bcfe:e8e0 with SMTP id d75a77b69052e-516c5477e17mr25147771cf.13.1779352629775; Thu, 21 May 2026 01:37:09 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:bb10:ae82:b7c3:d15a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4903caede9fsm10502405e9.14.2026.05.21.01.37.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 01:37:09 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 21 May 2026 10:36:24 +0200 Subject: [PATCH 01/23] mfd: tps6586x: fix OF node refcount Precedence: bulk X-Mailing-List: driver-core@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260521-pdev-fwnode-ref-v1-1-88c324a1b8d2@oss.qualcomm.com> References: <20260521-pdev-fwnode-ref-v1-0-88c324a1b8d2@oss.qualcomm.com> In-Reply-To: <20260521-pdev-fwnode-ref-v1-0-88c324a1b8d2@oss.qualcomm.com> To: Lee Jones , Mark Brown , Thierry Reding , Sebastian Hesselbarth , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Srinivas Kandagatla , Greg Kroah-Hartman , Vinod Koul , "Rafael J. Wysocki" , Danilo Krummrich , Rob Herring , Saravana Kannan , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Andi Shyti , Andy Shevchenko , Joerg Roedel , Will Deacon , Robin Murphy , Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Ulf Hansson , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Matthew Brost , =?utf-8?q?Thomas_Hellstr=C3=B6m?= , Rodrigo Vivi , David Airlie , Simona Vetter , Peter Chen , Paul Cercueil , Bin Liu , Philipp Zabel , Maximilian Luz , Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Krzysztof Kozlowski , Benjamin Herrenschmidt Cc: brgl@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, driver-core@lists.linux.dev, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-i2c@vger.kernel.org, iommu@lists.linux.dev, linux-pm@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-usb@vger.kernel.org, linux-mips@vger.kernel.org, platform-driver-x86@vger.kernel.org, Bartosz Golaszewski , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1267; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=/aRY/vb3/hIBTIMJYLxhoggrOSD5XZpzRvD5IEGaQ84=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBqDsQdlJ6Gw9yankDCBt9FSOgN2Xq2huOUHVWq2 3Mrh55a7QuJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCag7EHQAKCRAFnS7L/zaE w8nQD/4loqIyi5npUB0pcQ0If2+y1OYKJ5I3fRWNoD+DI2qAw7RvRg8s8P8r3CAXndoCmybnGcM 5m1IEHBWc6qOHq0mh/OkumNuSy1hZr2x107TEzMLDEBT9H1M+UZPMvVEe/aPC79WmowHUUF9TuQ GP5vrZ4LpMcgS4O084BJEASA5nzY7uelq72L6TarvzcMxyS5TjdWC6urxNMBWCi8R8jZzxGqvRA QLmH/AE/4+uNzpnvf0hKdeOVPd6gbvE0i6b80v+PHjuoXIi/p1jUehPLgdPjIZdjebdM2TlVbq/ P+9OrZKLw4SE+WRjUcN+UTnJ9tUAy0e3et+WqqPo3jUL89kKacqheQ1e2WkNXwGyi4uVuDNHzDN EvguWALMcMSEtupOOdXvE7nDWlVjqiY+3PMQILeq7NqMN/sFl6eCYnlTfomjSu+m/Em7L8Wq1ZD tFuwrfOg2BDxS7mr/FYdjg8+gBUNSZIL7MNlfzoXNWRl0rfwXF4Z8tdBbpD/g0zNTdhf5OZgAls IYx3BCJ1rkEwyphre8P9P953xIKshhJ4v9FpWul23QHiCYgcx00qs38wMQFaQ+tcpndPkewXAjf F/6YGVrg7Nc4nlGb9xf9H82vk+Y3HR5kALW1hO/kymu1NlKKvAubzUwld/OTrCD9MzeUjTa2CC3 KvJGbKuQmkv3QvA== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Authority-Analysis: v=2.4 cv=do/rzVg4 c=1 sm=1 tr=0 ts=6a0ec437 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=4gvjGX-radYMG0rQGxsA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-ORIG-GUID: qKF6JwrdCOe2jqPjwj_a3mENzXBaR-Yy X-Proofpoint-GUID: qKF6JwrdCOe2jqPjwj_a3mENzXBaR-Yy X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIxMDA4MyBTYWx0ZWRfX3EmXEL9fXrc1 tP67cmaz1/m26IJZggFpU4o68BI0azfw0vDBkWv2UsQhswZw9hnfAb9QJV82Z1ooUwwsHxwq++m APuH03n5slSDVzmac7FK9k316XeAY4hGFXtBCbM4A9omlTHe5Gi4CfCXPm42jqqGd52SVJlmsCf hHZkLGu3+OyacloWIPZaWlalmdC79ZGAzNXs90nADhoPWTHEDfXbZqUiMqE7sGWUgBSdEAx8H+i mbQUHSXv5aKEdJ+Ud33Bp4oeVUtVejyYzZ8EpPln8VWnvOq6AE/Gwrh3FozC87HQtqJ1q1qrZ/C bHIBWze/cw25ynu/R9XmI51vGiwZqnoCKOP5RrQ0lfMjAhVt+kmoB3J9h+28VORHntkS3ZSx/UV iom1eDIA8uTfZjmTvJACidVXA5mptRRnUKPs9jDjJWnw94KMMXESEYJh5EzY8DfL1teHN61ucq3 qZdcgj1mV4sUsTKVMNg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-21_01,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 lowpriorityscore=0 bulkscore=0 suspectscore=0 clxscore=1015 spamscore=0 malwarescore=0 phishscore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605210083 Platform devices created with platform_device_alloc() call platform_device_release() when the last reference to the device's kobject is dropped. This function calls of_node_put() unconditionally. This works fine for devices created with platform_device_register_full() but users of the split approach (platform_device_alloc() + platform_device_add()) must bump the reference of the of_node they assign manually. Add the missing call to of_node_get(). Cc: stable@vger.kernel.org Fixes: 62f6b0879304 ("tps6586x: Add device tree support") Signed-off-by: Bartosz Golaszewski --- drivers/mfd/tps6586x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/tps6586x.c b/drivers/mfd/tps6586x.c index 8d5fe2b60bfa550d0aad30acd0820fac354028ac..f5f805446603315ba76ce1fc501c908f1cec0d16 100644 --- a/drivers/mfd/tps6586x.c +++ b/drivers/mfd/tps6586x.c @@ -397,7 +397,7 @@ static int tps6586x_add_subdevs(struct tps6586x *tps6586x, pdev->dev.parent = tps6586x->dev; pdev->dev.platform_data = subdev->platform_data; - pdev->dev.of_node = subdev->of_node; + pdev->dev.of_node = of_node_get(subdev->of_node); ret = platform_device_add(pdev); if (ret) { -- 2.47.3