Linux driver-core infrastructure
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Danilo Krummrich <dakr@kernel.org>
Cc: rafael@kernel.org, driver-core@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] driver core: Fix missing jiffies conversion in deferred_probe_extend_timeout()
Date: Mon, 25 May 2026 08:01:27 +0200	[thread overview]
Message-ID: <2026052517-sandstorm-provider-640d@gregkh> (raw)
In-Reply-To: <20260525012340.3860581-1-dakr@kernel.org>

On Mon, May 25, 2026 at 03:23:21AM +0200, Danilo Krummrich wrote:
> mod_delayed_work() takes jiffies, not seconds. Thus, restore the dropped
> conversion.
> 
> While at it, fix incorrect indentation.
> 
> Fixes: 1137838865bf ("driver core: Use mod_delayed_work to prevent lost deferred probe work")
> Signed-off-by: Danilo Krummrich <dakr@kernel.org>
> ---
>  drivers/base/dd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/base/dd.c b/drivers/base/dd.c
> index 172a02a438a2..bebb43acc132 100644
> --- a/drivers/base/dd.c
> +++ b/drivers/base/dd.c
> @@ -324,7 +324,7 @@ void deferred_probe_extend_timeout(void)
>  	 * start a new one.
>  	 */
>  	if (mod_delayed_work(system_wq, &deferred_probe_timeout_work,
> -						 driver_deferred_probe_timeout))
> +			     secs_to_jiffies(driver_deferred_probe_timeout)))
>  		pr_debug("Extended deferred probe timeout by %d secs\n",
>  					driver_deferred_probe_timeout);
>  }
> 
> base-commit: 56785dcb2ef6d3cff82ac33f2e34db94377416a3
> -- 
> 2.54.0
> 
> 

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

  parent reply	other threads:[~2026-05-25  6:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-25  1:23 [PATCH 1/2] driver core: Fix missing jiffies conversion in deferred_probe_extend_timeout() Danilo Krummrich
2026-05-25  1:23 ` [PATCH 2/2] driver core: Guard deferred probe timeout extension with delayed_work_pending() Danilo Krummrich
2026-05-25  6:01   ` Greg KH
2026-05-26 12:51   ` Geert Uytterhoeven
2026-05-25  6:01 ` Greg KH [this message]
2026-05-26 12:49 ` [PATCH 1/2] driver core: Fix missing jiffies conversion in deferred_probe_extend_timeout() Geert Uytterhoeven
2026-05-26 14:58 ` Danilo Krummrich
  -- strict thread matches above, loose matches on Subject: below --
2026-05-26 12:24 Biju Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026052517-sandstorm-provider-640d@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=dakr@kernel.org \
    --cc=driver-core@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox