From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11013016.outbound.protection.outlook.com [40.107.162.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 251F044D01D for ; Wed, 3 Jun 2026 08:41:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.162.16 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780476095; cv=fail; b=l+/yyq1w3SkV4Y0l7dK28vxNFqZ8LoErkx+KBUOwYrzjJgJzBM7UjLI6CeA23dY9TSJ/ualXxb8IUfwyxBfwNC+nobihtv8eR8yj4OodU7WVpmyvo8in1rhHh19uBU7fzhcdTS69ua66fTDud9cCXXoFhAxeBpDp3NgV8/ZBWLE= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780476095; c=relaxed/simple; bh=jdpdd/mZrd4UoFAzOrYTod13JK+mjw4LO966eGJsBzs=; h=From:Subject:Date:Message-Id:Content-Type:To:Cc:MIME-Version; b=MIsbZJpRqZMT6B8pgGPCWGZcGoBfwlR221Z1pSx4Y/CZ0h5XtYQQ//idd7cpwRfl7AhTG/JHOHKq0yitk9IazHMwuZOhRGnaXpaUFQm//0P5dfJO9qSOvuYIBxq773AbnH4x1H7qtPs5eK8J58GYyLuoNrR5e3gcGzukXdVZXh0= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=Ylk9yKwp; arc=fail smtp.client-ip=40.107.162.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="Ylk9yKwp" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=o4jdeNuzx+4ssS8VmunO1ni/ocz5ay7nYbyqze8wiV2Jwf/K+xRUSZneyK1qE3QJVy0BWYRUbAxX/ne7QRNVq6LVL+Fi0iPIF6QWpo1qm1xCsJbUK+CHH2x+kXkgNnKLbX+nRYvIfeSRBDZ71f79rYwizBGxMCCkt2/o4nzxW24euLMxWVPoHuaUyL3s5gxCO+2NCWkfPn92VqFNdLqTJIjogM5FcMLT0QmRVCzetjB+HvHJqLkFqwFoaSZK3boRiM61ZKR/S4kpM+W8qf7R4LtpTE6HMJkSVEwQDkLQaF7QrsRuK5UbzmQdu/9ZQSLkv2ur3LTfokElvXpz2uhpcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Qk1Nu+g3Sju6e+mraphLhiuegPw9x0acWj9g6HoOvFE=; b=Y0uLsEYFtczSIUUwb0W2k9UgTmlFkjSWT9yxNobKj+WjYM9EFdmrdYDzEB3UbZlqUikUz2Wgr6nxPsDtFmF9oVerZeg9g6/kG6bgx/DjevTRAj6WrF2lGXMAILdPvt9DqgAj0aEC0/UVrhyQbnBRac7FrKe33sWS9wzrZBJOer6zpVyL2H1TXtHubeidtV60peUfgf298V8Qfa5UfjbB7OaOmlS19xSgePOluRkuoQlRSTTyatFb5x/GIfUj8LejB3P+nOfeJ3kkzIqzvvs+eWS5FjbwsaXsQpQt/QvdrBzQLYP4HIAm36OiIQBhXzx7YOJ/bzxqY/u36gfklM5V6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qk1Nu+g3Sju6e+mraphLhiuegPw9x0acWj9g6HoOvFE=; b=Ylk9yKwpEacpFokOXozxQXGmihhrlnu2fmFsLgf0AbvILTF1G9savHiAwLhy+4i1ce9keqYhHuQ0Mn/SR6+FAQNs1o4AaV73MIFIRFTrt5pVo+u6iWyRrPkJh6RO6sCAV0dBCuqHhMZ5ZpBfuEh6BDn2cs/c7eGMTI3RUGsudylV4kbjMHVzPAxn0Xy+deSbg3JryQcb2VJKAVnQPWL6M/IpHq2JI0W9VL0VrmJtw5aHn0vhe/G0y+FawEqdWli195g6ieLIS08l761tjIFMTCh+Q8jR1vSNjqdp3nF7LNu3vem83IJxd5IZaQcCMgQYkT83I6XbrikTEKEyM8RlJQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB9422.eurprd04.prod.outlook.com (2603:10a6:102:2b4::21) by GV4PR04MB11902.eurprd04.prod.outlook.com (2603:10a6:150:2e6::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.7; Wed, 3 Jun 2026 08:41:27 +0000 Received: from PAXPR04MB9422.eurprd04.prod.outlook.com ([fe80::54e:28bf:aa85:d25d]) by PAXPR04MB9422.eurprd04.prod.outlook.com ([fe80::54e:28bf:aa85:d25d%4]) with mapi id 15.21.0071.015; Wed, 3 Jun 2026 08:41:27 +0000 From: Xu Yang Subject: [PATCH v2 0/2] device property: fix child iteration issues with secondary fwnodes Date: Wed, 03 Jun 2026 16:44:30 +0800 Message-Id: <20260603-fixes_fwnode_iteration-v2-0-0ae381f8b7b9@nxp.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAG7pH2oC/4WNQQ6DIBBFr2JmXRoYIyld9R7GGNShzqJgwFAb4 91LvUCX7+e//3dIFJkS3KsdImVOHHwBvFQwztY/SfBUGFCilg02wvFGqXdvHybqeaVo16KIwTq N002rWjZQ5CXS2Sxu2xWeOa0hfs6frH7p38mshBRWoZG1G9Ao8/Dbch3DC7rjOL4dvTvFugAAA A== X-Change-ID: 20260525-fixes_fwnode_iteration-baf62d861305 To: Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Mauro Carvalho Chehab , Laurent Pinchart Cc: linux-acpi@vger.kernel.org, driver-core@lists.linux.dev, linux-kernel@vger.kernel.org, Xu Yang , stable@vger.kernel.org X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780476273; l=1671; i=xu.yang_2@nxp.com; s=20250815; h=from:subject:message-id; bh=jdpdd/mZrd4UoFAzOrYTod13JK+mjw4LO966eGJsBzs=; b=BugBVYIMGTDl2Qmxggc0b/HNyVGjmf9nxYb/3wJMe2Z/Td9MhX/dfdqK8KkxgngAxDr3ZpZz6 5iDCHdL+TapCY34jS5mFhE/ReNdyT0XFMq4qv4KA7aN1cifSu/bd2E6 X-Developer-Key: i=xu.yang_2@nxp.com; a=ed25519; pk=5c2HwftfKxFlMJboUe40+xawMtfnp5F8iEiv5CiKS+4= X-ClientProxiedBy: SI3PR01CA0005.apcprd01.prod.exchangelabs.com (2603:1096:4:296::13) To PAXPR04MB9422.eurprd04.prod.outlook.com (2603:10a6:102:2b4::21) Precedence: bulk X-Mailing-List: driver-core@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9422:EE_|GV4PR04MB11902:EE_ X-MS-Office365-Filtering-Correlation-Id: 39007991-4c68-4bed-4cb2-08dec14be664 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|19092799006|376014|7416014|6133799003|18002099003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: TfD7BVKTygomGA4j5LOLWywfNhn1/nqyB7+wFtUV3TS83l5jNV1aoOyv1dzuc6lP/HuhvlphTquSrgcFvieixZVlO2uJVhDdAPxqy7SMP7YCzFbzSWU65nuLYoqxfTIuyt82tJIybQ6YmfZzbw83bosuXeVhqWUmOAAl0fNG01sjx6/Isu6n6HC0JL1Y5wLYRnYmvMGtnxX5nnKglG25CmFn24pAjxQlz1YjrfHpmf9WBQ0XpfSHd4oWqxcVXqx9lzoO63pmW2pR19RpLxs6zJPzaUXvuBh/v7v+PGgxymHg5/gtWdCRiwEA5n8/1LsUtzyWOjdM+LjiOgo/aDVscS+UUzM8OG8vTzedYnwd3emW9qsYZV0PkCCEIUbx/dg46sEk4m9r1Gju85LvmA33mozph4ZAAoIqwL+J+VDUipcGmqKKx7+ny0MEqBcYY7Vz+PImeSWWBXZTe0Fbs/ztqoCOmy9RznqauqfTzzcfSYVaXw3TtXFY2u8d4+2skmslIkdqCBwHIKv+Lvwr74LBRPH9Lomo5fHkKSKVnj1lVm8UX1mVXAT4oLH6M/ppY6KKDQaVdgP+umqpGo3MxfD+5lG2/9D+jGusK3khHVebwjRBzPdlgibnxwekHc75KxDOnCL7KM1mqWm+pWm9NomKr6DwxkucwC2DVmvzIVPQDc8avYvpnMU2LZ4IEal7RijEW3dzathXdTcUkGMBN76z5A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9422.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(19092799006)(376014)(7416014)(6133799003)(18002099003)(56012099006)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MmlaT1BCdWNLckxoY3pKMEhkSk53UFNqalZLL1lEMzhySWZjZXFuc3VEeDZV?= =?utf-8?B?YXVzcnh0VEFOa2xyeUdIMnVoSnptR2ZZNjdZZ0ZEVjJXcWZJMngwZk5qS2Y0?= =?utf-8?B?UFVidll2N0hmdUt4TDkwYTU4Z3VWQ01VekNoNlJEeDNIZmlBRDdiV1NuTzhB?= =?utf-8?B?UlFLMHBJSTZMSDBtdlpIcENTZCs1Y1RReEcvL0xaU29jekdVNllmSFZHOFJF?= =?utf-8?B?a1JZZXJCWHlNV1FyelY5UjE5TDdtcjRVY2lReStJUnpXRng4VVROZFB6K2NE?= =?utf-8?B?QVNlSE5ML2p2bU5IcFdhdlhZVVV5TEpoQ1BhYm9LemVaUW1ycFFGYW1nMW5Z?= =?utf-8?B?Y3hoaFJCZVVJNnpHUzY2ZGxoOG9LbkxIQTJqci9IbTlJMVpWU09nYkgySG93?= =?utf-8?B?QktJc0hjL3NUV2pIMDM3RW1jS0VsT3pVT3JvWmY1MTZWdGNXSVJXaW9XaXV1?= =?utf-8?B?OU1XV2c1cmhBclB1N0FWZHNKY1dJTzNsUzBjSVdpczg3UG1CaW1mRGthME5s?= =?utf-8?B?bVA4eHN2UTFRSTNBbDVLTGM1UUlENWViaWtGNkQ0UEYySXFPeThEdEVVRHNt?= =?utf-8?B?QlRGWnpJdCs0RHgzeEpSY0VDdFhlV3BDUEEwNC9iN0hJNVByT3VoOVRqV0U3?= =?utf-8?B?L1NaanJaWFExRjRQTVJ2M0MyZC9HV2tTWjVWbFkrTFYvMWtEMTAvd3FVZE4z?= =?utf-8?B?UnR2QmdMa0hEWWt3cXZNUWJybGYyaC9JaWhIOU9HbWtJSU9YSFhhRW41dUYv?= =?utf-8?B?NWpOK09naFFBbUtMam5penFzb3dmclpiVy8yYnNGYjFTellvS2VGcVcyekVP?= =?utf-8?B?MllzVGJSd0krS0FqbCs0UFhKTVkwYjEyLzBDV3RIMEFpZ2RENzNmZTdnb1Nm?= =?utf-8?B?YUVoRG1DWnFjZm1tQWk3MjV4NmZENThFWk9SaFh6aTNjTjlOQ3lwaGNFZElT?= =?utf-8?B?UDFRb0hSUFlNelduZHh0cWZrMDB5cDJTWjZ2K3p2N282UlplYmZJRkhzaEVz?= =?utf-8?B?QThxN3RWd1JyeTljQXp0Y04wYWxCOFFmWmxOQ0krTFJRR3lsQ3NjVllhS1Uv?= =?utf-8?B?cVZQbTFnc05CWVA5WFh6V2pCbFN5UGswWXJRNnRrNHY2TXhZZHZwRDQrZ0Z4?= =?utf-8?B?aCtCbjVCTGo3WFI0STE0N0dXY1RZOHFhVEV0RTUyc1NjOXUzaEsvNWw0b1Jv?= =?utf-8?B?V21HNTFJa0Y5cy9WT0d5ZWdxVHNFV2dDYlh2T01kQVFRY3dicWtwc3lyUEcz?= =?utf-8?B?U3ZNSkx6Yy9LOVhjZmZWTkQxdm5OVmRKOUZoUmNTbDZlZmllaCtiZnVtV1JF?= =?utf-8?B?dlA3ZFFwZUtJOTBWUlVxV1pFR092K280NGZRdS9NYUhDdk8xeXZwOHkzamsw?= =?utf-8?B?Wk05dVhwd01ETWE2eXBPczlzRzZYdWtuZTh1cG8waUhsMitxaVoyS08zK3FC?= =?utf-8?B?L0VnWi9BN21PWmlEY3hseDRCVkRDUXZhTlNTU2U2cUpxRXl6cUZtMFE0eHo4?= =?utf-8?B?RnU1QkYvbis5ZmRRc0JwQ1R5WUxycWwwUDBBVjBvYXJCT2RYMS90YXVxYkFi?= =?utf-8?B?elZMdHVMd3hJNDFCSDFOZGNnMDdPMnpLTUttSm5NTFBaTFRrUHBXSnhTOGgw?= =?utf-8?B?ZWhRRE9HZDREOFlrZGNPTWt5dzJXTTJXcE51VjRaZDFzNGRBLzdibFR4UnVY?= =?utf-8?B?S0FyY3prMjBrVklCaWlENlJjbG9WdUFORXBPOG8rQjl1NnY1WmdTcEhUUGZV?= =?utf-8?B?eS94OE9DWmFIM04rNmJPdXdJS0xaWDVBdnNKam9nZU5SbVFSbE0rNUZDakdX?= =?utf-8?B?MktPcjNzRWUrOEkycWdQY2JZUXMyMVBjYWhxbG8wZ1dDcnVCVldkMlRtYmVo?= =?utf-8?B?M21rSExXcStHM09vVkVrRGZhVXg0ZGtkb2xRYTJFa2pHL3VBV0dxdmVCdFVr?= =?utf-8?B?RVVTUGR4OVR2Ky81cXEwOGlyeElDZmw1SWtaVHo1Ti90NXBNOWpaMXUrdVVy?= =?utf-8?B?czJzazk0RGttNXl6U3Y4bUt2QzFzSkhUL01uck4yOGthdG8yVUxFUnJRY2xQ?= =?utf-8?B?WGpaWVhBOURyV2dZYzB0UlQ1d0ZNYUsvYXFHUmR2NmFVNjJwQmkxMVNoazRV?= =?utf-8?B?WDF0MHNIdGpDYnJFZVpUSU53WTdBU0gwNzJtQjVGVzA1K0pTbXIxVEpvM3d0?= =?utf-8?B?Z3QwRU5NV2R4ZVJNczNLd3pNTjIyMjN2U1RSbE9EOUNJMEJtajY0QVdQWmZo?= =?utf-8?B?RUV1bmJtbUEvVUN6cGZoWG9xSnp6blVKMjFDSm4xOVBPVVFOM2tDTHlacTVX?= =?utf-8?B?UTN1QUFCSmtkNSt6eTMzNEpDcnlSUzZLK1owdkNON1JTMTRDTTFHM1pIblJN?= =?utf-8?Q?eMRpcv1bjp2eBP+JbD13FRdEYs6Wf1HRcheXJ?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 39007991-4c68-4bed-4cb2-08dec14be664 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9422.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2026 08:41:26.9646 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QoolOU6aBhoV0FX19Opcz4vIKie5NSLN1IXekkYHx0iHUtyTrdWWb/y5Mu8VGPAZP3+oLgJ7VRCJuG7wDMe66C+onUUotcCHNBJGXeBxc+721kCLYNKBa9IF2hqoNZy+ X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV4PR04MB11902 This series fixes two issues in the fwnode child iteration logic when a secondary fwnode is present. The first patch addresses a refcount imbalance in software_node_get_next_child(). When a software node is used as a secondary fwnode, the iteration code may incorrectly decrement the refcount of child nodes that do not belong to the software node hierarchy. This results in refcount underflow and possible use-after-free. The second patch fixes an infinite loop in fwnode_for_each_child_node(), caused by improper handling of iteration state across primary and secondary fwnodes. When iterating over children from both primary and secondary fwnodes, the code may incorrectly resume iteration from the primary fwnode even when the current child belongs to the secondary, leading to repeated traversal and a loop. Both issues are triggered when mixing different fwnode types through the secondary mechanism, and stem from incorrect assumptions about ownership and traversal context of child nodes. --- Changes in v2: - use __free() to cleanup parent fwnode - Link to v1: https://lore.kernel.org/r/20260525-fixes_fwnode_iteration-v1-0-a12903fb2919@nxp.com --- Xu Yang (2): software node: fix refcount leak in software_node_get_next_child() device property: fix infinite loop in fwnode_for_each_child_node() drivers/base/property.c | 18 +++++++++++++++--- drivers/base/swnode.c | 14 +++++++------- 2 files changed, 22 insertions(+), 10 deletions(-) --- base-commit: b7bee4ca5688e30ca50fbc87b1b8f7eed7006c17 change-id: 20260525-fixes_fwnode_iteration-baf62d861305 Best regards, -- Xu Yang