From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5E2E3AF643 for ; Wed, 10 Jun 2026 08:41:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781080883; cv=none; b=Tj9sTLULhZsPOeEvxBCJm2r3NXEIhnI0LFRXGBT3cnd9uQtJPtqWBuUf1D5yWTxZ4Nsw3qen0maHheMn0yK9+S39B9Il7Wcq9JhR4ex41ErDqoXL12hG9k0zO7rWVRZFpaRYc1Psopp8nvx0NeaS/0Grm9uX9nctizxMXO5A7mE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781080883; c=relaxed/simple; bh=ZuOVxM6SCrtrNZ59Qzz16xkLgZG0V6ly6c5cBQo7Q3g=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JwEwNoqflgr9xSqWCL2T8X9cgsfGftNCEo/2yKspFV3CNBqT/8eBX2sg9Le1wVuzjLyVa/ogB3Bu1B7Je5yy49chs/b0LsVR4gEQvdi4o0t3NRREr0GpQJ+3nAIDJyzMcA7Xi28hKTal9vwb33R9tQbUAitStodCenC3b3z8LYE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=eFSoDraC; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="eFSoDraC" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2c0c3543590so43630825ad.2 for ; Wed, 10 Jun 2026 01:41:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1781080879; x=1781685679; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=t8gJIv7IXV+GGLqttV7BJHv8HtnJej0L7a6gfaEYMf4=; b=eFSoDraCYbosu3rmJaTNpnqIMYBT/M5bx53P2VNJpQK65uMmKFDQZBe93ljDtM/XlN oaTd45wpHANxPUf0iU9ChH/Ci7R3Qo2KDCSVuiVEhrTFcZlgGim3pGs+bsfkdxkfZyDo q7R60lvCfAVJ5VH2YsqtMltH9Rs0sDf4A1Pnk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781080879; x=1781685679; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=t8gJIv7IXV+GGLqttV7BJHv8HtnJej0L7a6gfaEYMf4=; b=DDgdFbPn/eSZ7q+dIsvjwFOT7bSGuytw3SlNty3Ort1eVdhEHXAQDtpW1tDEz7IjuH kUQc8j6uiXFw3/3d/bbhjtZ0wQ+dCdB3OH7P16/4k+YmdiCVSQEpF3gULcPCsT+hVRV4 Bcz7uAgPgIjOPVAt6D0MkR7ZkrlmoII6DbVycOZVKLW11Qen+R73lLal99xEuV+/WOMZ 8WHkBk+F3232WfqJltjlgEW5REXRfKIWfPdRMIclzDJ8UfNe8iHnOzcJegP27iCxc0Xl AJFlBAlzy4riyr2yvyk4W2vC+dgqGK2VVwPvLR/viJD4FIjb60dI7zfOv3d1lKj/adKf nq/A== X-Forwarded-Encrypted: i=1; AFNElJ+hcpbVl1Vf3TW1CVBzSFJosGmIPJ2Any1dElGw0IEgPv75hSbAIlNmkyObyPAdBrczg8cU9hlCgn3jjg==@lists.linux.dev X-Gm-Message-State: AOJu0Yym75jVNZ9iMVxrDO9tvoMrkEefuobbkVQtdui0s9Hgof/fMELG vTKgEiq2TnOVM4bcyF3U6znnrn54L/9btFKI9uRO7mOLTo2J14Z6Nrc4xC93ZUT+0g== X-Gm-Gg: Acq92OFVBkZfiORizNk1Y0h1Iznbv5ZSwO604N1WkfTAjT3dH9SFsi36Ot9hKK7Q8bu d7ifvl7xRmn2gGdFXotVjHaS9JQFmO/2rsEu/H65V9U5MjZK9Ip1V7fo82jg0jRqjiCfI2AlHqi rqX8zZ7kRKF0d5rAD0abt/z/u+XAw9W9UXky5yr21shfI7jxgVl0zWVeetVEEUa4oDvsI132tX0 hzaArH7aKqKE6rIjaakyBi69cift2282QYJoK6W3HzTsaCBiaATdqRJW6g2wWbK2lHz+1sAcZ9c UQaPfmP1er3c2SG1qPK4fhjc/kKtdvucNoiHBVwHUJrL6Fek1RiWH5eS3bJaQSemmG85r9hFCUb 9os7qSsoeXfkvmqQX4y+0wJeWNw/Zd1NmK1+V0Q32P6eL4zQvY0upIRUn8Dxy4rOzT6D8wNi39f edhmDzpQJd6MKNC9BHSEcrdo/ZwbBUdMExwN7QrkCRy3F3GWW04wk0XN4PChQCMugHaNkWptM2f yJavR8IGe2LxT9xgw== X-Received: by 2002:a17:903:1b67:b0:2c2:c0db:964a with SMTP id d9443c01a7336-2c2c0db9991mr33186765ad.26.1781080878941; Wed, 10 Jun 2026 01:41:18 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2a00:79e0:201d:8:3870:6325:16c:d35c]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c164f890b2sm239223725ad.26.2026.06.10.01.41.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 01:41:18 -0700 (PDT) From: Chen-Yu Tsai To: Bartosz Golaszewski , Greg Kroah-Hartman , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , "Rafael J. Wysocki" , Danilo Krummrich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno Cc: Alan Stern , Chen-Yu Tsai , linux-acpi@vger.kernel.org, driver-core@lists.linux.dev, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam Subject: [PATCH v2 00/16] arm64: mediatek: Add M.2 E-key slot on Chromebooks Date: Wed, 10 Jun 2026 16:40:34 +0800 Message-ID: <20260610084053.2059858-1-wenst@chromium.org> X-Mailer: git-send-email 2.54.0.1099.g489fc7bff1-goog Precedence: bulk X-Mailing-List: driver-core@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi everyone, This is v2 of my attempt at integrating the power sequencing API into the USB core to support the USB connection on M.2 E-key slots. M.2 E-key was enabled in v7.1-rc1 with just PCIe and UART supported [1]. Major changes since v1: - No longer adding the "index" parameter the power sequencing API - Switched from OF graph to fwnode graph APIs - Tie "port@" node to usb_port device, and use this device as consumer to acquire power sequencing descriptor - Power sequencing descriptor now only tied to USB 2.0 port to avoid double reference - Power sequencing state tracking added - Link to v1 https://lore.kernel.org/all/20260515090149.3169406-1-wenst@chromium.org/ The series is based on next-20260608. Patch 1 and 2 add new fwnode graph helpers. These are used by the patch 5 and 7, respectively. Patch 3 changes the power sequencing framework's Kconfig symbol from tristate to bool. This is needed as the USB core is bool. And since a later patch introduces power sequencing API usage to the USB core, the power sequencing framework cannot be built as a module anymore. This patch needs to go in with "usb: hub: Power on connected M.2 E-key connectors", or we will get allmodconfig build failures. Patch 4 reworks the USB hub driver to return the actual error code from hub_configure() in hub_probe(). This is needed in the next patch to correctly return -EPROBE_DEFER returned by pwrseq_get() in patch 7. Patch 5 makes the USB port device associated with a "port@" fwnode if available. This depends on patch 1. Patch 6 changes usb_port_is_power_on() so that |struct usb_port*| is passed in instead of |struct usb_hub*|. This patch does not change any functionality. Patch 7 lets the USB hub driver look for power sequencers for each port. Currently this only works for M.2 E-key connections, but it could be extended to cover other cases. It should also make port reset via turning off the port VBUS work, even when VBUS is not directly controlled by the hub. This depends on patch 2 (for the new helper) and patch 3 (to avoid allmodconfig link failures). Patch 8 reverts an incorrectly modeled OF graph connection for the MediaTek XHCI controller. Patch 9 then adds a proper representation. Patch 10 adds matching pwrseq consumer by "port@" node to the M.2 slot driver. This is only used for the USB target, but there is no attempt to differentiate the connection type. The driver simply tries matching the "port@" node first, then falling back to the port parent or device's node. Patch 11 reworks the power sequencing targets for the E-key connector in the pcie-m2 driver to add targets for USB and SDIO. The former is used later on in this series. Patches 12 through 16 enable the M.2 E-key slots (used for WiFi/BT) and USB type-A connectors found on MediaTek-based Chromebooks. These are provided in this series for reference. The USB type-A connector changes, while not directly related, have overlapping context, and was easier to include. They were also used to test some extra local changes I tried to convert the USB A connector from an onboard USB device to a power sequencing provider. This series unfortunately spans multiple trees. The way I see it: - Patch 1 and 2 go through the driver core, and an immutable tag is provided to be merged together with the USB patches. - Patch 3 gets an ack from Bartosz, and goes through the USB tree. - Patch 4 through 9 (all the USB related ones) go through the USB tree, along with the dependencies above. - Patch 10 and 11 go through the power sequencing tree. - Patch 12 through 16 (device tree only) go through the soc tree via the mediatek tree. Some of us discussed v1 at Embedded Recipes, and I believe Bartosz, Mani and I agree on this approach. The debate is likely going to be on whether this should be integrated into the USB core or not. I believe it should, so that the power sequencing timing is tied to the USB port being brought up. I do have a fallback option of just enabling the USB power sequencing target inside the M.2 slot driver if a valid OF graph connection is seen. But this is less desired for the reason given above. Please have a look and share your thoughts. Thanks ChenYu [1] https://lore.kernel.org/all/20260326-pci-m2-e-v7-0-43324a7866e6@oss.qualcomm.com/ Chen-Yu Tsai (16): device property: Add fwnode_graph_get_port_by_id() device property: Add fwnode_graph_get_next_port_endpoint() power: sequencing: Change CONFIG_POWER_SEQUENCING to bool usb: hub: Return actual error from hub_configure() in hub_probe() usb: hub: Associate port@ fwnode with USB port device usb: hub: Pass |struct usb_port*| to usb_port_is_power_on() usb: hub: Power on connected M.2 E-key connectors Revert "dt-bindings: usb: mediatek,mtk-xhci: Add port for SuperSpeed EP" dt-bindings: usb: mediatek,mtk-xhci: Allow ports for USB connections power: sequencing: pcie-m2: support matching on remote "port" node power: sequencing: pcie-m2: Add usb and sdio targets for E-key connector arm64: dts: mediatek: mt8192-asurada: Add USB type-A connector arm64: dts: mediatek: mt8192-asurada: Add M.2 E-key slot arm64: dts: mediatek: mt8195-cherry: Add M.2 E-key slot arm64: dts: mediatek: mt8195-cherry: Add USB type-A connector arm64: dts: mediatek: mt8188-geralt: Add WiFi/BT as M.2 E-key slot .../bindings/usb/mediatek,mtk-xhci.yaml | 17 +- .../boot/dts/mediatek/mt8188-geralt.dtsi | 93 ++++++++++- .../boot/dts/mediatek/mt8192-asurada.dtsi | 139 +++++++++++++++-- .../boot/dts/mediatek/mt8195-cherry.dtsi | 147 +++++++++++++++++- drivers/base/property.c | 55 +++++++ drivers/power/sequencing/Kconfig | 2 +- drivers/power/sequencing/pwrseq-pcie-m2.c | 50 ++++-- drivers/usb/core/hub.c | 55 +++++-- drivers/usb/core/hub.h | 6 +- drivers/usb/core/port.c | 72 ++++++++- include/linux/property.h | 3 + 11 files changed, 583 insertions(+), 56 deletions(-) -- 2.54.0.1099.g489fc7bff1-goog