From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sudeep Holla <sudeep.holla@kernel.org>
Cc: Breno Leitao <leitao@debian.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
Pierre Gondois <pierre.gondois@arm.com>,
driver-core@lists.linux.dev, linux-kernel@vger.kernel.org,
kernel-team@meta.com
Subject: Re: [PATCH v2] cacheinfo: don't propagate DT/ACPI error when arch supplies info (arm64)
Date: Fri, 12 Jun 2026 16:14:55 +0200 [thread overview]
Message-ID: <2026061242-riverbed-drench-1e2a@gregkh> (raw)
In-Reply-To: <20260612-jumping-spaniel-of-expertise-cbadcd@sudeepholla>
On Fri, Jun 12, 2026 at 01:48:36PM +0100, Sudeep Holla wrote:
> On Thu, Jun 11, 2026 at 04:55:13AM -0700, Breno Leitao wrote:
> > cache_setup_properties() sets use_arch_info = true when DT/ACPI
> > provide no cache nodes and the arch can derive the topology from
> > CPU registers (e.g. arm64 reading CLIDR_EL1), but still returns the
> > original -ENOENT. cache_shared_cpu_map_setup() bails on that error
> > before the new flag can take effect, so the first CPU brought online
> > always trips a misleading warning:
> >
> > cacheinfo: Unable to detect cache hierarchy for CPU 0
> >
> > Subsequent CPUs skip cache_setup_properties() entirely because
> > use_arch_info is now true, which is why only CPU0 hits it. This is
> > reproducible on arm64 with the QEMU 'virt' machine, whose default DT
> > has no cache nodes.
> >
> > Clear ret after setting use_arch_info so the caller proceeds and
> > populates the shared cpu map via the arch-supplied leaves.
> >
>
> LGTM,
>
> Reviewed-by: Sudeep Holla <sudeep.holla@kernel.org>
>
> Greg,
>
> Can you pick up this one as part of your next round of fixes if any or
> for v7.2 ?
I'll get to it after 7.2-rc1 is out, thanks.
greg k-h
prev parent reply other threads:[~2026-06-12 14:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-11 11:55 [PATCH v2] cacheinfo: don't propagate DT/ACPI error when arch supplies info (arm64) Breno Leitao
2026-06-12 12:48 ` Sudeep Holla
2026-06-12 14:14 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026061242-riverbed-drench-1e2a@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dakr@kernel.org \
--cc=driver-core@lists.linux.dev \
--cc=kernel-team@meta.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre.gondois@arm.com \
--cc=rafael@kernel.org \
--cc=sudeep.holla@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox