Re: [PATCH v1 0/4] gpio: regmap: Keep tracking IRQ requests and releases

[William Breathitt Gray <wbg@kernel.org>]

On Thu, Jul 02, 2026 at 02:42:53PM +0200, Andy Shevchenko wrote:
> During the review of the v3 [1] of the series that adds a driver for
> Realtek DHC RTD1625 SoC GPIO the gap in the GPIO regmap implementation
> has been discovered, id est the IRQ chip that is created by regmap IRQ
> doesn't have IRQ request and release callbacks and hence in terms of
> GPIO does not track if any line is locked as IRQ. This might lead to
> undesired and most likely faulty behaviour. This series is to fill that
> gap. Currently it only fixes the only user of the automatic IRQ chip
> creation facility provided by GPIO regmap, but also provides the exported
> callbacks for others to be possible to call them from customised versions
> of the callbacks in the respective drivers.
> 
> Most of the affected drivers if I am not mistaken are the Industrial PC104
> ones, hence I Cc'ed William to look at this and perhaps even test.

Hi Andy,

I'll take a look at these patches when I get a chance. For now, I'll CC
Fred Eckert and Matthew Mohn who have tested these PC104 drivers in the
past and may be interested in this patchset.

Thanks,

William Breathitt Gray

> 
> Yu-Chun, can you give a try with your v3 based on this series? I believe
> we can use regmap approach after all.
> 
> The merge strategy is to go via GPIO tree with the immutable branch or tag
> provided for the first patch that can be done by regmap tree for others to
> consume. Of course, there are possible options, I'm all ears if you think it
> will be better in any other way.
> 
> Link: https://lore.kernel.org/all/20260512033317.1602537-1-eleanor.lin@realtek.com/ [1]
> 
> Andy Shevchenko (4):
>   regmap-irq: Provide IRQ resource request and release callbacks
>   gpio: regmap: Provide default IRQ resource request and release
>     callbacks
>   gpio: regmap: Apply default resource callbacks for regmap IRQ chip
>   gpio: regmap: Order kernel-doc descriptions with the actual appearance
> 
>  drivers/base/regmap/regmap-irq.c | 22 ++++++++++++++++++++++
>  drivers/gpio/gpio-max7360.c      |  7 ++++---
>  drivers/gpio/gpio-regmap.c       | 25 +++++++++++++++++++++++++
>  include/linux/gpio/regmap.h      | 21 ++++++++++++---------
>  include/linux/regmap.h           |  2 ++
>  5 files changed, 65 insertions(+), 12 deletions(-)
> 
> --
> 2.50.1
>