From: phucduc.bui@gmail.com
To: Mark Brown <broonie@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
rafael@kernel.org
Cc: Danilo Krummrich <dakr@kernel.org>,
linux-kernel@vger.kernel.org, driver-core@lists.linux.dev,
bui duc phuc <phucduc.bui@gmail.com>
Subject: [PATCH 2/2] regcache: Mark cache dirty if selector register rewrite fails
Date: Mon, 13 Jul 2026 12:03:12 +0700 [thread overview]
Message-ID: <20260713050312.38729-3-phucduc.bui@gmail.com> (raw)
In-Reply-To: <20260713050312.38729-1-phucduc.bui@gmail.com>
From: bui duc phuc <phucduc.bui@gmail.com>
After a successful cache synchronization, regcache_sync() clears
cache_dirty. If rewriting a selector register later fails, the cache
and hardware become inconsistent while the cache still appears clean.
Update cache_dirty to reflect the cache and hardware state when
selector register rewriting fails.
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
drivers/base/regmap/regcache.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c
index 040fd60c0d59..96cdae25b9c4 100644
--- a/drivers/base/regmap/regcache.c
+++ b/drivers/base/regmap/regcache.c
@@ -465,6 +465,7 @@ int regcache_sync(struct regmap *map)
selector_ret = _regmap_write(map, this->selector_reg, i);
if (selector_ret != 0) {
+ map->cache_dirty = true;
dev_err(map->dev, "Failed to write %x = %x: %d\n",
this->selector_reg, i, selector_ret);
break;
--
2.43.0
prev parent reply other threads:[~2026-07-13 5:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 5:03 [PATCH 0/2] regmap: Improve error handling in regcache_sync() phucduc.bui
2026-07-13 5:03 ` [PATCH 1/2] regcache: Preserve cache synchronization errors " phucduc.bui
2026-07-13 5:03 ` phucduc.bui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260713050312.38729-3-phucduc.bui@gmail.com \
--to=phucduc.bui@gmail.com \
--cc=broonie@kernel.org \
--cc=dakr@kernel.org \
--cc=driver-core@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox