From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA7B73D9534 for ; Wed, 15 Jul 2026 08:54:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784105678; cv=none; b=cEa3laTv8HH86TqpvChzN/OYjJ/MBVM0xW+2Mifs7Rag13aixco70bhTzhOq0VIfX0T4i4mB/cgqouZerhohuWNF5oCuUgCuhguAe3vvgEaEUhV+1l6rPco6QJSJr42AMHEy8627/QEo3mml4noGMZHBBAk37XhtDMATtBM2tmQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784105678; c=relaxed/simple; bh=OlqZwr18Cpifvs6/MASST22KmUKK2zb2fxpZOLeBWT0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KZKxnVk2DssIBr4OlUA9dW8NqiO7zVGz8OvIPEUvsP7LHV0TCjB/OrXGvBxZPP2Pot1lyXVIqbcbVNKa0LyRXoJIIFaV3poM1QSnLdcZUKNSr+rEOH0XrvxNy38NLofGqVIX6dwq0b6HAkMauUggDUAbed+OindkNjTKxVV1sOw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=QGmh4Sr9; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="QGmh4Sr9" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-84536ecfc5bso1731821b3a.2 for ; Wed, 15 Jul 2026 01:54:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1784105676; x=1784710476; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dYICwpllA6REcHU83KV0EGKSQt2kKv+TAZuxEKEYalU=; b=QGmh4Sr9/H6nS8KfC0+IfGdJM5mWWNL9AlANNp5XyNwfyNsat8+ZaQVj8U7thkfCBr bvCxYwHVUbDcY6e9Inab2ZX9JJlTfGUOrHH4MBkixjaQB7dcSc4WkI0IVuKOfPl2Ii63 6RJUNozP7Bjd1Ut7PU7tkn2Ax/H1fDkTo+M2E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784105676; x=1784710476; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=dYICwpllA6REcHU83KV0EGKSQt2kKv+TAZuxEKEYalU=; b=iB4slmW1Y+oPfg0Xc/tF3d34LHHZ/UeHzSrRUWP994G9khWvbhR+q9eGihwNFaLZPz nuMxA9Cy39Mo9pzejJ5aZwretPPSxIHFa0/dTXG+Ul5HwH5OB1bu938p9d26tXi1CrvM fE8vTa6ZsfN0Ug9Uwit8E3wzrlduYC2tbQJQoVZ6KLyYISrMqXURtE5feJwkSSAwIOsU EcIbTdLxdDf0BGGl0E0iWR8Sjg7JexsUuiYPB3/juPzZW3SPY9nsUlA140LUA3qp1DN6 NEx5cZos25TomC5w8H1NW8Td0Q/IKR71k7RUUT5Yy/qpBqR+yqxcBCzOD4R7KCGjx+vH 4gsQ== X-Forwarded-Encrypted: i=1; AHgh+Rq6Yp5V4hrYZiUxO5ciHhXMUopzV7Tsgngo2u3lUM3eOpFuvKACjQDDzmpNcJtAsArLmQ+g4tvABlyV+g==@lists.linux.dev X-Gm-Message-State: AOJu0YwzrT7lyf6zoYUythDziTNX+Ve36MTW+sydsXF/rSyEATPu+6H+ +hfazoTdwVhQ0nFeZzP5q67DUN8vMCKso+BIlwcrXlEUzMLDNoQYpWmGgFCVWCWOsQ== X-Gm-Gg: AfdE7cnWO3JdDX6tiGLz3c9cz71z3khp8DtBG/YZRAhliCnRHcS0K+kK38plQx0Q267 6jAdZ4ygvnA15S/Kk2Y8WunTDteNs8U5rWkKX2rn6WmLR1mDtHSYVx3aHw9oYy1JOMcPSUbuAl+ h0QvWyuNiIA+dpuH5+eVJvd5wjl3axKzxPXKRleKjfkzCon/67yWXbxFJXjvYC2NgIt5HQuK+aW o7RvnmUd6cvjuXR+IJTu6ePVFpE63jYSype2YDSYQ8v+xVpHClbK6b5MUlfFpcbT+LrpH2dFxM9 cxZLcqDKEbvam06KIEkxjOHou4wjkqgIxnhpXoUqwt1RVacp8a7zSXEK5dyy15v+9pIaA7zhamr Gdc/aF3CpQOg2Ri5hbgZ3Y1YklnTcZ4vzWh/IEjMNvWxN8GH5T3AqNen9+Mq3FUWxtjrX9F+Dav QdAboVh7pi8LTq66w6jNcLM5y7yGEvpXlxSwGok406BpDOCI0kxvyw5fEhQF7+4vXuCeMY3frSW GW3AmSb X-Received: by 2002:a05:6a00:17a4:b0:848:88e6:95d3 with SMTP id d2e1a72fcca58-84a673928d8mr1756444b3a.72.1784105676023; Wed, 15 Jul 2026 01:54:36 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2a00:79e0:201d:8:47d7:4aa5:a6f8:2279]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84a4f819117sm2757491b3a.59.2026.07.15.01.54.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 01:54:35 -0700 (PDT) From: Chen-Yu Tsai To: Bartosz Golaszewski , Greg Kroah-Hartman , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , "Rafael J. Wysocki" , Danilo Krummrich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno Cc: Wei Deng , Chen-Yu Tsai , linux-acpi@vger.kernel.org, driver-core@lists.linux.dev, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Alan Stern Subject: [PATCH v5 04/16] usb: hub: Use assign_bit() in usb_hub_set_port_power() Date: Wed, 15 Jul 2026 16:53:34 +0800 Message-ID: <20260715085348.3457359-5-wenst@chromium.org> X-Mailer: git-send-email 2.55.0.141.g00534a21ce-goog In-Reply-To: <20260715085348.3457359-1-wenst@chromium.org> References: <20260715085348.3457359-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: driver-core@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit usb_hub_set_port_power() open-codes assign_bit(). Just use the assign_bit() macro instead. This makes subsequent additions to usb_hub_set_port_power() easier to read. This change does not introduce any functional changes. Suggested-by: Andy Shevchenko Signed-off-by: Chen-Yu Tsai --- Attributing suggestion to Andy, since the change was originally requested as part of a review. Changes since v4: - New patch (split out from "usb: hub: Power on connected M.2 E-key connectors with power sequencing API") (Andy) --- drivers/usb/core/hub.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 9b2bf608f9cc..36342c5718bb 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -10,6 +10,7 @@ * Released under the GPLv2 only. */ +#include #include #include #include @@ -896,10 +897,7 @@ int usb_hub_set_port_power(struct usb_device *hdev, struct usb_hub *hub, if (ret) return ret; - if (set) - set_bit(port1, hub->power_bits); - else - clear_bit(port1, hub->power_bits); + assign_bit(port1, hub->power_bits, set); return 0; } -- 2.55.0.795.g602f6c329a-goog