From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-24416.protonmail.ch (mail-24416.protonmail.ch [109.224.244.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2EA12F6920 for ; Sun, 27 Sep 2026 18:12:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=109.224.244.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790532729; cv=none; b=jH87QH0ZhGisysd0sg+pNmpuM9Xk6nQ1zSLe9e+nSFNBCZbkp0q0IHn1H8xormAWbULrtnxOQsmDsHC1bBrEvHkdpj007ZoCGVHnsrPwONLRqkHN29gFC+Y4NdsrGudUC/q1juzQMi4O7sj4FacNiwtXmbTAvoRaV5YW5QegH4Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790532729; c=relaxed/simple; bh=BaA+PvTIQkJ8Rsg8Gex3ng2jCts9EGUcExk5dx8M/ZU=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hsl/JMVNWjv+tjrRs0BuI8SBsiHNa0h6lhReHZE/QpywQgg2kYyd3NvA0MHyGk/pnILLGEkG8OVnen3S+2RtJ2sd7kQJU8E1do6wy2SEauh6Lf1Nv1ydsTJenWoXs3t7nBxkPtMXZ8AsKNFQNOj7+Tr4B6Qp/ikE8dH0GOg+hH8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=proton.me; spf=pass smtp.mailfrom=proton.me; dkim=pass (2048-bit key) header.d=proton.me header.i=@proton.me header.b=Gh7FhbGn; arc=none smtp.client-ip=109.224.244.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=proton.me Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=proton.me Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=proton.me header.i=@proton.me header.b="Gh7FhbGn" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=sfz2jeqf2ra6deha5l34k43swm.protonmail2; t=1790532721; x=1790791921; bh=BaA+PvTIQkJ8Rsg8Gex3ng2jCts9EGUcExk5dx8M/ZU=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=Gh7FhbGn8KUlaG29K/qsA9gm7ZnxyGWOJIurE59aWJEPrym8NCx6TYC6KDacc70jB TPoVGZgnDRApuPRfFIN9bJ1jXJotl3S/9SV2ePvHNeW/D0inXTl9Qrx/yzPWnCSF12 mJi+Uo8kYI+BHITIrUupGP7n9dCXFcLRqryvOipV8fgshYq+MdpAo9J2z+ewRXxnni tgKmsT/U+gQhn1ppAWYsTktS9kdwqU3MlD2q/JLdRqCRGpqptOroUfkwej249qI6tt nAc2NjgyBN+Ki9iwA/eDmBH14HrrEszHZ0z14nfhtQ+ctUCsdxgIgmIOO26Fm644/d 4DM4mH+iZWkhA== Date: Sun, 27 Sep 2026 18:11:57 +0000 To: Danilo Krummrich From: Lorenzo Delgado Cc: Lorenzo Delgado , Daniel Almeida , Alice Ryhl , David Airlie , Simona Vetter , Alexandre Courbot , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross , Tamir Duberstein , =?utf-8?Q?Onur_=C3=96zkan?= , Abdiel Janulgue , Robin Murphy , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, nova-gpu@lists.linux.dev, driver-core@lists.linux.dev, rust-for-linux@vger.kernel.org Subject: Re: [PATCH v3] rust: io: convert ResourceSize into a transparent newtype Message-ID: <20260927181154.1757237-1-lnsdev@proton.me> In-Reply-To: References: <20260920-resource-size-newtype-v3-1-9451444e83bb@proton.me> Feedback-ID: 53083996:user:proton X-Pm-Message-ID: 541aa433539a53276ac34d20166f44a5eb3c53af Precedence: bulk X-Mailing-List: driver-core@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Thu Sep 24, 2026 at 7:21 PM CEST, Danilo Krummrich wrote: > So, I think we should change dma_len() to just return u32 (I'm also fine = with a > new type, but it might be slighly overkill). > > I'd usually pick this patch regardless and leave that for a follow-up, as= it is > a separate issue. But if we change dma_len() first, we only have to updat= e tyr > once, whereas if change it after we end up touching nova and tyr twice. Makes sense, thanks. I sent v4 with a patch in front that makes dma_len() return u32, so the newtype patch no longer touches tyr or nova-core: https://lore.kernel.org/r/20260927-resource-size-newtype-v4-0-447a08af23fb@= proton.me Heads-up: patch 1 interacts with Alexandre's nova_num on one line in gsp.rs. Whichever lands second needs a two-line fixup; details in the cover letter.