From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.70 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793140767; b=ZUkGhI5OzCxzWpqANQ8mtzqXbaPriUPEXIeaAUliByfaka1sf0zx+osd/UjQ0rlYxD4D isl0Oq3PtH3bPITRI4ra9Gq7QmP2jF6adHW3n44Pydn46Z34ykCtmw69xFPahinl/PgNx NGUcIivalCQLDwip7H/gLT/SIrFj9L+qV/g0hAZvQeBNK0SJTMhm5OuRYN/XqeZrH92U1 0eo1rexj0Tj3txVxVETdHDKmUH7NywoZ0mXqg0yodaFMC4Z7XCrbB/blPbTCWglnpl2l0 SIr5lRY/2KtTXIISvKjGero9TF4743AWmr9UcC6rnjJnQVP9vw0Zzfo9NCLxRjCaGlQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793140767; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:X-Mailer:Message-ID:Subject:From:To:Cc: Content-Type; bh=4zou/7CSV4h/YwAlF7A1OL9kEnFb2HIoLHCAQS8LrD8=; b=jXmsAGCXCzwydez7Bd1GK7iwimu8Ic/+MB4FbeQOj5IjY7Yydqjcuoi3jseVksqWwei0 fJ+1xhoDp12JZk3+LYsyZPc27AOri7Ycf4T8bOTuL8eQc49d8usQkNGs+AcHYmjbLgJTC rWu0D0K35/II6MZ3smSMZyOuaqhdu7HAF5YZiYp/4p9d8bPjsFFbMN+s1ivbGhhT6ratp 6vY/n9OMfnU+mJ+azDJs39KCibEhdCJyNDgvH0ejCJW1TTRu2rs2nH0hobKsyHy6pIw7u iIan18vuQMNtl5uaY0tBXchNmrqDkCDANSTkwMXAnf+D3BvesH+4OphuyvaFATGXmgA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=FUdgB38B; arc=none smtp.remote-ip=74.125.82.70 Received: from mail-dl1-f70.google.com (mail-dl1-f70.google.com [74.125.82.70]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9711A60A3810 for ; Tue, 27 Oct 2026 22:39:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 9711A60A3810 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=FUdgB38B Received: by mail-dl1-f70.google.com with SMTP id a92af1059eb24-139b62317d0so1025588c88.0 for ; Tue, 27 Oct 2026 15:39:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1793140767; x=1793745567; darn=lists.linux.dev; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=4zou/7CSV4h/YwAlF7A1OL9kEnFb2HIoLHCAQS8LrD8=; b=FUdgB38BIOt8V1W765ijEyVAUzNN5JjGfNtnPR1irAvs/uWy/qSKDXK3KNJGLzGYXb lStqDta+kKWc6U4dKmtLUjzTVUXaKcQa7K35q9/uKs/JpEgVmSVMLMkr4T/IVlySki+B U3TSkv7xyiwWQQwgqNbsKwyCf+0qC63YIQhjW2D9dolgLxVSrdGgyZJDDT8RVH65pm9S D1p02DGkSflsNKzlA1ecIKVGRHqA/mFyiaCKalt2A+O2lqP3XU6m64GszgIwrR7D4Wux Syq32UNahYJJZ8fgC5/FmT2sOS77AI0Rqq2Fi3eAK8/4o0Z3N13ymPFjwaugIh+NWtdH qMTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793140767; x=1793745567; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4zou/7CSV4h/YwAlF7A1OL9kEnFb2HIoLHCAQS8LrD8=; b=Is5V34T9YN1RIfExmc9u6hAZq8+K3bkb0N2tUgOldcjQ2QPIPkkXMGsD5q2WS0qS3d oo2roS/xtSYzhAS7RUfm1UMjojEbzRiCL4koHouY7RFPWthSdr8k+EZIQ0xRDCkIU243 x+2z6bHfH2dqnE9k80cuHgnrcgJ9Qn642uABWGF5SQr4/3Mj9JQb5Z/mH2FjfZS9kh9R bExctsbewr300+UDUcRrtYLbA2SkmP8mJQTewQeYC2wtzc5yFokl9ghn2vqhy/PdStDH S6izvM7KdDGhGeTux/qQ2M75R9H+DGStluT8iZw7QQ855qLlSkVfkl9h5Dffbt7cYG1L pvfw== X-Forwarded-Encrypted: i=1; AKwUvBxy1WnCzXBtwT7+vCaK9mtqzO+B1w7fby3puF9sLtGQgSoQuUaHu36E7vh0hwgZZSf8pZqOEeqpoT29Lw==@lists.linux.dev X-Gm-Message-State: AFq9FYIZd4s/4mgCmzdCtlzoFTjQX4YR0hc4No/sSlFGMJsyHeIYyBAy haz1GAT3t9zBJbnfjEull2eXJejlX15wHJeulSxpz4DsE87bGo1ZiCIcCfCEK3hD2lNOW6id96J osjlS6lTu4g== X-Received: from dlbqq10.prod.google.com ([2002:a05:7022:ed0a:b0:1a0:a0b4:204c]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:f115:b0:1a3:6040:bf78 with SMTP id a92af1059eb24-1a6cc34d07bmr917417c88.11.1793140766453; Tue, 27 Oct 2026 15:39:26 -0700 (PDT) Date: Tue, 27 Oct 2026 15:38:41 -0700 In-Reply-To: <20261027223847.652884-1-irogers@google.com> X-Mailing-List: driver-core@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261027223847.652884-1-irogers@google.com> X-Mailer: git-send-email 2.56.0.313.g2479322e68-goog Message-ID: <20261027223847.652884-7-irogers@google.com> Subject: [PATCH v2 6/9] xen/sys-hypervisor: Add release callback to hyp_sysfs_kobj_type From: Ian Rogers To: Kees Cook , Greg Kroah-Hartman , Miguel Ojeda , "Rafael J . Wysocki" , Danilo Krummrich Cc: Nathan Chancellor , Nick Desaulniers , Miguel Ojeda , "=?UTF-8?q?Christian=20K=C3=B6nig?=" , Zhihao Cheng , Zhongqiu Han , Sumanth Korikkar , Bill Wendling , Justin Stitt , driver-core@lists.linux.dev, llvm@lists.linux.dev, linux-hardening@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-s390@vger.kernel.org, gfs2@lists.linux.dev, xen-devel@lists.xenproject.org, linux-mtd@lists.infradead.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ian Rogers , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Jeremy Fitzhardinge Content-Type: text/plain; charset="UTF-8" hypervisor_init() in drivers/base/hypervisor.c creates hypervisor_kobj with kobject_create_and_add() (which allocates a dynamic kobject using dynamic_kobj_ktype), and hypervisor_subsys_init() in drivers/xen/sys-hypervisor.c then overwrites hypervisor_kobj->ktype with &hyp_sysfs_kobj_type, which had no .release callback. Add hyp_sysfs_release() calling kfree(kobj) to preserve the dynamic kobject release behavior. Fixes: cff7e81b3dd7 ("xen: add /sys/hypervisor support") Signed-off-by: Ian Rogers --- drivers/xen/sys-hypervisor.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/xen/sys-hypervisor.c b/drivers/xen/sys-hypervisor.c index 91923242a5ae..0e8a2cd69fd6 100644 --- a/drivers/xen/sys-hypervisor.c +++ b/drivers/xen/sys-hypervisor.c @@ -659,7 +659,13 @@ static const struct sysfs_ops hyp_sysfs_ops = { .store = hyp_sysfs_store, }; +static void hyp_sysfs_release(struct kobject *kobj) +{ + kfree(kobj); +} + static const struct kobj_type hyp_sysfs_kobj_type = { + .release = hyp_sysfs_release, .sysfs_ops = &hyp_sysfs_ops, }; -- 2.56.0.313.g2479322e68-goog