From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.71 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793140771; b=RaAT80mV8b9ggZ/ma1iGv0kijtjvDfz+36pKD+psQWj6GHcpRdklxwdtbklLEcXqNZam s5MOcp/nLTmUX/bSfvACQr5o+AzdvrX4Z0bdAuyHCxVsnMKeTtbY2mOxV8c15iPw4Cwme QGgBDtxPmuQYuEHKrW4D32K7/RxICdwCzoadl8S6XDa7cPWz+WdTt/Qzm51rRfrw9yBSZ JG9UWZS94K075hZKtBPyYezCREJsYNjf0MaX58Sm2lUhuUx4VTBSOes3UgG3D7x2rbqP3 iH0EjSYEDhomyV8qCTm34Q93Fmx4zB6nnc+p5/TApeC0Ip2yC+EK7LzlnM/4Sju+P9g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793140771; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:X-Mailer:Message-ID:Subject:From:To:Cc: Content-Type; bh=aItLXVgOXAbsJZn2OZIWl+3TQwb1N1Woum6UsPYCRPI=; b=JJl88lyZTlaN+kPYkzuFjiOfz/GT+nwMteojqYx/veN/5PR9qptGymWBuH2UpA9t/pC0 Bni2ng+Kfz9Ol4NM6bkNZBcm/BqLHbtiNDKBkpW0nrFevH1qY3yvizNVtRinMTVjikw2X 8Z7KVuBQ12UjUuvPmJ4gaXpTR4Hhl+ochYDf/lp2j0ZUvE7J3yoI2nWRWn0QWkRUko9/0 yivtPewmbU7iG0CnIrIx1A0SGOahC6lr8qCv3TN0AdtXObKhVso9T6rw/SEjjq4MtVF2Q suIlHNomx4znYOcDWjDLD3Qr0RdPE0oqWadaR5NhgaKjLrRzCSDBPEqJWHCVXE/DqRg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=HKssj83b; arc=none smtp.remote-ip=74.125.82.71 Received: from mail-dl1-f71.google.com (mail-dl1-f71.google.com [74.125.82.71]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B55B4606A330 for ; Tue, 27 Oct 2026 22:39:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B55B4606A330 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=HKssj83b Received: by mail-dl1-f71.google.com with SMTP id a92af1059eb24-1a5005fd0f8so277497c88.0 for ; Tue, 27 Oct 2026 15:39:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1793140770; x=1793745570; darn=lists.linux.dev; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=aItLXVgOXAbsJZn2OZIWl+3TQwb1N1Woum6UsPYCRPI=; b=HKssj83bKsGqonD+JCmyfI28Vt2PijKRfIyCUNVd1m4pmjBhLj2+jg3roP+RYIKlYq jjjX8wsUPR1nG7Sw428VdQepE5oVcygjjf3GbPmxJND2Dr5DIuRbKTdNYbxOtRnIyjBL adBIiNfWb7uV8aY0mUlaRGNHcYjcZuU3LgyfEoY5nfOGqJ5qQTQKY4jg6vAaAIzg8Pge UGDuduHZx6eU8Tp3ovZXG89IhyyzWFrM4WHnYzjiYph5jPmzuVLHvKc3X/bEdWePVO/J A0AHRhqDLisvyD8R8+60NBFhRohuTzxH2cyjzwvs610jSCbrkeA7YXyPKoU8ImQY2ax/ 55Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793140770; x=1793745570; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aItLXVgOXAbsJZn2OZIWl+3TQwb1N1Woum6UsPYCRPI=; b=GP83+az2icjfbohf9D8J2NM2RAkJbw7uvDMyqgMJhR2+1tTWmWsmNfOYPlU72I0Irn BxnNaiqEsoQNnrpe0Ww0s2WmgLHRZzbfGaXrwb2wgXF0JE5pk+cQUEQMBcIvLqbBd0Pn Z0OGIG7IDSTa/0VDNT6qO0BHt5XFnvorXgdsDhoZJZGNk6UGbzUCU5yq5oTg65dW7pNy PDNNpbwwlj6l8xor6wY7cH5LM/D9+xC5wG6orENS5E2UhzAjhLVRCyk16vpHbvlNSEBx rMwkwKQRpqwXOXnrW818Kk2N35m8b1djKcZTvQjWmOChhk5+Bwg1BJ5rChItGNGlaJ6c 0pjQ== X-Forwarded-Encrypted: i=1; AKwUvByNv9mF7DCwC+nOcrsREtgfEEjPjB51Z9VZrWJpYtiMRgG0Pu5wgVAkhll/REfkmeSw3/LpkCuMt6JxDw==@lists.linux.dev X-Gm-Message-State: AFq9FYIm0+63CQhS22/6dRiAzfyuKQ8kZ1Q+R254thj4ZkKzBeqlAYkv Ymc0feUeJa/+8OAA8CfsjwQR8YMWvSeJVil9KCk+aWS/tKPwA78cnbr1wDvJZbtnDl8JqIx8AOM ZzSxxr6d8Yg== X-Received: from dld12.prod.google.com ([2002:a05:7022:30c:b0:191:45cb:f8d3]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:607:b0:166:af48:a2ba with SMTP id a92af1059eb24-1a6c2c71125mr1317138c88.0.1793140769446; Tue, 27 Oct 2026 15:39:29 -0700 (PDT) Date: Tue, 27 Oct 2026 15:38:42 -0700 In-Reply-To: <20261027223847.652884-1-irogers@google.com> X-Mailing-List: driver-core@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261027223847.652884-1-irogers@google.com> X-Mailer: git-send-email 2.56.0.313.g2479322e68-goog Message-ID: <20261027223847.652884-8-irogers@google.com> Subject: [PATCH v2 7/9] ubifs: sysfs: Use kset_create_and_add() for ubifs_kset From: Ian Rogers To: Kees Cook , Greg Kroah-Hartman , Miguel Ojeda , "Rafael J . Wysocki" , Danilo Krummrich Cc: Nathan Chancellor , Nick Desaulniers , Miguel Ojeda , "=?UTF-8?q?Christian=20K=C3=B6nig?=" , Zhihao Cheng , Zhongqiu Han , Sumanth Korikkar , Bill Wendling , Justin Stitt , driver-core@lists.linux.dev, llvm@lists.linux.dev, linux-hardening@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-s390@vger.kernel.org, gfs2@lists.linux.dev, xen-devel@lists.xenproject.org, linux-mtd@lists.infradead.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ian Rogers , Richard Weinberger , Liu Shixin Content-Type: text/plain; charset="UTF-8" ubifs_kset was a static struct kset using a custom ubifs_ktype that had no default_groups and no .release callback. With CONFIG_DEBUG_KOBJECT_RELEASE=y, unloading the ubifs module while delayed kobject release is pending causes a use-after-free on the static kset. Replace the static ubifs_kset and empty ubifs_ktype with a dynamically allocated kset via kset_create_and_add(). Fixes: 203a55f04f66 ("ubifs: Fix memory leak in ubifs_sysfs_init()") Tested-by: Zhihao Cheng Reviewed-by: Zhihao Cheng Signed-off-by: Ian Rogers --- fs/ubifs/sysfs.c | 24 +++++++----------------- 1 file changed, 7 insertions(+), 17 deletions(-) diff --git a/fs/ubifs/sysfs.c b/fs/ubifs/sysfs.c index dbf967dcf26e..e20931e3a62f 100644 --- a/fs/ubifs/sysfs.c +++ b/fs/ubifs/sysfs.c @@ -80,13 +80,7 @@ static const struct kobj_type ubifs_sb_ktype = { .release = ubifs_sb_release, }; -static const struct kobj_type ubifs_ktype = { - .sysfs_ops = &ubifs_attr_ops, -}; - -static struct kset ubifs_kset = { - .kobj = {.ktype = &ubifs_ktype}, -}; +static struct kset *ubifs_kset; int ubifs_sysfs_register(struct ubifs_info *c) { @@ -107,7 +101,7 @@ int ubifs_sysfs_register(struct ubifs_info *c) goto out_free; } - c->kobj.kset = &ubifs_kset; + c->kobj.kset = ubifs_kset; init_completion(&c->kobj_unregister); ret = kobject_init_and_add(&c->kobj, &ubifs_sb_ktype, NULL, @@ -139,18 +133,14 @@ void ubifs_sysfs_unregister(struct ubifs_info *c) int __init ubifs_sysfs_init(void) { - int ret; + ubifs_kset = kset_create_and_add("ubifs", NULL, fs_kobj); + if (!ubifs_kset) + return -ENOMEM; - kobject_set_name(&ubifs_kset.kobj, "ubifs"); - ubifs_kset.kobj.parent = fs_kobj; - ret = kset_register(&ubifs_kset); - if (ret) - kset_put(&ubifs_kset); - - return ret; + return 0; } void ubifs_sysfs_exit(void) { - kset_unregister(&ubifs_kset); + kset_unregister(ubifs_kset); } -- 2.56.0.313.g2479322e68-goog